{"thread":{"id":"6911","subject":"[PATCH] Include git-gui credits file in dist.","startedAt":"2007-02-22T04:49:51Z","lastAt":"2007-02-22T04:56:17Z","messageCount":2,"participants":["Shawn O. Pearce"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"35214","messageId":"20070222044951.GA28013@spearce.org","threadId":"6911","inReplyTo":null,"subject":"[PATCH] Include git-gui credits file in dist.","fromName":"Shawn O. Pearce","fromEmail":"spearce@spearce.org","sentAt":"2007-02-22T04:49:51Z","receivedAt":"2007-02-22T04:49:51Z","isPatch":true,"sender":{"key":"spearce@spearce.org","avatar":"https://avatars.githubusercontent.com/u/34844?v=4"},"body":"The Makefile for the git-gui subproject will fail to execute if run\noutside of a git.git directory, such as when building from a .tar.gz\nor .tar.bz2.  This is because it is looking for the credits file,\nwhich was created but omitted from the tarball by the toplevel\nMakefile.\n\n---\n\n This has to go on `maint` before you create the release tarball\n for 1.5.0.2, otherwise 1.5.0.2 cannot be compiled outside of a\n git.git repository.\n\n Makefile |    3 ++-\n 1 files changed, 2 insertions(+), 1 deletions(-)\n\ndiff --git a/Makefile b/Makefile\nindex 289decd..35be5e2 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -895,7 +895,8 @@ dist: git.spec git-archive\n \t$(TAR) rf $(GIT_TARNAME).tar \\\n \t\t$(GIT_TARNAME)/git.spec \\\n \t\t$(GIT_TARNAME)/version \\\n-\t\t$(GIT_TARNAME)/git-gui/version\n+\t\t$(GIT_TARNAME)/git-gui/version \\\n+\t\t$(GIT_TARNAME)/git-gui/credits\n \t@rm -rf $(GIT_TARNAME)\n \tgzip -f -9 $(GIT_TARNAME).tar\n \n-- \n1.5.0.61.ga0bf\n"},{"id":"35215","messageId":"20070222045617.GA28043@spearce.org","threadId":"6911","inReplyTo":"20070222044951.GA28013@spearce.org","subject":"Re: [PATCH] Include git-gui credits file in dist.","fromName":"Shawn O. Pearce","fromEmail":"spearce@spearce.org","sentAt":"2007-02-22T04:56:17Z","receivedAt":"2007-02-22T04:56:17Z","isPatch":true,"sender":{"key":"spearce@spearce.org","avatar":"https://avatars.githubusercontent.com/u/34844?v=4"},"body":"\"Shawn O. Pearce\" <spearce@spearce.org> wrote:\n> The Makefile for the git-gui subproject will fail to execute if run\n> outside of a git.git directory, such as when building from a .tar.gz\n> or .tar.bz2.  This is because it is looking for the credits file,\n> which was created but omitted from the tarball by the toplevel\n> Makefile.\n\nObviously I forgot this little line, sorry:\n\n> Signed-off-by: Shawn O. Pearce <spearce@spearce.org>\n \n-- \nShawn.\n"}]}