threads / patch / 6699

patch, 6 partsbash: Hide diff-stages from completion.

Subject: [PATCH 2/6] bash: Hide diff-stages from completion.

## tl;dr

7 messages between Feb 5, 2007 and Feb 6, 2007. Diffs are folded; open one to read it.

replies: 6people: 3as markdown or json

Shawn O. Pearce· Feb 5, 2007, 20:44 UTC · lore

Apparently nobody really makes use of git-diff-stages, as nobody has complained that it is not supported by the git-diff frontend. Since its likely this will go away in the future, we should not offer it as a possible subcommand completion.

Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
---
 contrib/completion/git-completion.bash |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
Show changes to contrib/completion/git-completion.bash +1 −0
diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
index c22ff48..c4d433f 100755
--- a/contrib/completion/git-completion.bash
+++ b/contrib/completion/git-completion.bash
@@ -269,6 +269,7 @@ __git_commands ()
 		cvsimport)        : import;;
 		cvsserver)        : daemon;;
 		daemon)           : daemon;;
+		diff-stages)      : nobody uses it;;
 		fsck-objects)     : plumbing;;
 		fetch-pack)       : plumbing;;
 		fmt-merge-msg)    : plumbing;;

-- 
1.5.0.rc3.58.g79812
Jakub Narebski· Feb 5, 2007, 21:01 UTC · re: Shawn O. Pearce · lore

Re: [PATCH 2/6] bash: Hide diff-stages from completion.

Shawn O. Pearce wrote:
> +               diff-stages)      : nobody uses it;;

I'd rather say: plumbing. (Try not to be cute in the code, please. That results in ent axing ;-)

-- 
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git
Shawn O. Pearce· Feb 5, 2007, 21:10 UTC · re: Jakub Narebski · lore

Re: [PATCH 2/6] bash: Hide diff-stages from completion.

Jakub Narebski <jnareb@gmail.com> wrote:
Show 6 quoted lines
> Shawn O. Pearce wrote:
> 
> > +               diff-stages)      : nobody uses it;;
> 
> I'd rather say: plumbing. (Try not to be cute in the code, please. That
> results in ent axing ;-)
Did you miss my 'ask gittus' description for applymbox?  ;-)

Its only documentation for why this item is being omitted. But this table needs to die; its 62 lines long and is updated by hand independent of the other command lists which ship with core Git. The same is true of the config option completion list, that is ~70 lines.

What's with your mail client anyway? The leading whitespace in my patch is showing up here as some horrible non-ASCII character, but I know those were two tabs indenting that line.

-- 
Shawn.
Nicolas Pitre· Feb 5, 2007, 21:27 UTC · re: Shawn O. Pearce · lore

Re: [PATCH 2/6] bash: Hide diff-stages from completion.

On Mon, 5 Feb 2007, Shawn O. Pearce wrote:
Show 6 quoted lines
> Jakub Narebski <jnareb@gmail.com> wrote:
> > [...]
> 
> What's with your mail client anyway?  The leading whitespace in
> my patch is showing up here as some horrible non-ASCII character,
> but I know those were two tabs indenting that line.

Jakub's mail client also keeps on dropping the CC's and more importantly even the email address to who he's replying.

Jakub: this is really really really annoying.  Could you please use a 
sane email client _please_?  I recall it's not the first time this is 
asked of you.
Nicolas
Jakub Narebski· Feb 5, 2007, 22:04 UTC · re: Nicolas Pitre · lore

Re: [PATCH 2/6] bash: Hide diff-stages from completion.

Nicolas Pitre wrote:
Show 15 quoted lines
> On Mon, 5 Feb 2007, Shawn O. Pearce wrote:
> 
>> Jakub Narebski <jnareb@gmail.com> wrote:
>>> [...]
>> 
>> What's with your mail client anyway?  The leading whitespace in
>> my patch is showing up here as some horrible non-ASCII character,
>> but I know those were two tabs indenting that line.
>
> Jakub's mail client also keeps on dropping the CC's and more importantly 
> even the email address to who he's replying.
> 
> Jakub: this is really really really annoying.  Could you please use a 
> sane email client _please_?  I recall it's not the first time this is 
> asked of you.

I don't use _email_ client (unless you Cc to me), but _news_ reader (KNode 0.10.2 from KDE 3.5.3) via GMane NNTP interface. If I'm CC'ed, I try to reply via mail; then CC's are not dropped.

-- 
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git
Nicolas Pitre· Feb 5, 2007, 22:26 UTC · re: Jakub Narebski · lore

Re: [PATCH 2/6] bash: Hide diff-stages from completion.

On Mon, 5 Feb 2007, Jakub Narebski wrote:
Show 12 quoted lines
> Nicolas Pitre wrote:
> 
> > Jakub's mail client also keeps on dropping the CC's and more importantly 
> > even the email address to who he's replying.
> > 
> > Jakub: this is really really really annoying.  Could you please use a 
> > sane email client _please_?  I recall it's not the first time this is 
> > asked of you.
> 
> I don't use _email_ client (unless you Cc to me), but _news_ reader
> (KNode 0.10.2 from KDE 3.5.3) via GMane NNTP interface. If I'm CC'ed,
> I try to reply via mail; then CC's are not dropped.

But this very email of yours is another example of not even managing to put _me_ in the To: field, even less in the CC: field. But unless I'm mistaken you were replying to me.

So please use another form of communication (be it a news reader or an email client or whatever) that follows proper netiquette since your current setup clearly does not.

Nicolas
Jakub Narebski· Feb 6, 2007, 00:27 UTC · re: Nicolas Pitre · lore

Re: [PATCH 2/6] bash: Hide diff-stages from completion.

Nicolas Pitre wrote:
Show 17 quoted lines
> On Mon, 5 Feb 2007, Jakub Narebski wrote:
>> Nicolas Pitre wrote:
>> 
>>> Jakub's mail client also keeps on dropping the CC's and more importantly 
>>> even the email address to who he's replying.
>>> 
>>> Jakub: this is really really really annoying.  Could you please use a 
>>> sane email client _please_?  I recall it's not the first time this is 
>>> asked of you.
>> 
>> I don't use _email_ client (unless you Cc to me), but _news_ reader
>> (KNode 0.10.2 from KDE 3.5.3) via GMane NNTP interface. If I'm CC'ed,
>> I try to reply via mail; then CC's are not dropped.
> 
> But this very email of yours is another example of not even managing to 
> put _me_ in the To: field, even less in the CC: field.  But unless I'm 
> mistaken you were replying to me.
KNode 0.10.2 by default doesn't put original author in Cc:/To:. I'd try
new version (it is high time for an upgrade), perhaps it would behave
better.
 
> So please use another form of communication (be it a news reader or an 
> email client or whatever) that follows proper netiquette since your 
> current setup clearly does not.

I try to use email as it is easier to preserve Cc:/From:. If mail is sent also to me directly, and I don't forget to check email first, I use it (like in this example).

-- 
Jakub Narebski
Poland

← back to recent threads