{"thread":{"id":"6699","subject":"[PATCH 2/6] bash: Hide diff-stages from completion.","startedAt":"2007-02-05T20:44:24Z","lastAt":"2007-02-06T00:27:21Z","messageCount":7,"participants":["Shawn O. Pearce","Jakub Narebski","Nicolas Pitre"],"isPatch":true,"patchVersion":1,"patchTotal":6},"messages":[{"id":"33663","messageId":"20070205204424.GB8824@spearce.org","threadId":"6699","inReplyTo":null,"subject":"[PATCH 2/6] bash: Hide diff-stages from completion.","fromName":"Shawn O. Pearce","fromEmail":"spearce@spearce.org","sentAt":"2007-02-05T20:44:24Z","receivedAt":"2007-02-05T20:44:24Z","isPatch":true,"sender":{"key":"spearce@spearce.org","avatar":"https://avatars.githubusercontent.com/u/34844?v=4"},"body":"Apparently nobody really makes use of git-diff-stages, as nobody\nhas complained that it is not supported by the git-diff frontend.\nSince its likely this will go away in the future, we should not\noffer it as a possible subcommand completion.\n\nSigned-off-by: Shawn O. Pearce <spearce@spearce.org>\n---\n contrib/completion/git-completion.bash |    1 +\n 1 files changed, 1 insertions(+), 0 deletions(-)\n\ndiff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash\nindex c22ff48..c4d433f 100755\n--- a/contrib/completion/git-completion.bash\n+++ b/contrib/completion/git-completion.bash\n@@ -269,6 +269,7 @@ __git_commands ()\n \t\tcvsimport)        : import;;\n \t\tcvsserver)        : daemon;;\n \t\tdaemon)           : daemon;;\n+\t\tdiff-stages)      : nobody uses it;;\n \t\tfsck-objects)     : plumbing;;\n \t\tfetch-pack)       : plumbing;;\n \t\tfmt-merge-msg)    : plumbing;;\n-- \n1.5.0.rc3.58.g79812\n"},{"id":"33670","messageId":"eq85t5$t2n$1@sea.gmane.org","threadId":"6699","inReplyTo":"20070205204424.GB8824@spearce.org","subject":"Re: [PATCH 2/6] bash: Hide diff-stages from completion.","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2007-02-05T21:01:52Z","receivedAt":"2007-02-05T21:01:52Z","isPatch":true,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"Shawn O. Pearce wrote:\n\n> +               diff-stages)      : nobody uses it;;\n\nI'd rather say: plumbing. (Try not to be cute in the code, please. That\nresults in ent axing ;-)\n-- \nJakub Narebski\nWarsaw, Poland\nShadeHawk on #git\n"},{"id":"33672","messageId":"20070205211005.GB8908@spearce.org","threadId":"6699","inReplyTo":"eq85t5$t2n$1@sea.gmane.org","subject":"Re: [PATCH 2/6] bash: Hide diff-stages from completion.","fromName":"Shawn O. Pearce","fromEmail":"spearce@spearce.org","sentAt":"2007-02-05T21:10:05Z","receivedAt":"2007-02-05T21:10:05Z","isPatch":true,"sender":{"key":"spearce@spearce.org","avatar":"https://avatars.githubusercontent.com/u/34844?v=4"},"body":"Jakub Narebski <jnareb@gmail.com> wrote:\n> Shawn O. Pearce wrote:\n> \n> > +               diff-stages)      : nobody uses it;;\n> \n> I'd rather say: plumbing. (Try not to be cute in the code, please. That\n> results in ent axing ;-)\n\nDid you miss my 'ask gittus' description for applymbox?  ;-)\n\nIts only documentation for why this item is being omitted.\nBut this table needs to die; its 62 lines long and is updated\nby hand independent of the other command lists which ship with\ncore Git.  The same is true of the config option completion list,\nthat is ~70 lines.\n\nWhat's with your mail client anyway?  The leading whitespace in\nmy patch is showing up here as some horrible non-ASCII character,\nbut I know those were two tabs indenting that line.\n\n-- \nShawn.\n"},{"id":"33673","messageId":"Pine.LNX.4.64.0702051623360.19212@xanadu.home","threadId":"6699","inReplyTo":"20070205211005.GB8908@spearce.org","subject":"Re: [PATCH 2/6] bash: Hide diff-stages from completion.","fromName":"Nicolas Pitre","fromEmail":"nico@cam.org","sentAt":"2007-02-05T21:27:47Z","receivedAt":"2007-02-05T21:27:47Z","isPatch":true,"sender":{"key":"nico@fluxnic.net","avatar":"https://avatars.githubusercontent.com/u/702790?v=4"},"body":"On Mon, 5 Feb 2007, Shawn O. Pearce wrote:\n\n> Jakub Narebski <jnareb@gmail.com> wrote:\n> > [...]\n> \n> What's with your mail client anyway?  The leading whitespace in\n> my patch is showing up here as some horrible non-ASCII character,\n> but I know those were two tabs indenting that line.\n\nJakub's mail client also keeps on dropping the CC's and more importantly \neven the email address to who he's replying.\n\nJakub: this is really really really annoying.  Could you please use a \nsane email client _please_?  I recall it's not the first time this is \nasked of you.\n\n\nNicolas\n"},{"id":"33674","messageId":"eq89ig$ckk$1@sea.gmane.org","threadId":"6699","inReplyTo":"Pine.LNX.4.64.0702051623360.19212@xanadu.home","subject":"Re: [PATCH 2/6] bash: Hide diff-stages from completion.","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2007-02-05T22:04:26Z","receivedAt":"2007-02-05T22:04:26Z","isPatch":true,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"Nicolas Pitre wrote:\n\n> On Mon, 5 Feb 2007, Shawn O. Pearce wrote:\n> \n>> Jakub Narebski <jnareb@gmail.com> wrote:\n>>> [...]\n>> \n>> What's with your mail client anyway?  The leading whitespace in\n>> my patch is showing up here as some horrible non-ASCII character,\n>> but I know those were two tabs indenting that line.\n>\n> Jakub's mail client also keeps on dropping the CC's and more importantly \n> even the email address to who he's replying.\n> \n> Jakub: this is really really really annoying.  Could you please use a \n> sane email client _please_?  I recall it's not the first time this is \n> asked of you.\n\nI don't use _email_ client (unless you Cc to me), but _news_ reader\n(KNode 0.10.2 from KDE 3.5.3) via GMane NNTP interface. If I'm CC'ed,\nI try to reply via mail; then CC's are not dropped.\n\n-- \nJakub Narebski\nWarsaw, Poland\nShadeHawk on #git\n"},{"id":"33676","messageId":"Pine.LNX.4.64.0702051719480.19212@xanadu.home","threadId":"6699","inReplyTo":"eq89ig$ckk$1@sea.gmane.org","subject":"Re: [PATCH 2/6] bash: Hide diff-stages from completion.","fromName":"Nicolas Pitre","fromEmail":"nico@cam.org","sentAt":"2007-02-05T22:26:20Z","receivedAt":"2007-02-05T22:26:20Z","isPatch":true,"sender":{"key":"nico@fluxnic.net","avatar":"https://avatars.githubusercontent.com/u/702790?v=4"},"body":"On Mon, 5 Feb 2007, Jakub Narebski wrote:\n\n> Nicolas Pitre wrote:\n> \n> > Jakub's mail client also keeps on dropping the CC's and more importantly \n> > even the email address to who he's replying.\n> > \n> > Jakub: this is really really really annoying.  Could you please use a \n> > sane email client _please_?  I recall it's not the first time this is \n> > asked of you.\n> \n> I don't use _email_ client (unless you Cc to me), but _news_ reader\n> (KNode 0.10.2 from KDE 3.5.3) via GMane NNTP interface. If I'm CC'ed,\n> I try to reply via mail; then CC's are not dropped.\n\nBut this very email of yours is another example of not even managing to \nput _me_ in the To: field, even less in the CC: field.  But unless I'm \nmistaken you were replying to me.\n\nSo please use another form of communication (be it a news reader or an \nemail client or whatever) that follows proper netiquette since your \ncurrent setup clearly does not.\n\n\nNicolas\n"},{"id":"33680","messageId":"200702060127.21536.jnareb@gmail.com","threadId":"6699","inReplyTo":"Pine.LNX.4.64.0702051719480.19212@xanadu.home","subject":"Re: [PATCH 2/6] bash: Hide diff-stages from completion.","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2007-02-06T00:27:21Z","receivedAt":"2007-02-06T00:27:21Z","isPatch":true,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"Nicolas Pitre wrote:\n> On Mon, 5 Feb 2007, Jakub Narebski wrote:\n>> Nicolas Pitre wrote:\n>> \n>>> Jakub's mail client also keeps on dropping the CC's and more importantly \n>>> even the email address to who he's replying.\n>>> \n>>> Jakub: this is really really really annoying.  Could you please use a \n>>> sane email client _please_?  I recall it's not the first time this is \n>>> asked of you.\n>> \n>> I don't use _email_ client (unless you Cc to me), but _news_ reader\n>> (KNode 0.10.2 from KDE 3.5.3) via GMane NNTP interface. If I'm CC'ed,\n>> I try to reply via mail; then CC's are not dropped.\n> \n> But this very email of yours is another example of not even managing to \n> put _me_ in the To: field, even less in the CC: field.  But unless I'm \n> mistaken you were replying to me.\n\nKNode 0.10.2 by default doesn't put original author in Cc:/To:. I'd try\nnew version (it is high time for an upgrade), perhaps it would behave\nbetter.\n \n> So please use another form of communication (be it a news reader or an \n> email client or whatever) that follows proper netiquette since your \n> current setup clearly does not.\n\nI try to use email as it is easier to preserve Cc:/From:. If mail is sent\nalso to me directly, and I don't forget to check email first, I use it\n(like in this example).\n-- \nJakub Narebski\nPoland\n"}]}