threads / patch / 66829

patchrefs: drop unused `peel_iterated_oid()` declaration

Subject: [PATCH] refs: drop unused `peel_iterated_oid()` declaration

## tl;dr

3 messages between Nov 12, 2026 and Nov 13, 2026. Diffs are folded; open one to read it.

replies: 2people: 3as markdown or json

Yusuke Hayashi via B4 Relay· Nov 12, 2026, 05:57 UTC · lore
From: Yusuke Hayashi <yusuke8h@gmail.com>

Commit 5a5c7359f7 (refs: drop `current_ref_iter` hack, 2025-10-23) removed `peel_iterated_oid()` from "refs.c" after converting all of its callers to `reference_get_peeled_oid()`, leaving behind the declaration in "refs.h".

Remove the unused declaration and its comment.
Signed-off-by: Yusuke Hayashi <yusuke8h@gmail.com>
---
 refs.h | 13 -------------
 1 file changed, 13 deletions(-)
Show changes to refs.h +0 −13
diff --git a/refs.h b/refs.h
index ee3b8a62ef..73076cba2f 100644
--- a/refs.h
+++ b/refs.h
@@ -178,19 +178,6 @@ void ref_store_release(struct ref_store *ref_store);
  */
 int ref_store_remove_on_disk(struct ref_store *refs, struct strbuf *err);
 
-/*
- * Return the peeled value of the oid currently being iterated via
- * for_each_ref(), etc. This is equivalent to calling:
- *
- *   peel_object(r, oid, &peeled);
- *
- * with the "oid" value given to the refs_for_each_cb callback, except
- * that some ref storage may be able to answer the query without
- * actually loading the object in memory.
- */
-int peel_iterated_oid(struct repository *r,
-		      const struct object_id *base, struct object_id *peeled);
-
 /**
  * Resolve refname in the nested "gitlink" repository in the specified
  * submodule (which must be non-NULL). If the resolution is

---
base-commit: 1891de46f79dc444a47db1c87bd0c8c76b5463f2
change-id: 20261112-refs-drop-peel-iterated-oid-ede2901e1c5a
Junio C Hamano· Nov 12, 2026, 18:45 UTC · re: Yusuke Hayashi via B4 Relay · lore

Re: [PATCH] refs: drop unused `peel_iterated_oid()` declaration

Yusuke Hayashi via B4 Relay <devnull+yusuke8h.gmail.com@kernel.org> writes:

Show 13 quoted lines
> From: Yusuke Hayashi <yusuke8h@gmail.com>
>
> Commit 5a5c7359f7 (refs: drop `current_ref_iter` hack, 2025-10-23)
> removed `peel_iterated_oid()` from "refs.c" after converting all of its
> callers to `reference_get_peeled_oid()`, leaving behind the declaration
> in "refs.h".
>
> Remove the unused declaration and its comment.
>
> Signed-off-by: Yusuke Hayashi <yusuke8h@gmail.com>
> ---
>  refs.h | 13 -------------
>  1 file changed, 13 deletions(-)
obviously correct ;-)  Thanks, will queue.
Show 29 quoted lines
>
> diff --git a/refs.h b/refs.h
> index ee3b8a62ef..73076cba2f 100644
> --- a/refs.h
> +++ b/refs.h
> @@ -178,19 +178,6 @@ void ref_store_release(struct ref_store *ref_store);
>   */
>  int ref_store_remove_on_disk(struct ref_store *refs, struct strbuf *err);
>  
> -/*
> - * Return the peeled value of the oid currently being iterated via
> - * for_each_ref(), etc. This is equivalent to calling:
> - *
> - *   peel_object(r, oid, &peeled);
> - *
> - * with the "oid" value given to the refs_for_each_cb callback, except
> - * that some ref storage may be able to answer the query without
> - * actually loading the object in memory.
> - */
> -int peel_iterated_oid(struct repository *r,
> -		      const struct object_id *base, struct object_id *peeled);
> -
>  /**
>   * Resolve refname in the nested "gitlink" repository in the specified
>   * submodule (which must be non-NULL). If the resolution is
>
> ---
> base-commit: 1891de46f79dc444a47db1c87bd0c8c76b5463f2
> change-id: 20261112-refs-drop-peel-iterated-oid-ede2901e1c5a
Patrick Steinhardt· Nov 13, 2026, 07:04 UTC · re: Junio C Hamano · lore

Re: [PATCH] refs: drop unused `peel_iterated_oid()` declaration

On Thu, Nov 12, 2026 at 10:45:00AM -0800, Junio C Hamano wrote:
Show 18 quoted lines
> Yusuke Hayashi via B4 Relay <devnull+yusuke8h.gmail.com@kernel.org>
> writes:
> 
> > From: Yusuke Hayashi <yusuke8h@gmail.com>
> >
> > Commit 5a5c7359f7 (refs: drop `current_ref_iter` hack, 2025-10-23)
> > removed `peel_iterated_oid()` from "refs.c" after converting all of its
> > callers to `reference_get_peeled_oid()`, leaving behind the declaration
> > in "refs.h".
> >
> > Remove the unused declaration and its comment.
> >
> > Signed-off-by: Yusuke Hayashi <yusuke8h@gmail.com>
> > ---
> >  refs.h | 13 -------------
> >  1 file changed, 13 deletions(-)
> 
> obviously correct ;-)  Thanks, will queue.
Indeed, thanks for cleaning up after me!
Patrick

← back to recent threads