{"thread":{"id":"66829","subject":"[PATCH] refs: drop unused `peel_iterated_oid()` declaration","startedAt":"2026-11-12T05:57:35Z","lastAt":"2026-11-13T07:04:26Z","messageCount":3,"participants":["Yusuke Hayashi via B4 Relay","Junio C Hamano","Patrick Steinhardt"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"558276","messageId":"20261112-refs-drop-peel-iterated-oid-v1-1-7df1c313e293@gmail.com","threadId":"66829","inReplyTo":null,"subject":"[PATCH] refs: drop unused `peel_iterated_oid()` declaration","fromName":"Yusuke Hayashi via B4 Relay","fromEmail":"devnull+yusuke8h.gmail.com@kernel.org","sentAt":"2026-11-12T05:57:35Z","receivedAt":"2026-11-12T05:57:35Z","isPatch":true,"sender":{"key":"name:Yusuke Hayashi","avatar":null},"body":"From: Yusuke Hayashi <yusuke8h@gmail.com>\n\nCommit 5a5c7359f7 (refs: drop `current_ref_iter` hack, 2025-10-23)\nremoved `peel_iterated_oid()` from \"refs.c\" after converting all of its\ncallers to `reference_get_peeled_oid()`, leaving behind the declaration\nin \"refs.h\".\n\nRemove the unused declaration and its comment.\n\nSigned-off-by: Yusuke Hayashi <yusuke8h@gmail.com>\n---\n refs.h | 13 -------------\n 1 file changed, 13 deletions(-)\n\ndiff --git a/refs.h b/refs.h\nindex ee3b8a62ef..73076cba2f 100644\n--- a/refs.h\n+++ b/refs.h\n@@ -178,19 +178,6 @@ void ref_store_release(struct ref_store *ref_store);\n  */\n int ref_store_remove_on_disk(struct ref_store *refs, struct strbuf *err);\n \n-/*\n- * Return the peeled value of the oid currently being iterated via\n- * for_each_ref(), etc. This is equivalent to calling:\n- *\n- *   peel_object(r, oid, &peeled);\n- *\n- * with the \"oid\" value given to the refs_for_each_cb callback, except\n- * that some ref storage may be able to answer the query without\n- * actually loading the object in memory.\n- */\n-int peel_iterated_oid(struct repository *r,\n-\t\t      const struct object_id *base, struct object_id *peeled);\n-\n /**\n  * Resolve refname in the nested \"gitlink\" repository in the specified\n  * submodule (which must be non-NULL). If the resolution is\n\n---\nbase-commit: 1891de46f79dc444a47db1c87bd0c8c76b5463f2\nchange-id: 20261112-refs-drop-peel-iterated-oid-ede2901e1c5a\n\n\n\n"},{"id":"558327","messageId":"xmqqv761j3df.fsf@gitster.g","threadId":"66829","inReplyTo":"20261112-refs-drop-peel-iterated-oid-v1-1-7df1c313e293@gmail.com","subject":"Re: [PATCH] refs: drop unused `peel_iterated_oid()` declaration","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2026-11-12T18:45:00Z","receivedAt":"2026-11-12T18:45:00Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Yusuke Hayashi via B4 Relay <devnull+yusuke8h.gmail.com@kernel.org>\nwrites:\n\n> From: Yusuke Hayashi <yusuke8h@gmail.com>\n>\n> Commit 5a5c7359f7 (refs: drop `current_ref_iter` hack, 2025-10-23)\n> removed `peel_iterated_oid()` from \"refs.c\" after converting all of its\n> callers to `reference_get_peeled_oid()`, leaving behind the declaration\n> in \"refs.h\".\n>\n> Remove the unused declaration and its comment.\n>\n> Signed-off-by: Yusuke Hayashi <yusuke8h@gmail.com>\n> ---\n>  refs.h | 13 -------------\n>  1 file changed, 13 deletions(-)\n\nobviously correct ;-)  Thanks, will queue.\n\n>\n> diff --git a/refs.h b/refs.h\n> index ee3b8a62ef..73076cba2f 100644\n> --- a/refs.h\n> +++ b/refs.h\n> @@ -178,19 +178,6 @@ void ref_store_release(struct ref_store *ref_store);\n>   */\n>  int ref_store_remove_on_disk(struct ref_store *refs, struct strbuf *err);\n>  \n> -/*\n> - * Return the peeled value of the oid currently being iterated via\n> - * for_each_ref(), etc. This is equivalent to calling:\n> - *\n> - *   peel_object(r, oid, &peeled);\n> - *\n> - * with the \"oid\" value given to the refs_for_each_cb callback, except\n> - * that some ref storage may be able to answer the query without\n> - * actually loading the object in memory.\n> - */\n> -int peel_iterated_oid(struct repository *r,\n> -\t\t      const struct object_id *base, struct object_id *peeled);\n> -\n>  /**\n>   * Resolve refname in the nested \"gitlink\" repository in the specified\n>   * submodule (which must be non-NULL). If the resolution is\n>\n> ---\n> base-commit: 1891de46f79dc444a47db1c87bd0c8c76b5463f2\n> change-id: 20261112-refs-drop-peel-iterated-oid-ede2901e1c5a\n\n"},{"id":"558369","messageId":"ava2ejke3jl7Bv5S@pks.im","threadId":"66829","inReplyTo":"xmqqv761j3df.fsf@gitster.g","subject":"Re: [PATCH] refs: drop unused `peel_iterated_oid()` declaration","fromName":"Patrick Steinhardt","fromEmail":"ps@pks.im","sentAt":"2026-11-13T07:04:26Z","receivedAt":"2026-11-13T07:04:26Z","isPatch":true,"sender":{"key":"ps@pks.im","avatar":"https://avatars.githubusercontent.com/u/4056630?v=4"},"body":"On Thu, Nov 12, 2026 at 10:45:00AM -0800, Junio C Hamano wrote:\n> Yusuke Hayashi via B4 Relay <devnull+yusuke8h.gmail.com@kernel.org>\n> writes:\n> \n> > From: Yusuke Hayashi <yusuke8h@gmail.com>\n> >\n> > Commit 5a5c7359f7 (refs: drop `current_ref_iter` hack, 2025-10-23)\n> > removed `peel_iterated_oid()` from \"refs.c\" after converting all of its\n> > callers to `reference_get_peeled_oid()`, leaving behind the declaration\n> > in \"refs.h\".\n> >\n> > Remove the unused declaration and its comment.\n> >\n> > Signed-off-by: Yusuke Hayashi <yusuke8h@gmail.com>\n> > ---\n> >  refs.h | 13 -------------\n> >  1 file changed, 13 deletions(-)\n> \n> obviously correct ;-)  Thanks, will queue.\n\nIndeed, thanks for cleaning up after me!\n\nPatrick\n\n"}]}