patchdoc: remove unnecessary comma in git-rm documentation

7 messages between Sep 23, 2026 and Oct 1, 2026, from parovozik, Junio C Hamano, Khan Zimov.

Plain Markdown or JSON for tools and agents. Diffs are folded; open one to read it.

parovozikSep 23, 2026, 21:31 UTC on lore

Signed-off-by: parovozik <kaliugov@gmail.com>
---
 Documentation/git-rm.adoc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Show changes to Documentation/git-rm.adoc +1 −1

diff --git a/Documentation/git-rm.adoc b/Documentation/git-rm.adoc
index b5ead86796..67061e961f 100644
--- a/Documentation/git-rm.adoc
+++ b/Documentation/git-rm.adoc
@@ -61,7 +61,7 @@ For more details, see the _<pathspec>_ entry in linkgit:gitglossary[7].
 
 `--`::
 	This option can be used to separate command-line options from
-	the list of files, (useful when filenames might be mistaken
+	the list of files (useful when filenames might be mistaken
 	for command-line options).
 
 `--cached`::

-- 
2.52.0.windows.1

Junio C HamanoSep 23, 2026, 22:00 UTC in reply to parovozik on lore

Re: [PATCH] doc: remove unnecessary comma in git-rm documentation

parovozik <kaliugov@gmail.com> writes:

> Signed-off-by: parovozik <kaliugov@gmail.com>

Documentation/SubmittingPatches::[[real-name]]

> ---
>  Documentation/git-rm.adoc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

$ git grep -C1 'separate command-line' Documentation/

shows that ...

Show 11 quoted lines

> diff --git a/Documentation/git-rm.adoc b/Documentation/git-rm.adoc
> index b5ead86796..67061e961f 100644
> --- a/Documentation/git-rm.adoc
> +++ b/Documentation/git-rm.adoc
> @@ -61,7 +61,7 @@ For more details, see the _<pathspec>_ entry in linkgit:gitglossary[7].
>  
>  `--`::
>  	This option can be used to separate command-line options from
> -	the list of files, (useful when filenames might be mistaken
> +	the list of files (useful when filenames might be mistaken
>  	for command-line options).

... an identical text appears once more elsewhere. It would be a good idea to keep them in sync.

>  
>  `--cached`::

parovozikSep 24, 2026, 07:40 UTC in reply to Junio C Hamano on lore

[PATCH v2] doc: remove unnecessary commas in git-add and git-rm documentation

Signed-off-by: parovozik <kaliugov@gmail.com>
---
 Documentation/git-add.adoc | 2 +-
 Documentation/git-rm.adoc  | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Show changes to 2 files +2 −2

Documentation/git-add.adoc, Documentation/git-rm.adoc

diff --git a/Documentation/git-add.adoc b/Documentation/git-add.adoc
index 16b06e38e1..3fc2513a2d 100644
--- a/Documentation/git-add.adoc
+++ b/Documentation/git-add.adoc
@@ -223,7 +223,7 @@ for `git add --no-all <pathspec>...`, i.e. ignored removed files.
 
 `--`::
 	This option can be used to separate command-line options from
-	the list of files, (useful when filenames might be mistaken
+	the list of files (useful when filenames might be mistaken
 	for command-line options).
 
 
diff --git a/Documentation/git-rm.adoc b/Documentation/git-rm.adoc
index b5ead86796..67061e961f 100644
--- a/Documentation/git-rm.adoc
+++ b/Documentation/git-rm.adoc
@@ -61,7 +61,7 @@ For more details, see the _<pathspec>_ entry in linkgit:gitglossary[7].
 
 `--`::
 	This option can be used to separate command-line options from
-	the list of files, (useful when filenames might be mistaken
+	the list of files (useful when filenames might be mistaken
 	for command-line options).
 
 `--cached`::

-- 
2.52.0.windows.1

Junio C HamanoSep 24, 2026, 16:20 UTC in reply to parovozik on lore

Re: [PATCH v2] doc: remove unnecessary commas in git-add and git-rm documentation

parovozik <kaliugov@gmail.com> writes:

Here at the top of the message before your sign-off can be left blank for a trivial change like this patch whose motivation is so obviously good and whose correctness is so clear.

> Signed-off-by: parovozik <kaliugov@gmail.com>

Documentation/SubmittingPatches::[[real-name]]; we prefer to see a name that is not a "handle".

> ---

For a single-patch topic, here under the three-dash line is where you describe what improvements were made relative to previous iteration(s) of your work.

Show 30 quoted lines

>  Documentation/git-add.adoc | 2 +-
>  Documentation/git-rm.adoc  | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/git-add.adoc b/Documentation/git-add.adoc
> index 16b06e38e1..3fc2513a2d 100644
> --- a/Documentation/git-add.adoc
> +++ b/Documentation/git-add.adoc
> @@ -223,7 +223,7 @@ for `git add --no-all <pathspec>...`, i.e. ignored removed files.
>  
>  `--`::
>  	This option can be used to separate command-line options from
> -	the list of files, (useful when filenames might be mistaken
> +	the list of files (useful when filenames might be mistaken
>  	for command-line options).
>  
>  
> diff --git a/Documentation/git-rm.adoc b/Documentation/git-rm.adoc
> index b5ead86796..67061e961f 100644
> --- a/Documentation/git-rm.adoc
> +++ b/Documentation/git-rm.adoc
> @@ -61,7 +61,7 @@ For more details, see the _<pathspec>_ entry in linkgit:gitglossary[7].
>  
>  `--`::
>  	This option can be used to separate command-line options from
> -	the list of files, (useful when filenames might be mistaken
> +	the list of files (useful when filenames might be mistaken
>  	for command-line options).
>  
>  `--cached`::

Khan ZimovSep 29, 2026, 21:02 UTC in reply to Junio C Hamano on lore

[PATCH v3] doc: remove unnecessary commas in git-add and git-rm documentation

Signed-off-by: Khan Zimov <kaliugov@gmail.com>
---
 Documentation/git-add.adoc | 2 +-
 Documentation/git-rm.adoc  | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Show changes to 2 files +2 −2

Documentation/git-add.adoc, Documentation/git-rm.adoc

diff --git a/Documentation/git-add.adoc b/Documentation/git-add.adoc
index 16b06e38e1..3fc2513a2d 100644
--- a/Documentation/git-add.adoc
+++ b/Documentation/git-add.adoc
@@ -223,7 +223,7 @@ for `git add --no-all <pathspec>...`, i.e. ignored removed files.
 
 `--`::
 	This option can be used to separate command-line options from
-	the list of files, (useful when filenames might be mistaken
+	the list of files (useful when filenames might be mistaken
 	for command-line options).
 
 
diff --git a/Documentation/git-rm.adoc b/Documentation/git-rm.adoc
index b5ead86796..67061e961f 100644
--- a/Documentation/git-rm.adoc
+++ b/Documentation/git-rm.adoc
@@ -61,7 +61,7 @@ For more details, see the _<pathspec>_ entry in linkgit:gitglossary[7].
 
 `--`::
 	This option can be used to separate command-line options from
-	the list of files, (useful when filenames might be mistaken
+	the list of files (useful when filenames might be mistaken
 	for command-line options).
 
 `--cached`::

-- 
2.52.0.windows.1

Khan ZimovSep 29, 2026, 21:05 UTC in reply to Junio C Hamano on lore

[PATCH v4] doc: remove unnecessary commas in git-add and git-rm documentation

Signed-off-by: Khan Zimov <kaliugov@gmail.com>
---
Changes since v3:
 - Add changes description.

Changes since v2:
 - Use real name in Signed-off-by (sorry, handle before).

Changes since v1:
 - Also fix the same text in git-add.adoc, so that both files
   stay in sync.

 Documentation/git-add.adoc | 2 +-
 Documentation/git-rm.adoc  | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Show changes to 2 files +2 −2

Documentation/git-add.adoc, Documentation/git-rm.adoc

diff --git a/Documentation/git-add.adoc b/Documentation/git-add.adoc
index 16b06e38e1..3fc2513a2d 100644
--- a/Documentation/git-add.adoc
+++ b/Documentation/git-add.adoc
@@ -223,7 +223,7 @@ for `git add --no-all <pathspec>...`, i.e. ignored removed files.
 
 `--`::
 	This option can be used to separate command-line options from
-	the list of files, (useful when filenames might be mistaken
+	the list of files (useful when filenames might be mistaken
 	for command-line options).
 
 
diff --git a/Documentation/git-rm.adoc b/Documentation/git-rm.adoc
index b5ead86796..67061e961f 100644
--- a/Documentation/git-rm.adoc
+++ b/Documentation/git-rm.adoc
@@ -61,7 +61,7 @@ For more details, see the _<pathspec>_ entry in linkgit:gitglossary[7].
 
 `--`::
 	This option can be used to separate command-line options from
-	the list of files, (useful when filenames might be mistaken
+	the list of files (useful when filenames might be mistaken
 	for command-line options).
 
 `--cached`::

-- 
2.52.0.windows.1

Junio C HamanoOct 1, 2026, 15:31 UTC in reply to Khan Zimov on lore

Re: [PATCH v4] doc: remove unnecessary commas in git-add and git-rm documentation

Khan Zimov <kaliugov@gmail.com> writes:

> Signed-off-by: Khan Zimov <kaliugov@gmail.com>
> ---

Thanks.  Both changes look good.  Let me mark the topic for 'next'.

Show 26 quoted lines

> diff --git a/Documentation/git-add.adoc b/Documentation/git-add.adoc
> index 16b06e38e1..3fc2513a2d 100644
> --- a/Documentation/git-add.adoc
> +++ b/Documentation/git-add.adoc
> @@ -223,7 +223,7 @@ for `git add --no-all <pathspec>...`, i.e. ignored removed files.
>  
>  `--`::
>  	This option can be used to separate command-line options from
> -	the list of files, (useful when filenames might be mistaken
> +	the list of files (useful when filenames might be mistaken
>  	for command-line options).
>  
>  
> diff --git a/Documentation/git-rm.adoc b/Documentation/git-rm.adoc
> index b5ead86796..67061e961f 100644
> --- a/Documentation/git-rm.adoc
> +++ b/Documentation/git-rm.adoc
> @@ -61,7 +61,7 @@ For more details, see the _<pathspec>_ entry in linkgit:gitglossary[7].
>  
>  `--`::
>  	This option can be used to separate command-line options from
> -	the list of files, (useful when filenames might be mistaken
> +	the list of files (useful when filenames might be mistaken
>  	for command-line options).
>  
>  `--cached`::