{"thread":{"id":"66380","subject":"[PATCH] doc: remove unnecessary comma in git-rm documentation","startedAt":"2026-09-23T21:31:52Z","lastAt":"2026-10-01T15:32:02Z","messageCount":7,"participants":["parovozik","Junio C Hamano","Khan Zimov"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"553118","messageId":"20260923213125.1316-1-kaliugov@gmail.com","threadId":"66380","inReplyTo":null,"subject":"[PATCH] doc: remove unnecessary comma in git-rm documentation","fromName":"parovozik","fromEmail":"kaliugov@gmail.com","sentAt":"2026-09-23T21:31:25Z","receivedAt":"2026-09-23T21:31:52Z","isPatch":true,"body":"Signed-off-by: parovozik <kaliugov@gmail.com>\n---\n Documentation/git-rm.adoc | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/Documentation/git-rm.adoc b/Documentation/git-rm.adoc\nindex b5ead86796..67061e961f 100644\n--- a/Documentation/git-rm.adoc\n+++ b/Documentation/git-rm.adoc\n@@ -61,7 +61,7 @@ For more details, see the _<pathspec>_ entry in linkgit:gitglossary[7].\n \n `--`::\n \tThis option can be used to separate command-line options from\n-\tthe list of files, (useful when filenames might be mistaken\n+\tthe list of files (useful when filenames might be mistaken\n \tfor command-line options).\n \n `--cached`::\n-- \n2.52.0.windows.1\n\n"},{"id":"553124","messageId":"xmqqo6dn6329.fsf@gitster.g","threadId":"66380","inReplyTo":"20260923213125.1316-1-kaliugov@gmail.com","subject":"Re: [PATCH] doc: remove unnecessary comma in git-rm documentation","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2026-09-23T22:00:30Z","receivedAt":"2026-09-23T22:00:32Z","isPatch":true,"body":"parovozik <kaliugov@gmail.com> writes:\n\n> Signed-off-by: parovozik <kaliugov@gmail.com>\n\nDocumentation/SubmittingPatches::[[real-name]]\n\n> ---\n>  Documentation/git-rm.adoc | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n\n$ git grep -C1 'separate command-line' Documentation/\n\nshows that ...\n\n> diff --git a/Documentation/git-rm.adoc b/Documentation/git-rm.adoc\n> index b5ead86796..67061e961f 100644\n> --- a/Documentation/git-rm.adoc\n> +++ b/Documentation/git-rm.adoc\n> @@ -61,7 +61,7 @@ For more details, see the _<pathspec>_ entry in linkgit:gitglossary[7].\n>  \n>  `--`::\n>  \tThis option can be used to separate command-line options from\n> -\tthe list of files, (useful when filenames might be mistaken\n> +\tthe list of files (useful when filenames might be mistaken\n>  \tfor command-line options).\n\n... an identical text appears once more elsewhere.  It would be a\ngood idea to keep them in sync.\n\n>  \n>  `--cached`::\n"},{"id":"553146","messageId":"20260924074041.1428-1-kaliugov@gmail.com","threadId":"66380","inReplyTo":"xmqqo6dn6329.fsf@gitster.g","subject":"[PATCH v2] doc: remove unnecessary commas in git-add and git-rm documentation","fromName":"parovozik","fromEmail":"kaliugov@gmail.com","sentAt":"2026-09-24T07:40:41Z","receivedAt":"2026-09-24T07:41:00Z","isPatch":true,"body":"Signed-off-by: parovozik <kaliugov@gmail.com>\n---\n Documentation/git-add.adoc | 2 +-\n Documentation/git-rm.adoc  | 2 +-\n 2 files changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/Documentation/git-add.adoc b/Documentation/git-add.adoc\nindex 16b06e38e1..3fc2513a2d 100644\n--- a/Documentation/git-add.adoc\n+++ b/Documentation/git-add.adoc\n@@ -223,7 +223,7 @@ for `git add --no-all <pathspec>...`, i.e. ignored removed files.\n \n `--`::\n \tThis option can be used to separate command-line options from\n-\tthe list of files, (useful when filenames might be mistaken\n+\tthe list of files (useful when filenames might be mistaken\n \tfor command-line options).\n \n \ndiff --git a/Documentation/git-rm.adoc b/Documentation/git-rm.adoc\nindex b5ead86796..67061e961f 100644\n--- a/Documentation/git-rm.adoc\n+++ b/Documentation/git-rm.adoc\n@@ -61,7 +61,7 @@ For more details, see the _<pathspec>_ entry in linkgit:gitglossary[7].\n \n `--`::\n \tThis option can be used to separate command-line options from\n-\tthe list of files, (useful when filenames might be mistaken\n+\tthe list of files (useful when filenames might be mistaken\n \tfor command-line options).\n \n `--cached`::\n-- \n2.52.0.windows.1\n\n"},{"id":"553204","messageId":"xmqqh5je4o45.fsf@gitster.g","threadId":"66380","inReplyTo":"20260924074041.1428-1-kaliugov@gmail.com","subject":"Re: [PATCH v2] doc: remove unnecessary commas in git-add and git-rm documentation","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2026-09-24T16:20:58Z","receivedAt":"2026-09-24T16:21:00Z","isPatch":true,"body":"parovozik <kaliugov@gmail.com> writes:\n\nHere at the top of the message before your sign-off can be left\nblank for a trivial change like this patch whose motivation is so\nobviously good and whose correctness is so clear.\n\n> Signed-off-by: parovozik <kaliugov@gmail.com>\n\nDocumentation/SubmittingPatches::[[real-name]]; we prefer to see a\nname that is not a \"handle\".\n\n> ---\n\nFor a single-patch topic, here under the three-dash line is where\nyou describe what improvements were made relative to previous\niteration(s) of your work.\n\n>  Documentation/git-add.adoc | 2 +-\n>  Documentation/git-rm.adoc  | 2 +-\n>  2 files changed, 2 insertions(+), 2 deletions(-)\n>\n> diff --git a/Documentation/git-add.adoc b/Documentation/git-add.adoc\n> index 16b06e38e1..3fc2513a2d 100644\n> --- a/Documentation/git-add.adoc\n> +++ b/Documentation/git-add.adoc\n> @@ -223,7 +223,7 @@ for `git add --no-all <pathspec>...`, i.e. ignored removed files.\n>  \n>  `--`::\n>  \tThis option can be used to separate command-line options from\n> -\tthe list of files, (useful when filenames might be mistaken\n> +\tthe list of files (useful when filenames might be mistaken\n>  \tfor command-line options).\n>  \n>  \n> diff --git a/Documentation/git-rm.adoc b/Documentation/git-rm.adoc\n> index b5ead86796..67061e961f 100644\n> --- a/Documentation/git-rm.adoc\n> +++ b/Documentation/git-rm.adoc\n> @@ -61,7 +61,7 @@ For more details, see the _<pathspec>_ entry in linkgit:gitglossary[7].\n>  \n>  `--`::\n>  \tThis option can be used to separate command-line options from\n> -\tthe list of files, (useful when filenames might be mistaken\n> +\tthe list of files (useful when filenames might be mistaken\n>  \tfor command-line options).\n>  \n>  `--cached`::\n"},{"id":"553644","messageId":"20260929210249.1024-1-kaliugov@gmail.com","threadId":"66380","inReplyTo":"xmqqh5je4o45.fsf@gitster.g","subject":"[PATCH v3] doc: remove unnecessary commas in git-add and git-rm documentation","fromName":"Khan Zimov","fromEmail":"kaliugov@gmail.com","sentAt":"2026-09-29T21:02:49Z","receivedAt":"2026-09-29T21:02:55Z","isPatch":true,"body":"Signed-off-by: Khan Zimov <kaliugov@gmail.com>\n---\n Documentation/git-add.adoc | 2 +-\n Documentation/git-rm.adoc  | 2 +-\n 2 files changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/Documentation/git-add.adoc b/Documentation/git-add.adoc\nindex 16b06e38e1..3fc2513a2d 100644\n--- a/Documentation/git-add.adoc\n+++ b/Documentation/git-add.adoc\n@@ -223,7 +223,7 @@ for `git add --no-all <pathspec>...`, i.e. ignored removed files.\n \n `--`::\n \tThis option can be used to separate command-line options from\n-\tthe list of files, (useful when filenames might be mistaken\n+\tthe list of files (useful when filenames might be mistaken\n \tfor command-line options).\n \n \ndiff --git a/Documentation/git-rm.adoc b/Documentation/git-rm.adoc\nindex b5ead86796..67061e961f 100644\n--- a/Documentation/git-rm.adoc\n+++ b/Documentation/git-rm.adoc\n@@ -61,7 +61,7 @@ For more details, see the _<pathspec>_ entry in linkgit:gitglossary[7].\n \n `--`::\n \tThis option can be used to separate command-line options from\n-\tthe list of files, (useful when filenames might be mistaken\n+\tthe list of files (useful when filenames might be mistaken\n \tfor command-line options).\n \n `--cached`::\n-- \n2.52.0.windows.1\n\n"},{"id":"553645","messageId":"20260929210618.147-1-kaliugov@gmail.com","threadId":"66380","inReplyTo":"xmqqh5je4o45.fsf@gitster.g","subject":"[PATCH v4] doc: remove unnecessary commas in git-add and git-rm documentation","fromName":"Khan Zimov","fromEmail":"kaliugov@gmail.com","sentAt":"2026-09-29T21:05:04Z","receivedAt":"2026-09-29T21:06:23Z","isPatch":true,"body":"Signed-off-by: Khan Zimov <kaliugov@gmail.com>\n---\nChanges since v3:\n - Add changes description.\n\nChanges since v2:\n - Use real name in Signed-off-by (sorry, handle before).\n\nChanges since v1:\n - Also fix the same text in git-add.adoc, so that both files\n   stay in sync.\n\n Documentation/git-add.adoc | 2 +-\n Documentation/git-rm.adoc  | 2 +-\n 2 files changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/Documentation/git-add.adoc b/Documentation/git-add.adoc\nindex 16b06e38e1..3fc2513a2d 100644\n--- a/Documentation/git-add.adoc\n+++ b/Documentation/git-add.adoc\n@@ -223,7 +223,7 @@ for `git add --no-all <pathspec>...`, i.e. ignored removed files.\n \n `--`::\n \tThis option can be used to separate command-line options from\n-\tthe list of files, (useful when filenames might be mistaken\n+\tthe list of files (useful when filenames might be mistaken\n \tfor command-line options).\n \n \ndiff --git a/Documentation/git-rm.adoc b/Documentation/git-rm.adoc\nindex b5ead86796..67061e961f 100644\n--- a/Documentation/git-rm.adoc\n+++ b/Documentation/git-rm.adoc\n@@ -61,7 +61,7 @@ For more details, see the _<pathspec>_ entry in linkgit:gitglossary[7].\n \n `--`::\n \tThis option can be used to separate command-line options from\n-\tthe list of files, (useful when filenames might be mistaken\n+\tthe list of files (useful when filenames might be mistaken\n \tfor command-line options).\n \n `--cached`::\n-- \n2.52.0.windows.1\n\n"},{"id":"553838","messageId":"xmqqwls177yo.fsf@gitster.g","threadId":"66380","inReplyTo":"20260929210618.147-1-kaliugov@gmail.com","subject":"Re: [PATCH v4] doc: remove unnecessary commas in git-add and git-rm documentation","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2026-10-01T15:31:59Z","receivedAt":"2026-10-01T15:32:02Z","isPatch":true,"body":"Khan Zimov <kaliugov@gmail.com> writes:\n\n> Signed-off-by: Khan Zimov <kaliugov@gmail.com>\n> ---\n\nThanks.  Both changes look good.  Let me mark the topic for 'next'.\n\n> diff --git a/Documentation/git-add.adoc b/Documentation/git-add.adoc\n> index 16b06e38e1..3fc2513a2d 100644\n> --- a/Documentation/git-add.adoc\n> +++ b/Documentation/git-add.adoc\n> @@ -223,7 +223,7 @@ for `git add --no-all <pathspec>...`, i.e. ignored removed files.\n>  \n>  `--`::\n>  \tThis option can be used to separate command-line options from\n> -\tthe list of files, (useful when filenames might be mistaken\n> +\tthe list of files (useful when filenames might be mistaken\n>  \tfor command-line options).\n>  \n>  \n> diff --git a/Documentation/git-rm.adoc b/Documentation/git-rm.adoc\n> index b5ead86796..67061e961f 100644\n> --- a/Documentation/git-rm.adoc\n> +++ b/Documentation/git-rm.adoc\n> @@ -61,7 +61,7 @@ For more details, see the _<pathspec>_ entry in linkgit:gitglossary[7].\n>  \n>  `--`::\n>  \tThis option can be used to separate command-line options from\n> -\tthe list of files, (useful when filenames might be mistaken\n> +\tthe list of files (useful when filenames might be mistaken\n>  \tfor command-line options).\n>  \n>  `--cached`::\n"}]}