RUST_LIB dependency on LIB_FILE in Makefile

Jan PalusJun 30, 2026, 13:07 UTC on lore

According to Makefile $(RUST_LIB) target depends on $(LIB_FILE):

$(RUST_LIB): Cargo.toml $(RUST_SOURCES) $(LIB_FILE)

but is that really the case? As far as I can tell $(RUST_LIB) does not use $(LIB_FILE) in any way and there's no such dependency in meson.build.

brian m. carlsonJul 1, 2026, 16:28 UTC in reply to Jan Palus on lore

Re: RUST_LIB dependency on LIB_FILE in Makefile

On 2026-06-30 at 13:07:29, Jan Palus wrote:

Show 7 quoted lines

> According to Makefile $(RUST_LIB) target depends on $(LIB_FILE):
> 
> $(RUST_LIB): Cargo.toml $(RUST_SOURCES) $(LIB_FILE)
> 
> but is that really the case? As far as I can tell $(RUST_LIB) does not
> use $(LIB_FILE) in any way and there's no such dependency in
> meson.build.

It is really the case.  The Rust code in `src/hash.rs` requires C
functions in `libgit.a`.  The tests won't run via `cargo test` if it's
not built.  There will be additional uses of this code in the relatively
  near future and they will definitely require calls to `libgit.a`.

The lack of Meson functionality is likely an oversight and I'm sure a patch to fix that would be accepted.

-- 
brian m. carlson (they/them)
Toronto, Ontario, CA