{"thread":{"id":"65896","subject":"RUST_LIB dependency on LIB_FILE in Makefile","startedAt":"2026-06-30T13:07:32Z","lastAt":"2026-07-01T16:28:27Z","messageCount":2,"participants":["Jan Palus","brian m. carlson"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"546778","messageId":"akO9JTUIlHqBrgny@pine.grzadka","threadId":"65896","inReplyTo":null,"subject":"RUST_LIB dependency on LIB_FILE in Makefile","fromName":"Jan Palus","fromEmail":"jpalus@fastmail.com","sentAt":"2026-06-30T13:07:29Z","receivedAt":"2026-06-30T13:07:32Z","isPatch":false,"body":"According to Makefile $(RUST_LIB) target depends on $(LIB_FILE):\n\n$(RUST_LIB): Cargo.toml $(RUST_SOURCES) $(LIB_FILE)\n\nbut is that really the case? As far as I can tell $(RUST_LIB) does not\nuse $(LIB_FILE) in any way and there's no such dependency in\nmeson.build.\n"},{"id":"546912","messageId":"akVAI4dJlC_ZdguT@fruit.crustytoothpaste.net","threadId":"65896","inReplyTo":"akO9JTUIlHqBrgny@pine.grzadka","subject":"Re: RUST_LIB dependency on LIB_FILE in Makefile","fromName":"brian m. carlson","fromEmail":"sandals@crustytoothpaste.net","sentAt":"2026-07-01T16:28:19Z","receivedAt":"2026-07-01T16:28:27Z","isPatch":false,"body":"On 2026-06-30 at 13:07:29, Jan Palus wrote:\n> According to Makefile $(RUST_LIB) target depends on $(LIB_FILE):\n> \n> $(RUST_LIB): Cargo.toml $(RUST_SOURCES) $(LIB_FILE)\n> \n> but is that really the case? As far as I can tell $(RUST_LIB) does not\n> use $(LIB_FILE) in any way and there's no such dependency in\n> meson.build.\n\nIt is really the case.  The Rust code in `src/hash.rs` requires C\nfunctions in `libgit.a`.  The tests won't run via `cargo test` if it's\nnot built.  There will be additional uses of this code in the relatively\n  near future and they will definitely require calls to `libgit.a`.\n\nThe lack of Meson functionality is likely an oversight and I'm sure a\npatch to fix that would be accepted.\n-- \nbrian m. carlson (they/them)\nToronto, Ontario, CA\n"}]}