threads / patch / 65689

patchtest-lib: fix typo in test summary message

Subject: [PATCH] test-lib: fix typo in test summary message

## tl;dr

2 messages between May 25, 2026 and Jun 1, 2026. Diffs are folded; open one to read it.

replies: 1people: 2as markdown or json

Amogh· May 25, 2026, 05:36 UTC · lore
There's a small typo ("passin", should be "passing") in the
summary/description message for t0000-basic. Even though this isn't a
user-facing string it should improve the developer experience + reduce
confusion when working on the codebase.
---
 t/t0000-basic.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Show changes to t/t0000-basic.sh +1 −1
diff --git a/t/t0000-basic.sh b/t/t0000-basic.sh
index 2b63e1c86c..9f6991a9ab 100755
--- a/t/t0000-basic.sh
+++ b/t/t0000-basic.sh
@@ -141,7 +141,7 @@ test_expect_success 'subtest: a passing TODO test' '
 	EOF
 '
 
-test_expect_success 'subtest: 2 TODO tests, one passin' '
+test_expect_success 'subtest: 2 TODO tests, one passing' '
 	write_and_run_sub_test_lib_test_err partially-passing-todos <<-\EOF &&
 	test_expect_failure "pretend we have a known breakage" "false"
 	test_expect_success "pretend we have a passing test" "true"
-- 
2.39.5 (Apple Git-154)
Patrick Steinhardt· Jun 1, 2026, 08:12 UTC · re: Amogh · lore

Re: [PATCH] test-lib: fix typo in test summary message

On Sun, May 24, 2026 at 10:36:33PM -0700, Amogh wrote:
> There's a small typo ("passin", should be "passing") in the
> summary/description message for t0000-basic. Even though this isn't a
> user-facing string it should improve the developer experience + reduce
> confusion when working on the codebase.

I'd be surprised if this actually causes any confusion, so I feel like the explanation is a bit lofty. But ultimately, one less typo is a good thing, so the change makes sense to me.

Your patch is missing the "Signed-off-by:" trailer though.
Thanks!
Patrick

← back to recent threads