Volume XXII, number 280Wednesday, October 7, 2026Latest message 1 hour ago

The Git List

News and archive of git@vger.kernel.org, since April 2005

patchhistory: fix short help for argument of --update-refs

2 messages between Apr 6, 2026 and Apr 7, 2026, from René Scharfe, Patrick Steinhardt.

Plain Markdown or JSON for tools and agents. Diffs are folded; open one to read it.

René ScharfeApr 6, 2026, 09:31 UTC on lore

"print" is not a valid argument for --update-refs. List both valid alternatives literally in the argh string, consistent with documentation and usage string.

Signed-off-by: René Scharfe <l.s.r@web.de>
---
git history is a new command in the coming release.
 builtin/history.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
Show changes to builtin/history.c +4 −4
diff --git a/builtin/history.c b/builtin/history.c
index 568dc75ee7..9526938085 100644
--- a/builtin/history.c
+++ b/builtin/history.c
@@ -437,8 +437,8 @@ static int cmd_history_reword(int argc,
 	enum ref_action action = REF_ACTION_DEFAULT;
 	int dry_run = 0;
 	struct option options[] = {
-		OPT_CALLBACK_F(0, "update-refs", &action, N_("<action>"),
-			       N_("control which refs should be updated (branches|head)"),
+		OPT_CALLBACK_F(0, "update-refs", &action, "(branches|head)",
+			       N_("control which refs should be updated"),
 			       PARSE_OPT_NONEG, parse_ref_action),
 		OPT_BOOL('n', "dry-run", &dry_run,
 			 N_("perform a dry-run without updating any refs")),
@@ -666,8 +666,8 @@ static int cmd_history_split(int argc,
 	enum ref_action action = REF_ACTION_DEFAULT;
 	int dry_run = 0;
 	struct option options[] = {
-		OPT_CALLBACK_F(0, "update-refs", &action, N_("<refs>"),
-			       N_("control ref update behavior (branches|head|print)"),
+		OPT_CALLBACK_F(0, "update-refs", &action, "(branches|head)",
+			       N_("control ref update behavior"),
 			       PARSE_OPT_NONEG, parse_ref_action),
 		OPT_BOOL('n', "dry-run", &dry_run,
 			 N_("perform a dry-run without updating any refs")),
-- 
2.53.0
Patrick SteinhardtApr 7, 2026, 05:16 UTC in reply to René Scharfe on lore

Re: [PATCH] history: fix short help for argument of --update-refs

On Mon, Apr 06, 2026 at 11:31:21AM +0200, René Scharfe wrote:
> "print" is not a valid argument for --update-refs.  List both valid
> alternatives literally in the argh string, consistent with documentation
> and usage string.
This looks good to me, thanks!
Patrick

Back to recent threads