{"thread":{"id":"65443","subject":"[PATCH] history: fix short help for argument of --update-refs","startedAt":"2026-04-06T09:36:43Z","lastAt":"2026-04-07T05:16:08Z","messageCount":2,"participants":["René Scharfe","Patrick Steinhardt"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"540969","messageId":"ff6a940c-39fc-4dbf-a164-7770c7f26a31@web.de","threadId":"65443","inReplyTo":null,"subject":"[PATCH] history: fix short help for argument of --update-refs","fromName":"René Scharfe","fromEmail":"l.s.r@web.de","sentAt":"2026-04-06T09:31:21Z","receivedAt":"2026-04-06T09:36:43Z","isPatch":true,"body":"\"print\" is not a valid argument for --update-refs.  List both valid\nalternatives literally in the argh string, consistent with documentation\nand usage string.\n\nSigned-off-by: René Scharfe <l.s.r@web.de>\n---\ngit history is a new command in the coming release.\n\n builtin/history.c | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)\n\ndiff --git a/builtin/history.c b/builtin/history.c\nindex 568dc75ee7..9526938085 100644\n--- a/builtin/history.c\n+++ b/builtin/history.c\n@@ -437,8 +437,8 @@ static int cmd_history_reword(int argc,\n \tenum ref_action action = REF_ACTION_DEFAULT;\n \tint dry_run = 0;\n \tstruct option options[] = {\n-\t\tOPT_CALLBACK_F(0, \"update-refs\", &action, N_(\"<action>\"),\n-\t\t\t       N_(\"control which refs should be updated (branches|head)\"),\n+\t\tOPT_CALLBACK_F(0, \"update-refs\", &action, \"(branches|head)\",\n+\t\t\t       N_(\"control which refs should be updated\"),\n \t\t\t       PARSE_OPT_NONEG, parse_ref_action),\n \t\tOPT_BOOL('n', \"dry-run\", &dry_run,\n \t\t\t N_(\"perform a dry-run without updating any refs\")),\n@@ -666,8 +666,8 @@ static int cmd_history_split(int argc,\n \tenum ref_action action = REF_ACTION_DEFAULT;\n \tint dry_run = 0;\n \tstruct option options[] = {\n-\t\tOPT_CALLBACK_F(0, \"update-refs\", &action, N_(\"<refs>\"),\n-\t\t\t       N_(\"control ref update behavior (branches|head|print)\"),\n+\t\tOPT_CALLBACK_F(0, \"update-refs\", &action, \"(branches|head)\",\n+\t\t\t       N_(\"control ref update behavior\"),\n \t\t\t       PARSE_OPT_NONEG, parse_ref_action),\n \t\tOPT_BOOL('n', \"dry-run\", &dry_run,\n \t\t\t N_(\"perform a dry-run without updating any refs\")),\n-- \n2.53.0\n"},{"id":"541038","messageId":"adSTEypmnzKNhgoP@pks.im","threadId":"65443","inReplyTo":"ff6a940c-39fc-4dbf-a164-7770c7f26a31@web.de","subject":"Re: [PATCH] history: fix short help for argument of --update-refs","fromName":"Patrick Steinhardt","fromEmail":"ps@pks.im","sentAt":"2026-04-07T05:16:03Z","receivedAt":"2026-04-07T05:16:08Z","isPatch":true,"body":"On Mon, Apr 06, 2026 at 11:31:21AM +0200, René Scharfe wrote:\n> \"print\" is not a valid argument for --update-refs.  List both valid\n> alternatives literally in the argh string, consistent with documentation\n> and usage string.\n\nThis looks good to me, thanks!\n\nPatrick\n"}]}