threads / patch / 64770

patcht1410: check files and missing paths after reflog rewind

Subject: [PATCH] t1410: check files and missing paths after reflog rewind

## tl;dr

3 messages between Jan 11, 2026 and Jan 11, 2026. Diffs are folded; open one to read it.

replies: 2people: 2as markdown or json

Pushkar Singh· Jan 11, 2026, 14:03 UTC · lore

Replace raw `test -f` and `! test -f` checks in the rewind test with `test_path_is_file` and `test_path_is_missing`. This provides clearer failure diagnostics and keeps the test consistent with the rest of the test suite.

Signed-off-by: Pushkar Singh <pushkarkumarsingh1970@gmail.com>
---
 t/t1410-reflog.sh | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
Show changes to t/t1410-reflog.sh +4 −4
diff --git a/t/t1410-reflog.sh b/t/t1410-reflog.sh
index e30f87a358..ce71f9a30a 100755
--- a/t/t1410-reflog.sh
+++ b/t/t1410-reflog.sh
@@ -130,10 +130,10 @@ test_expect_success 'pass through -- to sub-command' '
 
 test_expect_success rewind '
 	test_tick && git reset --hard HEAD~2 &&
-	test -f C &&
-	test -f A/B/E &&
-	! test -f F &&
-	! test -f A/G &&
+	test_path_is_file C &&
+	test_path_is_file A/B/E &&
+	test_path_is_missing F &&
+	test_path_is_missing A/G &&
 
 	check_have A B C D E F G H I J K L &&
 

-- 
2.43.0
Junio C Hamano· Jan 11, 2026, 18:41 UTC · re: Pushkar Singh · lore

Re: [PATCH] t1410: check files and missing paths after reflog rewind

Pushkar Singh <pushkarkumarsingh1970@gmail.com> writes:
> Subject: [PATCH] t1410: check files and missing paths after reflog rewind

That sounds as if the original did not check these things after "reflog rewind" and this patch is about correcting it, doesn't it?

That is a bit different from what is really happening in this patch.
> Replace raw `test -f` and `! test -f` checks in the rewind test with
> `test_path_is_file` and `test_path_is_missing`. This provides clearer
> failure diagnostics and keeps the test consistent with the rest of
> the test suite.
On the other hand, this describes what the patch does nicely.
Pushkar Singh· Jan 11, 2026, 19:07 UTC · re: Junio C Hamano · lore

[PATCH v2] t1410: use test helpers in reflog rewind test

Replace raw `test -f` and `! test -f` checks in the rewind test with `test_path_is_file` and `test_path_is_missing`. This provides clearer failure diagnostics and keeps the test consistent with the rest of the test suite.

Signed-off-by: Pushkar Singh <pushkarkumarsingh1970@gmail.com>
---
 t/t1410-reflog.sh | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
Show changes to t/t1410-reflog.sh +4 −4
diff --git a/t/t1410-reflog.sh b/t/t1410-reflog.sh
index e30f87a358..ce71f9a30a 100755
--- a/t/t1410-reflog.sh
+++ b/t/t1410-reflog.sh
@@ -130,10 +130,10 @@ test_expect_success 'pass through -- to sub-command' '
 
 test_expect_success rewind '
 	test_tick && git reset --hard HEAD~2 &&
-	test -f C &&
-	test -f A/B/E &&
-	! test -f F &&
-	! test -f A/G &&
+	test_path_is_file C &&
+	test_path_is_file A/B/E &&
+	test_path_is_missing F &&
+	test_path_is_missing A/G &&
 
 	check_have A B C D E F G H I J K L &&
 

-- 
2.43.0

← back to recent threads