{"thread":{"id":"64770","subject":"[PATCH] t1410: check files and missing paths after reflog rewind","startedAt":"2026-01-11T14:04:23Z","lastAt":"2026-01-11T19:15:32Z","messageCount":3,"participants":["Pushkar Singh","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"533524","messageId":"20260111140417.36274-1-pushkarkumarsingh1970@gmail.com","threadId":"64770","inReplyTo":null,"subject":"[PATCH] t1410: check files and missing paths after reflog rewind","fromName":"Pushkar Singh","fromEmail":"pushkarkumarsingh1970@gmail.com","sentAt":"2026-01-11T14:03:27Z","receivedAt":"2026-01-11T14:04:23Z","isPatch":true,"sender":{"key":"pushkarkumarsingh1970@gmail.com","avatar":"https://avatars.githubusercontent.com/u/173247767?v=4"},"body":"Replace raw `test -f` and `! test -f` checks in the rewind test with\n`test_path_is_file` and `test_path_is_missing`. This provides clearer\nfailure diagnostics and keeps the test consistent with the rest of\nthe test suite.\n\nSigned-off-by: Pushkar Singh <pushkarkumarsingh1970@gmail.com>\n---\n t/t1410-reflog.sh | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)\n\ndiff --git a/t/t1410-reflog.sh b/t/t1410-reflog.sh\nindex e30f87a358..ce71f9a30a 100755\n--- a/t/t1410-reflog.sh\n+++ b/t/t1410-reflog.sh\n@@ -130,10 +130,10 @@ test_expect_success 'pass through -- to sub-command' '\n \n test_expect_success rewind '\n \ttest_tick && git reset --hard HEAD~2 &&\n-\ttest -f C &&\n-\ttest -f A/B/E &&\n-\t! test -f F &&\n-\t! test -f A/G &&\n+\ttest_path_is_file C &&\n+\ttest_path_is_file A/B/E &&\n+\ttest_path_is_missing F &&\n+\ttest_path_is_missing A/G &&\n \n \tcheck_have A B C D E F G H I J K L &&\n \n-- \n2.43.0\n\n"},{"id":"533538","messageId":"xmqqh5ssouub.fsf@gitster.g","threadId":"64770","inReplyTo":"20260111140417.36274-1-pushkarkumarsingh1970@gmail.com","subject":"Re: [PATCH] t1410: check files and missing paths after reflog rewind","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2026-01-11T18:41:32Z","receivedAt":"2026-01-11T18:41:35Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Pushkar Singh <pushkarkumarsingh1970@gmail.com> writes:\n\n> Subject: [PATCH] t1410: check files and missing paths after reflog rewind\n\nThat sounds as if the original did not check these things after\n\"reflog rewind\" and this patch is about correcting it, doesn't it?\n\nThat is a bit different from what is really happening in this patch.\n\n> Replace raw `test -f` and `! test -f` checks in the rewind test with\n> `test_path_is_file` and `test_path_is_missing`. This provides clearer\n> failure diagnostics and keeps the test consistent with the rest of\n> the test suite.\n\nOn the other hand, this describes what the patch does nicely.\n\n"},{"id":"533539","messageId":"20260111191525.17087-1-pushkarkumarsingh1970@gmail.com","threadId":"64770","inReplyTo":"xmqqh5ssouub.fsf@gitster.g","subject":"[PATCH v2] t1410: use test helpers in reflog rewind test","fromName":"Pushkar Singh","fromEmail":"pushkarkumarsingh1970@gmail.com","sentAt":"2026-01-11T19:07:52Z","receivedAt":"2026-01-11T19:15:32Z","isPatch":true,"sender":{"key":"pushkarkumarsingh1970@gmail.com","avatar":"https://avatars.githubusercontent.com/u/173247767?v=4"},"body":"Replace raw `test -f` and `! test -f` checks in the rewind test with\n`test_path_is_file` and `test_path_is_missing`. This provides clearer\nfailure diagnostics and keeps the test consistent with the rest of\nthe test suite.\n\nSigned-off-by: Pushkar Singh <pushkarkumarsingh1970@gmail.com>\n---\n t/t1410-reflog.sh | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)\n\ndiff --git a/t/t1410-reflog.sh b/t/t1410-reflog.sh\nindex e30f87a358..ce71f9a30a 100755\n--- a/t/t1410-reflog.sh\n+++ b/t/t1410-reflog.sh\n@@ -130,10 +130,10 @@ test_expect_success 'pass through -- to sub-command' '\n \n test_expect_success rewind '\n \ttest_tick && git reset --hard HEAD~2 &&\n-\ttest -f C &&\n-\ttest -f A/B/E &&\n-\t! test -f F &&\n-\t! test -f A/G &&\n+\ttest_path_is_file C &&\n+\ttest_path_is_file A/B/E &&\n+\ttest_path_is_missing F &&\n+\ttest_path_is_missing A/G &&\n \n \tcheck_have A B C D E F G H I J K L &&\n \n-- \n2.43.0\n\n"}]}