threads / patch / 6467

patchInsert ACTIVESTATE_STRING in Git.pm

Subject: [PATCH] Insert ACTIVESTATE_STRING in Git.pm

## tl;dr

4 messages between Jan 22, 2007 and Jan 22, 2007. Diffs are folded; open one to read it.

replies: 3people: 2as markdown or json

Alex Riesen· Jan 22, 2007, 14:32 UTC · lore

Also add "git" to the pipe parameters, otherwise it does not work at all, as no git commands are usable out of git context.

---

This is not enough to make it work on ActiveState. It's just to
fix obvious TODOs, which should help someone to get it going.
The other problems are:
 - tie refuses to bind a handle class activestate_pipe to a scalar $fh
   (a patch follows)
 - there are some unexplained warnings about uninitialized values
 - cygwin-windows pathname conversion (not fixable at all)

 perl/Git.pm |    7 ++++---
 1 files changed, 4 insertions(+), 3 deletions(-)

Alex Riesen· Jan 22, 2007, 14:43 UTC · re: Alex Riesen · lore

Also add "git" to the pipe parameters, otherwise it does not work at all, as no git commands are usable out of git context.

---

Oh, fine, just what I needed... Forgot to attach the patch!

Show 11 quoted lines

> This is not enough to make it work on ActiveState. It's just to
> fix obvious TODOs, which should help someone to get it going.
> The other problems are:
>  - tie refuses to bind a handle class activestate_pipe to a scalar $fh
>    (a patch follows)
>  - there are some unexplained warnings about uninitialized values
>  - cygwin-windows pathname conversion (not fixable at all)
>
>  perl/Git.pm |    7 ++++---
>  1 files changed, 4 insertions(+), 3 deletions(-)
>

Petr Baudis· Jan 22, 2007, 15:44 UTC · re: Alex Riesen · lore

Re: [PATCH] Insert ACTIVESTATE_STRING in Git.pm

On Mon, Jan 22, 2007 at 03:32:28PM CET, Alex Riesen wrote:

Show 15 quoted lines

> Also add "git" to the pipe parameters, otherwise it does not work at all, as
> no git commands are usable out of git context.
> 
> ---
> 
> This is not enough to make it work on ActiveState. It's just to
> fix obvious TODOs, which should help someone to get it going.
> The other problems are:
> - tie refuses to bind a handle class activestate_pipe to a scalar $fh
>   (a patch follows)
> - there are some unexplained warnings about uninitialized values
> - cygwin-windows pathname conversion (not fixable at all)
> 
> perl/Git.pm |    7 ++++---
> 1 files changed, 4 insertions(+), 3 deletions(-)

Cool.

Acked-by: Petr Baudis <pasky@suse.cz>

Perhaps ACPIPE could use some comment in the code but that's just vain nitpicking.

-- 
				Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
The meaning of Stonehenge in Traflamadorian, when viewed from above, is:
"Replacement part being rushed with all possible speed."
		-- Kurt Vonnegut, Sirens from Titan

Alex Riesen· Jan 22, 2007, 16:07 UTC · re: Petr Baudis · lore

Re: [PATCH] Insert ACTIVESTATE_STRING in Git.pm

On 1/22/07, Petr Baudis <pasky@suse.cz> wrote:

Show 23 quoted lines

> On Mon, Jan 22, 2007 at 03:32:28PM CET, Alex Riesen wrote:
> > Also add "git" to the pipe parameters, otherwise it does not work at all, as
> > no git commands are usable out of git context.
> >
> > ---
> >
> > This is not enough to make it work on ActiveState. It's just to
> > fix obvious TODOs, which should help someone to get it going.
> > The other problems are:
> > - tie refuses to bind a handle class activestate_pipe to a scalar $fh
> >   (a patch follows)
> > - there are some unexplained warnings about uninitialized values
> > - cygwin-windows pathname conversion (not fixable at all)
> >
> > perl/Git.pm |    7 ++++---
> > 1 files changed, 4 insertions(+), 3 deletions(-)
>
> Cool.
>
> Acked-by: Petr Baudis <pasky@suse.cz>
>
> Perhaps ACPIPE could use some comment in the code but that's just vain
> nitpicking.

Will do, with a sign-off this time.