{"thread":{"id":"6467","subject":"[PATCH] Insert ACTIVESTATE_STRING in Git.pm","startedAt":"2007-01-22T14:32:28Z","lastAt":"2007-01-22T16:07:26Z","messageCount":4,"participants":["Alex Riesen","Petr Baudis"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"32292","messageId":"81b0412b0701220632t50ad42c4ucb0ebae140a9706a@mail.gmail.com","threadId":"6467","inReplyTo":null,"subject":"[PATCH] Insert ACTIVESTATE_STRING in Git.pm","fromName":"Alex Riesen","fromEmail":"raa.lkml@gmail.com","sentAt":"2007-01-22T14:32:28Z","receivedAt":"2007-01-22T14:32:28Z","isPatch":true,"sender":{"key":"raa.lkml@gmail.com","avatar":"https://avatars.githubusercontent.com/u/324101?v=4"},"body":"Also add \"git\" to the pipe parameters, otherwise it does not work at all, as\nno git commands are usable out of git context.\n\n---\n\nThis is not enough to make it work on ActiveState. It's just to\nfix obvious TODOs, which should help someone to get it going.\nThe other problems are:\n - tie refuses to bind a handle class activestate_pipe to a scalar $fh\n   (a patch follows)\n - there are some unexplained warnings about uninitialized values\n - cygwin-windows pathname conversion (not fixable at all)\n\n perl/Git.pm |    7 ++++---\n 1 files changed, 4 insertions(+), 3 deletions(-)\n"},{"id":"32295","messageId":"81b0412b0701220643s3d337664jcddfffd35071b08e@mail.gmail.com","threadId":"6467","inReplyTo":"81b0412b0701220632t50ad42c4ucb0ebae140a9706a@mail.gmail.com","subject":"[PATCH] Insert ACTIVESTATE_STRING in Git.pm","fromName":"Alex Riesen","fromEmail":"raa.lkml@gmail.com","sentAt":"2007-01-22T14:43:48Z","receivedAt":"2007-01-22T14:43:48Z","isPatch":true,"sender":{"key":"raa.lkml@gmail.com","avatar":"https://avatars.githubusercontent.com/u/324101?v=4"},"body":"Also add \"git\" to the pipe parameters, otherwise it does not work at all, as\nno git commands are usable out of git context.\n\n---\n\nOh, fine, just what I needed... Forgot to attach the patch!\n\n> This is not enough to make it work on ActiveState. It's just to\n> fix obvious TODOs, which should help someone to get it going.\n> The other problems are:\n>  - tie refuses to bind a handle class activestate_pipe to a scalar $fh\n>    (a patch follows)\n>  - there are some unexplained warnings about uninitialized values\n>  - cygwin-windows pathname conversion (not fixable at all)\n>\n>  perl/Git.pm |    7 ++++---\n>  1 files changed, 4 insertions(+), 3 deletions(-)\n>\n"},{"id":"32301","messageId":"20070122154429.GG18276@pasky.or.cz","threadId":"6467","inReplyTo":"81b0412b0701220632t50ad42c4ucb0ebae140a9706a@mail.gmail.com","subject":"Re: [PATCH] Insert ACTIVESTATE_STRING in Git.pm","fromName":"Petr Baudis","fromEmail":"pasky@suse.cz","sentAt":"2007-01-22T15:44:29Z","receivedAt":"2007-01-22T15:44:29Z","isPatch":true,"sender":{"key":"pasky@ucw.cz","avatar":"https://avatars.githubusercontent.com/u/18439?v=4"},"body":"On Mon, Jan 22, 2007 at 03:32:28PM CET, Alex Riesen wrote:\n> Also add \"git\" to the pipe parameters, otherwise it does not work at all, as\n> no git commands are usable out of git context.\n> \n> ---\n> \n> This is not enough to make it work on ActiveState. It's just to\n> fix obvious TODOs, which should help someone to get it going.\n> The other problems are:\n> - tie refuses to bind a handle class activestate_pipe to a scalar $fh\n>   (a patch follows)\n> - there are some unexplained warnings about uninitialized values\n> - cygwin-windows pathname conversion (not fixable at all)\n> \n> perl/Git.pm |    7 ++++---\n> 1 files changed, 4 insertions(+), 3 deletions(-)\n\nCool.\n\nAcked-by: Petr Baudis <pasky@suse.cz>\n\nPerhaps ACPIPE could use some comment in the code but that's just vain\nnitpicking.\n\n-- \n\t\t\t\tPetr \"Pasky\" Baudis\nStuff: http://pasky.or.cz/\nThe meaning of Stonehenge in Traflamadorian, when viewed from above, is:\n\"Replacement part being rushed with all possible speed.\"\n\t\t-- Kurt Vonnegut, Sirens from Titan\n"},{"id":"32303","messageId":"81b0412b0701220807x284bcbfeo7e67599424451587@mail.gmail.com","threadId":"6467","inReplyTo":"20070122154429.GG18276@pasky.or.cz","subject":"Re: [PATCH] Insert ACTIVESTATE_STRING in Git.pm","fromName":"Alex Riesen","fromEmail":"raa.lkml@gmail.com","sentAt":"2007-01-22T16:07:26Z","receivedAt":"2007-01-22T16:07:26Z","isPatch":true,"sender":{"key":"raa.lkml@gmail.com","avatar":"https://avatars.githubusercontent.com/u/324101?v=4"},"body":"On 1/22/07, Petr Baudis <pasky@suse.cz> wrote:\n> On Mon, Jan 22, 2007 at 03:32:28PM CET, Alex Riesen wrote:\n> > Also add \"git\" to the pipe parameters, otherwise it does not work at all, as\n> > no git commands are usable out of git context.\n> >\n> > ---\n> >\n> > This is not enough to make it work on ActiveState. It's just to\n> > fix obvious TODOs, which should help someone to get it going.\n> > The other problems are:\n> > - tie refuses to bind a handle class activestate_pipe to a scalar $fh\n> >   (a patch follows)\n> > - there are some unexplained warnings about uninitialized values\n> > - cygwin-windows pathname conversion (not fixable at all)\n> >\n> > perl/Git.pm |    7 ++++---\n> > 1 files changed, 4 insertions(+), 3 deletions(-)\n>\n> Cool.\n>\n> Acked-by: Petr Baudis <pasky@suse.cz>\n>\n> Perhaps ACPIPE could use some comment in the code but that's just vain\n> nitpicking.\n\nWill do, with a sign-off this time.\n"}]}