threads / patch / 64649

patchtest_detect_ref_format: fix comment

Subject: [PATCH] test_detect_ref_format: fix comment

## tl;dr

2 messages between Dec 18, 2025 and Dec 19, 2025. Diffs are folded; open one to read it.

replies: 1people: 2as markdown or json

Johannes Schindelin via GitGitGadget· Dec 18, 2025, 15:20 UTC · lore
From: Johannes Schindelin <johannes.schindelin@gmx.de>

When 58aaf59133b (t: introduce GIT_TEST_DEFAULT_REF_FORMAT envvar, 2023-12-29) copy-edited the `test_detect_hash` function, the code comment was accidentally left unchanged. Let's adjust it.

Noticed-by: Matthew John Cheetham <mjcheetham@outlook.com>
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
---
    test_detect_ref_format: fix comment
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-2019%2Fdscho%2Ffix-detect-ref-format-comment-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-2019/dscho/fix-detect-ref-format-comment-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/2019
 t/test-lib-functions.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Show changes to t/test-lib-functions.sh +1 −1
diff --git a/t/test-lib-functions.sh b/t/test-lib-functions.sh
index 52d7759bf5..14e238d24d 100644
--- a/t/test-lib-functions.sh
+++ b/t/test-lib-functions.sh
@@ -1724,7 +1724,7 @@ test_detect_hash () {
 	esac
 }
 
-# Detect the hash algorithm in use.
+# Detect the ref format in use.
 test_detect_ref_format () {
 	echo "${GIT_TEST_DEFAULT_REF_FORMAT:-files}"
 }

base-commit: c4a0c8845e2426375ad257b6c221a3a7d92ecfda
-- 
gitgitgadget
Patrick Steinhardt· Dec 19, 2025, 06:43 UTC · re: Johannes Schindelin via GitGitGadget · lore

Re: [PATCH] test_detect_ref_format: fix comment

On Thu, Dec 18, 2025 at 03:20:59PM +0000, Johannes Schindelin via GitGitGadget wrote:
Show 13 quoted lines
> diff --git a/t/test-lib-functions.sh b/t/test-lib-functions.sh
> index 52d7759bf5..14e238d24d 100644
> --- a/t/test-lib-functions.sh
> +++ b/t/test-lib-functions.sh
> @@ -1724,7 +1724,7 @@ test_detect_hash () {
>  	esac
>  }
>  
> -# Detect the hash algorithm in use.
> +# Detect the ref format in use.
>  test_detect_ref_format () {
>  	echo "${GIT_TEST_DEFAULT_REF_FORMAT:-files}"
>  }

An obvious copy-paste error indeed. Thanks for fixing, this looks good to me!

Patrick

← back to recent threads