{"thread":{"id":"64649","subject":"[PATCH] test_detect_ref_format: fix comment","startedAt":"2025-12-18T15:21:02Z","lastAt":"2025-12-19T06:43:38Z","messageCount":2,"participants":["Johannes Schindelin via GitGitGadget","Patrick Steinhardt"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"532472","messageId":"pull.2019.git.1766071259531.gitgitgadget@gmail.com","threadId":"64649","inReplyTo":null,"subject":"[PATCH] test_detect_ref_format: fix comment","fromName":"Johannes Schindelin via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2025-12-18T15:20:59Z","receivedAt":"2025-12-18T15:21:02Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"From: Johannes Schindelin <johannes.schindelin@gmx.de>\n\nWhen 58aaf59133b (t: introduce GIT_TEST_DEFAULT_REF_FORMAT envvar,\n2023-12-29) copy-edited the `test_detect_hash` function, the code\ncomment was accidentally left unchanged. Let's adjust it.\n\nNoticed-by: Matthew John Cheetham <mjcheetham@outlook.com>\nSigned-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>\n---\n    test_detect_ref_format: fix comment\n\nPublished-As: https://github.com/gitgitgadget/git/releases/tag/pr-2019%2Fdscho%2Ffix-detect-ref-format-comment-v1\nFetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-2019/dscho/fix-detect-ref-format-comment-v1\nPull-Request: https://github.com/gitgitgadget/git/pull/2019\n\n t/test-lib-functions.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/t/test-lib-functions.sh b/t/test-lib-functions.sh\nindex 52d7759bf5..14e238d24d 100644\n--- a/t/test-lib-functions.sh\n+++ b/t/test-lib-functions.sh\n@@ -1724,7 +1724,7 @@ test_detect_hash () {\n \tesac\n }\n \n-# Detect the hash algorithm in use.\n+# Detect the ref format in use.\n test_detect_ref_format () {\n \techo \"${GIT_TEST_DEFAULT_REF_FORMAT:-files}\"\n }\n\nbase-commit: c4a0c8845e2426375ad257b6c221a3a7d92ecfda\n-- \ngitgitgadget\n"},{"id":"532519","messageId":"aUT0FKKNTACtY1gF@pks.im","threadId":"64649","inReplyTo":"pull.2019.git.1766071259531.gitgitgadget@gmail.com","subject":"Re: [PATCH] test_detect_ref_format: fix comment","fromName":"Patrick Steinhardt","fromEmail":"ps@pks.im","sentAt":"2025-12-19T06:43:32Z","receivedAt":"2025-12-19T06:43:38Z","isPatch":true,"sender":{"key":"ps@pks.im","avatar":"https://avatars.githubusercontent.com/u/4056630?v=4"},"body":"On Thu, Dec 18, 2025 at 03:20:59PM +0000, Johannes Schindelin via GitGitGadget wrote:\n> diff --git a/t/test-lib-functions.sh b/t/test-lib-functions.sh\n> index 52d7759bf5..14e238d24d 100644\n> --- a/t/test-lib-functions.sh\n> +++ b/t/test-lib-functions.sh\n> @@ -1724,7 +1724,7 @@ test_detect_hash () {\n>  \tesac\n>  }\n>  \n> -# Detect the hash algorithm in use.\n> +# Detect the ref format in use.\n>  test_detect_ref_format () {\n>  \techo \"${GIT_TEST_DEFAULT_REF_FORMAT:-files}\"\n>  }\n\nAn obvious copy-paste error indeed. Thanks for fixing, this looks good\nto me!\n\nPatrick\n"}]}