threads / patch / 64640

patchdocs: note the type of core.attributesfile

Subject: [PATCH] docs: note the type of core.attributesfile

## tl;dr

4 messages between Dec 17, 2025 and Dec 18, 2025. Diffs are folded; open one to read it.

replies: 3people: 2as markdown or json

Matthew Hughes· Dec 17, 2025, 19:51 UTC · lore
The previous wording:
> Path expansions are made the same way as for `core.excludesFile`.

required one to check the docs for 'core.excludesFile' and from there the definition of the pathname variable type to understand the path expansion behaviour of this variable. Instead, just link directly to the pathname type.

This change is basically the same rewording as was done to
'core.excludesFile' in dca83abde2 (config: describe 'pathname' value
type).
---
 Documentation/config/core.adoc | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)
Show changes to Documentation/config/core.adoc +3 −4
diff --git a/Documentation/config/core.adoc b/Documentation/config/core.adoc
index 01202da7cd..9bc9de29d9 100644
--- a/Documentation/config/core.adoc
+++ b/Documentation/config/core.adoc
@@ -492,10 +492,9 @@ core.askPass::
 	command-line argument and write the password on its STDOUT.
 
 core.attributesFile::
-	In addition to `.gitattributes` (per-directory) and
-	`.git/info/attributes`, Git looks into this file for attributes
-	(see linkgit:gitattributes[5]). Path expansions are made the same
-	way as for `core.excludesFile`. Its default value is
+	Specifies the pathname to the file that contains attributes (see
+	linkgit:gitattributes[5]), in addition to `.gitattributes` (per-directory)
+	and `.git/info/attributes`. Its default value is
 	`$XDG_CONFIG_HOME/git/attributes`. If `$XDG_CONFIG_HOME` is either not
 	set or empty, `$HOME/.config/git/attributes` is used instead.
 

-- 
2.52.0
Matthew Hughes· Dec 17, 2025, 19:53 UTC · re: Matthew Hughes · lore

Re: [PATCH] docs: note the type of core.attributesfile

On Wed, Dec 17, 2025 at 07:51:10PM +0000, Matthew Hughes wrote:
> ---
>  Documentation/config/core.adoc | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
I forgot (again!) to signoff the commit, I'll do that and reroll this patch
Matthew Hughes· Dec 17, 2025, 19:59 UTC · re: Matthew Hughes · lore

[PATCH v2] docs: note the type of core.attributesfile

The previous wording:
> Path expansions are made the same way as for `core.excludesFile`.

required one to check the docs for 'core.excludesFile' and from there the definition of the pathname variable type to understand the path expansion behaviour of this variable. Instead, just link directly to the pathname type.

This change is basically the same rewording as was done to 'core.excludesFile' in dca83abde2 (config: describe 'pathname' value type).

Signed-off-by: Matthew Hughes <matthewhughes934@gmail.com>
---
 Documentation/config/core.adoc | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)
Show changes to Documentation/config/core.adoc +3 −4
diff --git a/Documentation/config/core.adoc b/Documentation/config/core.adoc
index 01202da7cd..9bc9de29d9 100644
--- a/Documentation/config/core.adoc
+++ b/Documentation/config/core.adoc
@@ -492,10 +492,9 @@ core.askPass::
 	command-line argument and write the password on its STDOUT.
 
 core.attributesFile::
-	In addition to `.gitattributes` (per-directory) and
-	`.git/info/attributes`, Git looks into this file for attributes
-	(see linkgit:gitattributes[5]). Path expansions are made the same
-	way as for `core.excludesFile`. Its default value is
+	Specifies the pathname to the file that contains attributes (see
+	linkgit:gitattributes[5]), in addition to `.gitattributes` (per-directory)
+	and `.git/info/attributes`. Its default value is
 	`$XDG_CONFIG_HOME/git/attributes`. If `$XDG_CONFIG_HOME` is either not
 	set or empty, `$HOME/.config/git/attributes` is used instead.
 

-- 
2.52.0
Junio C Hamano· Dec 18, 2025, 00:15 UTC · re: Matthew Hughes · lore

Re: [PATCH v2] docs: note the type of core.attributesfile

Matthew Hughes <matthewhughes934@gmail.com> writes:
> This change is basically the same rewording as was done to
> 'core.excludesFile' in dca83abde2 (config: describe 'pathname' value
> type).

Indeed, when we look at Documentation/config.txt in the commit immediately before that one, the description for core.excludesFile and core.attributesFile starts quite similarly. The old commit dca83abd (config: describe 'pathname' value type, 2016-04-29) should have done this already back then when it touched core.excludesFile.

Will queue.  Thanks.
Show 22 quoted lines
> Signed-off-by: Matthew Hughes <matthewhughes934@gmail.com>
> ---
>  Documentation/config/core.adoc | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/config/core.adoc b/Documentation/config/core.adoc
> index 01202da7cd..9bc9de29d9 100644
> --- a/Documentation/config/core.adoc
> +++ b/Documentation/config/core.adoc
> @@ -492,10 +492,9 @@ core.askPass::
>  	command-line argument and write the password on its STDOUT.
>  
>  core.attributesFile::
> -	In addition to `.gitattributes` (per-directory) and
> -	`.git/info/attributes`, Git looks into this file for attributes
> -	(see linkgit:gitattributes[5]). Path expansions are made the same
> -	way as for `core.excludesFile`. Its default value is
> +	Specifies the pathname to the file that contains attributes (see
> +	linkgit:gitattributes[5]), in addition to `.gitattributes` (per-directory)
> +	and `.git/info/attributes`. Its default value is
>  	`$XDG_CONFIG_HOME/git/attributes`. If `$XDG_CONFIG_HOME` is either not
>  	set or empty, `$HOME/.config/git/attributes` is used instead.

← back to recent threads