{"thread":{"id":"64640","subject":"[PATCH] docs: note the type of core.attributesfile","startedAt":"2025-12-17T19:51:14Z","lastAt":"2025-12-18T00:15:17Z","messageCount":4,"participants":["Matthew Hughes","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"532383","messageId":"20251217195050.24837-1-matthewhughes934@gmail.com","threadId":"64640","inReplyTo":null,"subject":"[PATCH] docs: note the type of core.attributesfile","fromName":"Matthew Hughes","fromEmail":"matthewhughes934@gmail.com","sentAt":"2025-12-17T19:51:10Z","receivedAt":"2025-12-17T19:51:14Z","isPatch":true,"sender":{"key":"matthewhughes934@gmail.com","avatar":"https://avatars.githubusercontent.com/u/34972397?v=4"},"body":"The previous wording:\n\n> Path expansions are made the same way as for `core.excludesFile`.\n\nrequired one to check the docs for 'core.excludesFile' and from there\nthe definition of the pathname variable type to understand the path\nexpansion behaviour of this variable. Instead, just link directly to the\npathname type.\n\nThis change is basically the same rewording as was done to\n'core.excludesFile' in dca83abde2 (config: describe 'pathname' value\ntype).\n---\n Documentation/config/core.adoc | 7 +++----\n 1 file changed, 3 insertions(+), 4 deletions(-)\n\ndiff --git a/Documentation/config/core.adoc b/Documentation/config/core.adoc\nindex 01202da7cd..9bc9de29d9 100644\n--- a/Documentation/config/core.adoc\n+++ b/Documentation/config/core.adoc\n@@ -492,10 +492,9 @@ core.askPass::\n \tcommand-line argument and write the password on its STDOUT.\n \n core.attributesFile::\n-\tIn addition to `.gitattributes` (per-directory) and\n-\t`.git/info/attributes`, Git looks into this file for attributes\n-\t(see linkgit:gitattributes[5]). Path expansions are made the same\n-\tway as for `core.excludesFile`. Its default value is\n+\tSpecifies the pathname to the file that contains attributes (see\n+\tlinkgit:gitattributes[5]), in addition to `.gitattributes` (per-directory)\n+\tand `.git/info/attributes`. Its default value is\n \t`$XDG_CONFIG_HOME/git/attributes`. If `$XDG_CONFIG_HOME` is either not\n \tset or empty, `$HOME/.config/git/attributes` is used instead.\n \n-- \n2.52.0\n\n"},{"id":"532384","messageId":"k47im7xsyy22gfbkyl733l6h5hsamiix2jibc2thcw2wiz3wn2@5oig4uhbmmuk","threadId":"64640","inReplyTo":"20251217195050.24837-1-matthewhughes934@gmail.com","subject":"Re: [PATCH] docs: note the type of core.attributesfile","fromName":"Matthew Hughes","fromEmail":"matthewhughes934@gmail.com","sentAt":"2025-12-17T19:53:54Z","receivedAt":"2025-12-17T19:53:58Z","isPatch":true,"sender":{"key":"matthewhughes934@gmail.com","avatar":"https://avatars.githubusercontent.com/u/34972397?v=4"},"body":"On Wed, Dec 17, 2025 at 07:51:10PM +0000, Matthew Hughes wrote:\n> ---\n> Documentation/config/core.adoc | 7 +++----\n> 1 file changed, 3 insertions(+), 4 deletions(-)\n\nI forgot (again!) to signoff the commit, I'll do that and reroll this patch\n"},{"id":"532385","messageId":"20251217195917.25710-1-matthewhughes934@gmail.com","threadId":"64640","inReplyTo":"20251217195050.24837-1-matthewhughes934@gmail.com","subject":"[PATCH v2] docs: note the type of core.attributesfile","fromName":"Matthew Hughes","fromEmail":"matthewhughes934@gmail.com","sentAt":"2025-12-17T19:59:55Z","receivedAt":"2025-12-17T19:59:59Z","isPatch":true,"sender":{"key":"matthewhughes934@gmail.com","avatar":"https://avatars.githubusercontent.com/u/34972397?v=4"},"body":"The previous wording:\n\n> Path expansions are made the same way as for `core.excludesFile`.\n\nrequired one to check the docs for 'core.excludesFile' and from there\nthe definition of the pathname variable type to understand the path\nexpansion behaviour of this variable. Instead, just link directly to the\npathname type.\n\nThis change is basically the same rewording as was done to\n'core.excludesFile' in dca83abde2 (config: describe 'pathname' value\ntype).\n\nSigned-off-by: Matthew Hughes \n---\n Documentation/config/core.adoc | 7 +++----\n 1 file changed, 3 insertions(+), 4 deletions(-)\n\ndiff --git a/Documentation/config/core.adoc b/Documentation/config/core.adoc\nindex 01202da7cd..9bc9de29d9 100644\n--- a/Documentation/config/core.adoc\n+++ b/Documentation/config/core.adoc\n@@ -492,10 +492,9 @@ core.askPass::\n \tcommand-line argument and write the password on its STDOUT.\n \n core.attributesFile::\n-\tIn addition to `.gitattributes` (per-directory) and\n-\t`.git/info/attributes`, Git looks into this file for attributes\n-\t(see linkgit:gitattributes[5]). Path expansions are made the same\n-\tway as for `core.excludesFile`. Its default value is\n+\tSpecifies the pathname to the file that contains attributes (see\n+\tlinkgit:gitattributes[5]), in addition to `.gitattributes` (per-directory)\n+\tand `.git/info/attributes`. Its default value is\n \t`$XDG_CONFIG_HOME/git/attributes`. If `$XDG_CONFIG_HOME` is either not\n \tset or empty, `$HOME/.config/git/attributes` is used instead.\n \n-- \n2.52.0\n\n"},{"id":"532394","messageId":"xmqqldj0zlv1.fsf@gitster.g","threadId":"64640","inReplyTo":"20251217195917.25710-1-matthewhughes934@gmail.com","subject":"Re: [PATCH v2] docs: note the type of core.attributesfile","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2025-12-18T00:15:14Z","receivedAt":"2025-12-18T00:15:17Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Matthew Hughes writes:\n\n> This change is basically the same rewording as was done to\n> 'core.excludesFile' in dca83abde2 (config: describe 'pathname' value\n> type).\n\nIndeed, when we look at Documentation/config.txt in the commit\nimmediately before that one, the description for core.excludesFile\nand core.attributesFile starts quite similarly. The old commit \ndca83abd (config: describe 'pathname' value type, 2016-04-29) should\nhave done this already back then when it touched core.excludesFile.\n\nWill queue. Thanks.\n\n\n> Signed-off-by: Matthew Hughes \n> ---\n> Documentation/config/core.adoc | 7 +++----\n> 1 file changed, 3 insertions(+), 4 deletions(-)\n>\n> diff --git a/Documentation/config/core.adoc b/Documentation/config/core.adoc\n> index 01202da7cd..9bc9de29d9 100644\n> --- a/Documentation/config/core.adoc\n> +++ b/Documentation/config/core.adoc\n> @@ -492,10 +492,9 @@ core.askPass::\n> \tcommand-line argument and write the password on its STDOUT.\n> \n> core.attributesFile::\n> -\tIn addition to `.gitattributes` (per-directory) and\n> -\t`.git/info/attributes`, Git looks into this file for attributes\n> -\t(see linkgit:gitattributes[5]). Path expansions are made the same\n> -\tway as for `core.excludesFile`. Its default value is\n> +\tSpecifies the pathname to the file that contains attributes (see\n> +\tlinkgit:gitattributes[5]), in addition to `.gitattributes` (per-directory)\n> +\tand `.git/info/attributes`. Its default value is\n> \t`$XDG_CONFIG_HOME/git/attributes`. If `$XDG_CONFIG_HOME` is either not\n> \tset or empty, `$HOME/.config/git/attributes` is used instead.\n"}]}