[PATCH] simplify the "no changes added to commit" message

Nicolas Pitre· Jan 14, 2007, 02:23 UTC · lore

Suggesting the use of [-a|-i|-o] with git-commit is unnecessarily complex and confusing. In this context -o is totally useless and -i requires extra arguments which are not mentioned. The only sensible hint (besides reading the man page but let's not go there) is "commit -a".

Signed-off-by: Nicolas Pitre <nico@cam.org> ---

Show changes to wt-status.c +1 −1

diff --git a/wt-status.c b/wt-status.c
index daba9a6..b7250e4 100644
--- a/wt-status.c
+++ b/wt-status.c
@@ -335,7 +335,7 @@ void wt_status_print(struct wt_status *s)
 		if (s->amend)
 			printf("# No changes\n");
 		else if (s->workdir_dirty)
-			printf("no changes added to commit (use \"git add\" and/or \"git commit [-a|-i|-o]\")\n");
+			printf("no changes added to commit (use \"git add\" and/or \"git commit -a\")\n");
 		else if (s->workdir_untracked)
 			printf("nothing added to commit but untracked files present (use \"git add\" to track)\n");
 		else if (s->is_initial)

Juergen Ruehle· Jan 14, 2007, 15:38 UTC · re: Nicolas Pitre · lore

Re: [PATCH] simplify the "no changes added to commit" message

Nicolas Pitre writes:
 > Suggesting the use of [-a|-i|-o] with git-commit is unnecessarily 
 > complex and confusing.  In this context -o is totally useless and -i 
 > requires extra arguments which are not mentioned.  The only sensible 
 > hint (besides reading the man page but let's not go there) is
 > "commit -a".

Well, I would say neither -i or -o were totally useless, though identical in this case (clean index). But I agree it's better to only mention -a.

patchsimplify the "no changes added to commit" message