{"thread":{"id":"6367","subject":"[PATCH] simplify the \"no changes added to commit\" message","startedAt":"2007-01-14T02:23:55Z","lastAt":"2007-01-14T15:38:46Z","messageCount":2,"participants":["Nicolas Pitre","Juergen Ruehle"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"31672","messageId":"Pine.LNX.4.64.0701132111080.2577@xanadu.home","threadId":"6367","inReplyTo":null,"subject":"[PATCH] simplify the \"no changes added to commit\" message","fromName":"Nicolas Pitre","fromEmail":"nico@cam.org","sentAt":"2007-01-14T02:23:55Z","receivedAt":"2007-01-14T02:23:55Z","isPatch":true,"sender":{"key":"nico@fluxnic.net","avatar":"https://avatars.githubusercontent.com/u/702790?v=4"},"body":"Suggesting the use of [-a|-i|-o] with git-commit is unnecessarily \ncomplex and confusing.  In this context -o is totally useless and -i \nrequires extra arguments which are not mentioned.  The only sensible \nhint (besides reading the man page but let's not go there) is\n\"commit -a\".\n\nSigned-off-by: Nicolas Pitre <nico@cam.org> ---\n\ndiff --git a/wt-status.c b/wt-status.c\nindex daba9a6..b7250e4 100644\n--- a/wt-status.c\n+++ b/wt-status.c\n@@ -335,7 +335,7 @@ void wt_status_print(struct wt_status *s)\n \t\tif (s->amend)\n \t\t\tprintf(\"# No changes\\n\");\n \t\telse if (s->workdir_dirty)\n-\t\t\tprintf(\"no changes added to commit (use \\\"git add\\\" and/or \\\"git commit [-a|-i|-o]\\\")\\n\");\n+\t\t\tprintf(\"no changes added to commit (use \\\"git add\\\" and/or \\\"git commit -a\\\")\\n\");\n \t\telse if (s->workdir_untracked)\n \t\t\tprintf(\"nothing added to commit but untracked files present (use \\\"git add\\\" to track)\\n\");\n \t\telse if (s->is_initial)\n"},{"id":"31699","messageId":"17834.20102.334000.595383@lapjr.intranet.kiel.bmiag.de","threadId":"6367","inReplyTo":"Pine.LNX.4.64.0701132111080.2577@xanadu.home","subject":"Re: [PATCH] simplify the \"no changes added to commit\" message","fromName":"Juergen Ruehle","fromEmail":"j.ruehle@bmiag.de","sentAt":"2007-01-14T15:38:46Z","receivedAt":"2007-01-14T15:38:46Z","isPatch":true,"sender":{"key":"j.ruehle@bmiag.de","avatar":null},"body":"Nicolas Pitre writes:\n > Suggesting the use of [-a|-i|-o] with git-commit is unnecessarily \n > complex and confusing.  In this context -o is totally useless and -i \n > requires extra arguments which are not mentioned.  The only sensible \n > hint (besides reading the man page but let's not go there) is\n > \"commit -a\".\n\nWell, I would say neither -i or -o were totally useless, though\nidentical in this case (clean index). But I agree it's better to only\nmention -a.\n"}]}