threads / patch / 63044

patcheditorconfig: add .bash extension

Subject: [PATCH] editorconfig: add .bash extension

## tl;dr

2 messages between Mar 2, 2025 and Mar 3, 2025. Diffs are folded; open one to read it.

replies: 1people: 2as markdown or json

David Mandelberg· Mar 2, 2025, 20:54 UTC · lore

Both files in the command below appear to be indented with tabs, and I'd expect .bash files to have roughly the same style as .sh files.

$ find . -name \*.bash ./contrib/completion/git-completion.bash ./ci/check-directional-formatting.bash

Signed-off-by: David Mandelberg <david@mandelberg.org>
---
 .editorconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Show changes to .editorconfig +1 −1

diff --git a/.editorconfig b/.editorconfig
index a3c578a43c..2d3929b591 100644
--- a/.editorconfig
+++ b/.editorconfig
@@ -4,7 +4,7 @@ insert_final_newline = true
 
 # The settings for C (*.c and *.h) files are mirrored in .clang-format.  Keep
 # them in sync.
-[{*.{c,h,sh,perl,pl,pm,txt,adoc},config.mak.*,Makefile}]
+[{*.{c,h,sh,bash,perl,pl,pm,txt,adoc},config.mak.*,Makefile}]
 indent_style = tab
 tab_width = 8

-- 
2.47.2

Junio C Hamano· Mar 3, 2025, 16:40 UTC · re: David Mandelberg · lore

Re: [PATCH] editorconfig: add .bash extension

David Mandelberg <david@mandelberg.org> writes:

Show 11 quoted lines

> Both files in the command below appear to be indented with tabs, and I'd
> expect .bash files to have roughly the same style as .sh files.
>
> $ find . -name \*.bash
> ./contrib/completion/git-completion.bash
> ./ci/check-directional-formatting.bash
>
> Signed-off-by: David Mandelberg <david@mandelberg.org>
> ---
>  .editorconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

I love these obviously correct additions ;-)

Thanks.

Show 12 quoted lines

> diff --git a/.editorconfig b/.editorconfig
> index a3c578a43c..2d3929b591 100644
> --- a/.editorconfig
> +++ b/.editorconfig
> @@ -4,7 +4,7 @@ insert_final_newline = true
>  
>  # The settings for C (*.c and *.h) files are mirrored in .clang-format.  Keep
>  # them in sync.
> -[{*.{c,h,sh,perl,pl,pm,txt,adoc},config.mak.*,Makefile}]
> +[{*.{c,h,sh,bash,perl,pl,pm,txt,adoc},config.mak.*,Makefile}]
>  indent_style = tab
>  tab_width = 8