{"thread":{"id":"63044","subject":"[PATCH] editorconfig: add .bash extension","startedAt":"2025-03-02T20:54:46Z","lastAt":"2025-03-03T16:40:45Z","messageCount":2,"participants":["David Mandelberg","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"513371","messageId":"15fa4f5d838745b5b05248b44aa16a57@mandelberg.org","threadId":"63044","inReplyTo":null,"subject":"[PATCH] editorconfig: add .bash extension","fromName":"David Mandelberg","fromEmail":"david@mandelberg.org","sentAt":"2025-03-02T20:54:44Z","receivedAt":"2025-03-02T20:54:46Z","isPatch":true,"sender":{"key":"david@mandelberg.org","avatar":"https://avatars.githubusercontent.com/u/15314936?v=4"},"body":"Both files in the command below appear to be indented with tabs, and I'd\nexpect .bash files to have roughly the same style as .sh files.\n\n$ find . -name \\*.bash\n./contrib/completion/git-completion.bash\n./ci/check-directional-formatting.bash\n\nSigned-off-by: David Mandelberg <david@mandelberg.org>\n---\n .editorconfig | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/.editorconfig b/.editorconfig\nindex a3c578a43c..2d3929b591 100644\n--- a/.editorconfig\n+++ b/.editorconfig\n@@ -4,7 +4,7 @@ insert_final_newline = true\n \n # The settings for C (*.c and *.h) files are mirrored in .clang-format.  Keep\n # them in sync.\n-[{*.{c,h,sh,perl,pl,pm,txt,adoc},config.mak.*,Makefile}]\n+[{*.{c,h,sh,bash,perl,pl,pm,txt,adoc},config.mak.*,Makefile}]\n indent_style = tab\n tab_width = 8\n \n-- \n2.47.2\n"},{"id":"513414","messageId":"xmqqtt8avzhx.fsf@gitster.g","threadId":"63044","inReplyTo":"15fa4f5d838745b5b05248b44aa16a57@mandelberg.org","subject":"Re: [PATCH] editorconfig: add .bash extension","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2025-03-03T16:40:42Z","receivedAt":"2025-03-03T16:40:45Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"David Mandelberg <david@mandelberg.org> writes:\n\n> Both files in the command below appear to be indented with tabs, and I'd\n> expect .bash files to have roughly the same style as .sh files.\n>\n> $ find . -name \\*.bash\n> ./contrib/completion/git-completion.bash\n> ./ci/check-directional-formatting.bash\n>\n> Signed-off-by: David Mandelberg <david@mandelberg.org>\n> ---\n>  .editorconfig | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n\nI love these obviously correct additions ;-)\n\nThanks.\n\n> diff --git a/.editorconfig b/.editorconfig\n> index a3c578a43c..2d3929b591 100644\n> --- a/.editorconfig\n> +++ b/.editorconfig\n> @@ -4,7 +4,7 @@ insert_final_newline = true\n>  \n>  # The settings for C (*.c and *.h) files are mirrored in .clang-format.  Keep\n>  # them in sync.\n> -[{*.{c,h,sh,perl,pl,pm,txt,adoc},config.mak.*,Makefile}]\n> +[{*.{c,h,sh,bash,perl,pl,pm,txt,adoc},config.mak.*,Makefile}]\n>  indent_style = tab\n>  tab_width = 8\n"}]}