threads / patch / 62318

patcht/README: add missing value for GIT_TEST_DEFAULT_REF_FORMAT

Subject: [PATCH] t/README: add missing value for GIT_TEST_DEFAULT_REF_FORMAT

## tl;dr

3 messages between Oct 11, 2024 and Oct 12, 2024. Diffs are folded; open one to read it.

replies: 2people: 3as markdown or json

Bence Ferdinandy· Oct 11, 2024, 19:11 UTC · lore

The documentation only lists "files" as a possible value, but "reftable" is also valid.

Signed-off-by: Bence Ferdinandy <bence@ferdinandy.com>
---
 t/README | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

Show changes to t/README +3 −2

diff --git a/t/README b/t/README
index 8dcb778e26..8c0319b58e 100644
--- a/t/README
+++ b/t/README
@@ -465,8 +465,9 @@ GIT_TEST_DEFAULT_HASH=<hash-algo> specifies which hash algorithm to
 use in the test scripts. Recognized values for <hash-algo> are "sha1"
 and "sha256".
 
-GIT_TEST_DEFAULT_REF_FORMAT=<format> specifies which ref storage format
-to use in the test scripts. Recognized values for <format> are "files".
+GIT_TEST_DEFAULT_REF_FORMAT=<format> specifies which ref storage format to use
+in the test scripts. Recognized values for <format> are "files" and
+"reftable".
 
 GIT_TEST_NO_WRITE_REV_INDEX=<boolean>, when true disables the
 'pack.writeReverseIndex' setting.

-- 
2.47.0.6.g93f83f3a03

Junio C Hamano· Oct 11, 2024, 21:18 UTC · re: Bence Ferdinandy · lore

Re: [PATCH] t/README: add missing value for GIT_TEST_DEFAULT_REF_FORMAT

Bence Ferdinandy <bence@ferdinandy.com> writes:

> The documentation only lists "files" as a possible value, but
> "reftable" is also valid.

Makes sense.  Will queue.  Thanks.

Show 22 quoted lines

>
> Signed-off-by: Bence Ferdinandy <bence@ferdinandy.com>
> ---
>  t/README | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/t/README b/t/README
> index 8dcb778e26..8c0319b58e 100644
> --- a/t/README
> +++ b/t/README
> @@ -465,8 +465,9 @@ GIT_TEST_DEFAULT_HASH=<hash-algo> specifies which hash algorithm to
>  use in the test scripts. Recognized values for <hash-algo> are "sha1"
>  and "sha256".
>  
> -GIT_TEST_DEFAULT_REF_FORMAT=<format> specifies which ref storage format
> -to use in the test scripts. Recognized values for <format> are "files".
> +GIT_TEST_DEFAULT_REF_FORMAT=<format> specifies which ref storage format to use
> +in the test scripts. Recognized values for <format> are "files" and
> +"reftable".
>  
>  GIT_TEST_NO_WRITE_REV_INDEX=<boolean>, when true disables the
>  'pack.writeReverseIndex' setting.

Patrick Steinhardt· Oct 12, 2024, 08:32 UTC · re: Junio C Hamano · lore

Re: [PATCH] t/README: add missing value for GIT_TEST_DEFAULT_REF_FORMAT

On Fri, Oct 11, 2024 at 02:18:49PM -0700, Junio C Hamano wrote:

Show 6 quoted lines

> Bence Ferdinandy <bence@ferdinandy.com> writes:
> 
> > The documentation only lists "files" as a possible value, but
> > "reftable" is also valid.
> 
> Makes sense.  Will queue.  Thanks.

Indeed. Thanks for plugging this gap!

Patrick