{"thread":{"id":"62318","subject":"[PATCH] t/README: add missing value for GIT_TEST_DEFAULT_REF_FORMAT","startedAt":"2024-10-11T19:12:27Z","lastAt":"2024-10-12T08:32:13Z","messageCount":3,"participants":["Bence Ferdinandy","Junio C Hamano","Patrick Steinhardt"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"504875","messageId":"20241011191150.825255-1-bence@ferdinandy.com","threadId":"62318","inReplyTo":null,"subject":"[PATCH] t/README: add missing value for GIT_TEST_DEFAULT_REF_FORMAT","fromName":"Bence Ferdinandy","fromEmail":"bence@ferdinandy.com","sentAt":"2024-10-11T19:11:33Z","receivedAt":"2024-10-11T19:12:27Z","isPatch":true,"sender":{"key":"bence@ferdinandy.com","avatar":"https://avatars.githubusercontent.com/u/6343487?v=4"},"body":"The documentation only lists \"files\" as a possible value, but\n\"reftable\" is also valid.\n\nSigned-off-by: Bence Ferdinandy <bence@ferdinandy.com>\n---\n t/README | 5 +++--\n 1 file changed, 3 insertions(+), 2 deletions(-)\n\ndiff --git a/t/README b/t/README\nindex 8dcb778e26..8c0319b58e 100644\n--- a/t/README\n+++ b/t/README\n@@ -465,8 +465,9 @@ GIT_TEST_DEFAULT_HASH=<hash-algo> specifies which hash algorithm to\n use in the test scripts. Recognized values for <hash-algo> are \"sha1\"\n and \"sha256\".\n \n-GIT_TEST_DEFAULT_REF_FORMAT=<format> specifies which ref storage format\n-to use in the test scripts. Recognized values for <format> are \"files\".\n+GIT_TEST_DEFAULT_REF_FORMAT=<format> specifies which ref storage format to use\n+in the test scripts. Recognized values for <format> are \"files\" and\n+\"reftable\".\n \n GIT_TEST_NO_WRITE_REV_INDEX=<boolean>, when true disables the\n 'pack.writeReverseIndex' setting.\n-- \n2.47.0.6.g93f83f3a03\n\n"},{"id":"504882","messageId":"xmqqjzeecp8m.fsf@gitster.g","threadId":"62318","inReplyTo":"20241011191150.825255-1-bence@ferdinandy.com","subject":"Re: [PATCH] t/README: add missing value for GIT_TEST_DEFAULT_REF_FORMAT","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2024-10-11T21:18:49Z","receivedAt":"2024-10-11T21:18:51Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Bence Ferdinandy <bence@ferdinandy.com> writes:\n\n> The documentation only lists \"files\" as a possible value, but\n> \"reftable\" is also valid.\n\nMakes sense.  Will queue.  Thanks.\n\n>\n> Signed-off-by: Bence Ferdinandy <bence@ferdinandy.com>\n> ---\n>  t/README | 5 +++--\n>  1 file changed, 3 insertions(+), 2 deletions(-)\n>\n> diff --git a/t/README b/t/README\n> index 8dcb778e26..8c0319b58e 100644\n> --- a/t/README\n> +++ b/t/README\n> @@ -465,8 +465,9 @@ GIT_TEST_DEFAULT_HASH=<hash-algo> specifies which hash algorithm to\n>  use in the test scripts. Recognized values for <hash-algo> are \"sha1\"\n>  and \"sha256\".\n>  \n> -GIT_TEST_DEFAULT_REF_FORMAT=<format> specifies which ref storage format\n> -to use in the test scripts. Recognized values for <format> are \"files\".\n> +GIT_TEST_DEFAULT_REF_FORMAT=<format> specifies which ref storage format to use\n> +in the test scripts. Recognized values for <format> are \"files\" and\n> +\"reftable\".\n>  \n>  GIT_TEST_NO_WRITE_REV_INDEX=<boolean>, when true disables the\n>  'pack.writeReverseIndex' setting.\n"},{"id":"504910","messageId":"Zwo0BYYBt1sU1jqw@pks.im","threadId":"62318","inReplyTo":"xmqqjzeecp8m.fsf@gitster.g","subject":"Re: [PATCH] t/README: add missing value for GIT_TEST_DEFAULT_REF_FORMAT","fromName":"Patrick Steinhardt","fromEmail":"ps@pks.im","sentAt":"2024-10-12T08:32:05Z","receivedAt":"2024-10-12T08:32:13Z","isPatch":true,"sender":{"key":"ps@pks.im","avatar":"https://avatars.githubusercontent.com/u/4056630?v=4"},"body":"On Fri, Oct 11, 2024 at 02:18:49PM -0700, Junio C Hamano wrote:\n> Bence Ferdinandy <bence@ferdinandy.com> writes:\n> \n> > The documentation only lists \"files\" as a possible value, but\n> > \"reftable\" is also valid.\n> \n> Makes sense.  Will queue.  Thanks.\n\nIndeed. Thanks for plugging this gap!\n\nPatrick\n"}]}