threads / patch / 62184

patchbuiltin: fix typos

Subject: [PATCH] builtin: fix typos

## tl;dr

3 messages between Sep 24, 2024 and Sep 24, 2024. Diffs are folded; open one to read it.

replies: 2people: 3as markdown or json

Andrew Kreimer· Sep 24, 2024, 13:09 UTC · lore
Fix typos in comments.
Signed-off-by: Andrew Kreimer <algonell@gmail.com>
---
 builtin/help.c         | 2 +-
 builtin/ls-files.c     | 2 +-
 builtin/name-rev.c     | 2 +-
 builtin/receive-pack.c | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)
Show changes to 4 files +4 −4

builtin/help.c, builtin/ls-files.c, builtin/name-rev.c, builtin/receive-pack.c

diff --git a/builtin/help.c b/builtin/help.c
index 9c4cfe11d9..a509241a80 100644
--- a/builtin/help.c
+++ b/builtin/help.c
@@ -542,7 +542,7 @@ static void open_html(const char *path)
 
 static void show_html_page(const char *page)
 {
-	struct strbuf page_path; /* it leaks but we exec bellow */
+	struct strbuf page_path; /* it leaks but we exec below */
 
 	get_html_page_path(&page_path, page);
 
diff --git a/builtin/ls-files.c b/builtin/ls-files.c
index 6aaba08e30..e016b0415d 100644
--- a/builtin/ls-files.c
+++ b/builtin/ls-files.c
@@ -507,7 +507,7 @@ static int get_common_prefix_len(const char *common_prefix)
 	common_prefix_len = strlen(common_prefix);
 
 	/*
-	 * If the prefix has a trailing slash, strip it so that submodules wont
+	 * If the prefix has a trailing slash, strip it so that submodules won't
 	 * be pruned from the index.
 	 */
 	if (common_prefix[common_prefix_len - 1] == '/')
diff --git a/builtin/name-rev.c b/builtin/name-rev.c
index 7f08c38629..765eb20a93 100644
--- a/builtin/name-rev.c
+++ b/builtin/name-rev.c
@@ -65,7 +65,7 @@ static void set_commit_cutoff(struct commit *commit)
 static void adjust_cutoff_timestamp_for_slop(void)
 {
 	if (cutoff) {
-		/* check for undeflow */
+		/* check for underflow */
 		if (cutoff > TIME_MIN + CUTOFF_DATE_SLOP)
 			cutoff = cutoff - CUTOFF_DATE_SLOP;
 		else
diff --git a/builtin/receive-pack.c b/builtin/receive-pack.c
index c4b766c613..5bbbebbd8b 100644
--- a/builtin/receive-pack.c
+++ b/builtin/receive-pack.c
@@ -1325,7 +1325,7 @@ static int update_shallow_ref(struct command *cmd, struct shallow_info *si)
 }
 
 /*
- * NEEDSWORK: we should consolidate various implementions of "are we
+ * NEEDSWORK: we should consolidate various implementations of "are we
  * on an unborn branch?" test into one, and make the unified one more
  * robust. !get_sha1() based check used here and elsewhere would not
  * allow us to tell an unborn branch from corrupt ref, for example.
-- 
2.39.5
Eric Sunshine· Sep 24, 2024, 16:35 UTC · re: Andrew Kreimer · lore

Re: [PATCH] builtin: fix typos

On Tue, Sep 24, 2024 at 9:09 AM Andrew Kreimer <algonell@gmail.com> wrote:
Show 9 quoted lines
> Fix typos in comments.
>
> Signed-off-by: Andrew Kreimer <algonell@gmail.com>
> ---
>  builtin/help.c         | 2 +-
>  builtin/ls-files.c     | 2 +-
>  builtin/name-rev.c     | 2 +-
>  builtin/receive-pack.c | 2 +-
>  4 files changed, 4 insertions(+), 4 deletions(-)
All look fine. Thanks.
Junio C Hamano· Sep 24, 2024, 20:23 UTC · re: Eric Sunshine · lore

Re: [PATCH] builtin: fix typos

Eric Sunshine <sunshine@sunshineco.com> writes:
Show 12 quoted lines
> On Tue, Sep 24, 2024 at 9:09 AM Andrew Kreimer <algonell@gmail.com> wrote:
>> Fix typos in comments.
>>
>> Signed-off-by: Andrew Kreimer <algonell@gmail.com>
>> ---
>>  builtin/help.c         | 2 +-
>>  builtin/ls-files.c     | 2 +-
>>  builtin/name-rev.c     | 2 +-
>>  builtin/receive-pack.c | 2 +-
>>  4 files changed, 4 insertions(+), 4 deletions(-)
>
> All look fine. Thanks.
Thanks, both.

← back to recent threads