{"thread":{"id":"62184","subject":"[PATCH] builtin: fix typos","startedAt":"2024-09-24T13:09:13Z","lastAt":"2024-09-24T20:23:39Z","messageCount":3,"participants":["Andrew Kreimer","Eric Sunshine","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"503351","messageId":"20240924130906.21392-1-algonell@gmail.com","threadId":"62184","inReplyTo":null,"subject":"[PATCH] builtin: fix typos","fromName":"Andrew Kreimer","fromEmail":"algonell@gmail.com","sentAt":"2024-09-24T13:09:06Z","receivedAt":"2024-09-24T13:09:13Z","isPatch":true,"sender":{"key":"algonell@gmail.com","avatar":"https://avatars.githubusercontent.com/u/4669001?v=4"},"body":"Fix typos in comments.\n\nSigned-off-by: Andrew Kreimer <algonell@gmail.com>\n---\n builtin/help.c         | 2 +-\n builtin/ls-files.c     | 2 +-\n builtin/name-rev.c     | 2 +-\n builtin/receive-pack.c | 2 +-\n 4 files changed, 4 insertions(+), 4 deletions(-)\n\ndiff --git a/builtin/help.c b/builtin/help.c\nindex 9c4cfe11d9..a509241a80 100644\n--- a/builtin/help.c\n+++ b/builtin/help.c\n@@ -542,7 +542,7 @@ static void open_html(const char *path)\n \n static void show_html_page(const char *page)\n {\n-\tstruct strbuf page_path; /* it leaks but we exec bellow */\n+\tstruct strbuf page_path; /* it leaks but we exec below */\n \n \tget_html_page_path(&page_path, page);\n \ndiff --git a/builtin/ls-files.c b/builtin/ls-files.c\nindex 6aaba08e30..e016b0415d 100644\n--- a/builtin/ls-files.c\n+++ b/builtin/ls-files.c\n@@ -507,7 +507,7 @@ static int get_common_prefix_len(const char *common_prefix)\n \tcommon_prefix_len = strlen(common_prefix);\n \n \t/*\n-\t * If the prefix has a trailing slash, strip it so that submodules wont\n+\t * If the prefix has a trailing slash, strip it so that submodules won't\n \t * be pruned from the index.\n \t */\n \tif (common_prefix[common_prefix_len - 1] == '/')\ndiff --git a/builtin/name-rev.c b/builtin/name-rev.c\nindex 7f08c38629..765eb20a93 100644\n--- a/builtin/name-rev.c\n+++ b/builtin/name-rev.c\n@@ -65,7 +65,7 @@ static void set_commit_cutoff(struct commit *commit)\n static void adjust_cutoff_timestamp_for_slop(void)\n {\n \tif (cutoff) {\n-\t\t/* check for undeflow */\n+\t\t/* check for underflow */\n \t\tif (cutoff > TIME_MIN + CUTOFF_DATE_SLOP)\n \t\t\tcutoff = cutoff - CUTOFF_DATE_SLOP;\n \t\telse\ndiff --git a/builtin/receive-pack.c b/builtin/receive-pack.c\nindex c4b766c613..5bbbebbd8b 100644\n--- a/builtin/receive-pack.c\n+++ b/builtin/receive-pack.c\n@@ -1325,7 +1325,7 @@ static int update_shallow_ref(struct command *cmd, struct shallow_info *si)\n }\n \n /*\n- * NEEDSWORK: we should consolidate various implementions of \"are we\n+ * NEEDSWORK: we should consolidate various implementations of \"are we\n  * on an unborn branch?\" test into one, and make the unified one more\n  * robust. !get_sha1() based check used here and elsewhere would not\n  * allow us to tell an unborn branch from corrupt ref, for example.\n-- \n2.39.5\n\n"},{"id":"503368","messageId":"CAPig+cSSE98QKjSmdQ=HPLiw7Z=BgS6S+EakHyGOAiKFacjB5A@mail.gmail.com","threadId":"62184","inReplyTo":"20240924130906.21392-1-algonell@gmail.com","subject":"Re: [PATCH] builtin: fix typos","fromName":"Eric Sunshine","fromEmail":"sunshine@sunshineco.com","sentAt":"2024-09-24T16:35:24Z","receivedAt":"2024-09-24T16:35:36Z","isPatch":true,"sender":{"key":"sunshine@sunshineco.com","avatar":"https://avatars.githubusercontent.com/u/163641?v=4"},"body":"On Tue, Sep 24, 2024 at 9:09 AM Andrew Kreimer <algonell@gmail.com> wrote:\n> Fix typos in comments.\n>\n> Signed-off-by: Andrew Kreimer <algonell@gmail.com>\n> ---\n>  builtin/help.c         | 2 +-\n>  builtin/ls-files.c     | 2 +-\n>  builtin/name-rev.c     | 2 +-\n>  builtin/receive-pack.c | 2 +-\n>  4 files changed, 4 insertions(+), 4 deletions(-)\n\nAll look fine. Thanks.\n"},{"id":"503393","messageId":"xmqqfrpossvr.fsf@gitster.g","threadId":"62184","inReplyTo":"CAPig+cSSE98QKjSmdQ=HPLiw7Z=BgS6S+EakHyGOAiKFacjB5A@mail.gmail.com","subject":"Re: [PATCH] builtin: fix typos","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2024-09-24T20:23:36Z","receivedAt":"2024-09-24T20:23:39Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Eric Sunshine <sunshine@sunshineco.com> writes:\n\n> On Tue, Sep 24, 2024 at 9:09 AM Andrew Kreimer <algonell@gmail.com> wrote:\n>> Fix typos in comments.\n>>\n>> Signed-off-by: Andrew Kreimer <algonell@gmail.com>\n>> ---\n>>  builtin/help.c         | 2 +-\n>>  builtin/ls-files.c     | 2 +-\n>>  builtin/name-rev.c     | 2 +-\n>>  builtin/receive-pack.c | 2 +-\n>>  4 files changed, 4 insertions(+), 4 deletions(-)\n>\n> All look fine. Thanks.\n\nThanks, both.\n"}]}