threads / patch / 61671

patchfuzz: minimum fuzzers environment lacks libcURL

Subject: [PATCH] fuzz: minimum fuzzers environment lacks libcURL

## tl;dr

One message between Jun 22, 2024 and Jun 22, 2024. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Junio C Hamano· Jun 22, 2024, 05:08 UTC · lore

The "fuzz smoke test" job compiles various .o files to create libgit.a and others, but the final build product of the fuzzer build is *not* "git". Since the job is not interested in building a working "git", it does not define any build flags, and among the notable ones that are missing is NO_CURL---even though the CI environment that runs the job does not have libcURL development package installed.

This obviously leads to a build failure.

Pass NO_CURL=NoThanks to "make" to make sure things will build correctly, if we add any conditional compilation with "#ifdef NO_CURL ... #endif" in the codebase.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
 ci/run-build-and-minimal-fuzzers.sh | 1 +
 1 file changed, 1 insertion(+)
Show changes to ci/run-build-and-minimal-fuzzers.sh +1 −0
diff --git a/ci/run-build-and-minimal-fuzzers.sh b/ci/run-build-and-minimal-fuzzers.sh
index a51076d18d..bcf2ed54d2 100755
--- a/ci/run-build-and-minimal-fuzzers.sh
+++ b/ci/run-build-and-minimal-fuzzers.sh
@@ -6,6 +6,7 @@
 . ${0%/*}/lib.sh
 
 group "Build fuzzers" make \
+	NO_CURL=NoThanks \
 	CC=clang \
 	CXX=clang++ \
 	CFLAGS="-fsanitize=fuzzer-no-link,address" \
-- 
2.45.2-789-g52a439864c

← back to recent threads