{"thread":{"id":"61671","subject":"[PATCH] fuzz: minimum fuzzers environment lacks libcURL","startedAt":"2024-06-22T05:08:48Z","lastAt":"2024-06-22T05:08:48Z","messageCount":1,"participants":["Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"497535","messageId":"xmqqwmmhimxx.fsf@gitster.g","threadId":"61671","inReplyTo":null,"subject":"[PATCH] fuzz: minimum fuzzers environment lacks libcURL","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2024-06-22T05:08:42Z","receivedAt":"2024-06-22T05:08:48Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"The \"fuzz smoke test\" job compiles various .o files to create\nlibgit.a and others, but the final build product of the fuzzer build\nis *not* \"git\".  Since the job is not interested in building a\nworking \"git\", it does not define any build flags, and among the\nnotable ones that are missing is NO_CURL---even though the CI\nenvironment that runs the job does not have libcURL development\npackage installed.\n\nThis obviously leads to a build failure.\n\nPass NO_CURL=NoThanks to \"make\" to make sure things will build\ncorrectly, if we add any conditional compilation with \"#ifdef\nNO_CURL ... #endif\" in the codebase.\n\nSigned-off-by: Junio C Hamano <gitster@pobox.com>\n---\n ci/run-build-and-minimal-fuzzers.sh | 1 +\n 1 file changed, 1 insertion(+)\n\ndiff --git a/ci/run-build-and-minimal-fuzzers.sh b/ci/run-build-and-minimal-fuzzers.sh\nindex a51076d18d..bcf2ed54d2 100755\n--- a/ci/run-build-and-minimal-fuzzers.sh\n+++ b/ci/run-build-and-minimal-fuzzers.sh\n@@ -6,6 +6,7 @@\n . ${0%/*}/lib.sh\n \n group \"Build fuzzers\" make \\\n+\tNO_CURL=NoThanks \\\n \tCC=clang \\\n \tCXX=clang++ \\\n \tCFLAGS=\"-fsanitize=fuzzer-no-link,address\" \\\n-- \n2.45.2-789-g52a439864c\n\n"}]}