threads / patch / 61067

patchdoc/gitremote-helpers: fix missing single-quote

Subject: [PATCH] doc/gitremote-helpers: fix missing single-quote

## tl;dr

2 messages between Mar 7, 2024 and Mar 7, 2024. Diffs are folded; open one to read it.

replies: 1people: 2as markdown or json

Jeff King· Mar 7, 2024, 08:43 UTC · lore

The formatting around "option push-option" was missing its closing quote, leading to the output having a stray opening quote, rather than rendering the item in italics (as we do for all of the other options in the list).

Signed-off-by: Jeff King <peff@peff.net>
---
Just happened to notice this while looking at the rendered manpage for a
different option.

 Documentation/gitremote-helpers.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Show changes to Documentation/gitremote-helpers.txt +1 −1

diff --git a/Documentation/gitremote-helpers.txt b/Documentation/gitremote-helpers.txt
index ed8da428c9..07c8439a6f 100644
--- a/Documentation/gitremote-helpers.txt
+++ b/Documentation/gitremote-helpers.txt
@@ -526,7 +526,7 @@ set by Git if the remote helper has the 'option' capability.
 'option pushcert' {'true'|'false'}::
 	GPG sign pushes.
 
-'option push-option <string>::
+'option push-option' <string>::
 	Transmit <string> as a push option. As the push option
 	must not contain LF or NUL characters, the string is not encoded.

-- 
2.44.0.463.g71abcb3a9f

Junio C Hamano· Mar 7, 2024, 20:31 UTC · re: Jeff King · lore

Re: [PATCH] doc/gitremote-helpers: fix missing single-quote

Jeff King <peff@peff.net> writes:

Show 9 quoted lines

> The formatting around "option push-option" was missing its closing
> quote, leading to the output having a stray opening quote, rather than
> rendering the item in italics (as we do for all of the other options in
> the list).
>
> Signed-off-by: Jeff King <peff@peff.net>
> ---
> Just happened to notice this while looking at the rendered manpage for a
> different option.

Thanks. This looks like an ancient typo.  Applied.

Show 16 quoted lines

>
>  Documentation/gitremote-helpers.txt | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/gitremote-helpers.txt b/Documentation/gitremote-helpers.txt
> index ed8da428c9..07c8439a6f 100644
> --- a/Documentation/gitremote-helpers.txt
> +++ b/Documentation/gitremote-helpers.txt
> @@ -526,7 +526,7 @@ set by Git if the remote helper has the 'option' capability.
>  'option pushcert' {'true'|'false'}::
>  	GPG sign pushes.
>  
> -'option push-option <string>::
> +'option push-option' <string>::
>  	Transmit <string> as a push option. As the push option
>  	must not contain LF or NUL characters, the string is not encoded.