{"thread":{"id":"61067","subject":"[PATCH] doc/gitremote-helpers: fix missing single-quote","startedAt":"2024-03-07T08:43:22Z","lastAt":"2024-03-07T20:32:00Z","messageCount":2,"participants":["Jeff King","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"490145","messageId":"20240307084313.GA2072022@coredump.intra.peff.net","threadId":"61067","inReplyTo":null,"subject":"[PATCH] doc/gitremote-helpers: fix missing single-quote","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2024-03-07T08:43:13Z","receivedAt":"2024-03-07T08:43:22Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"The formatting around \"option push-option\" was missing its closing\nquote, leading to the output having a stray opening quote, rather than\nrendering the item in italics (as we do for all of the other options in\nthe list).\n\nSigned-off-by: Jeff King <peff@peff.net>\n---\nJust happened to notice this while looking at the rendered manpage for a\ndifferent option.\n\n Documentation/gitremote-helpers.txt | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/Documentation/gitremote-helpers.txt b/Documentation/gitremote-helpers.txt\nindex ed8da428c9..07c8439a6f 100644\n--- a/Documentation/gitremote-helpers.txt\n+++ b/Documentation/gitremote-helpers.txt\n@@ -526,7 +526,7 @@ set by Git if the remote helper has the 'option' capability.\n 'option pushcert' {'true'|'false'}::\n \tGPG sign pushes.\n \n-'option push-option <string>::\n+'option push-option' <string>::\n \tTransmit <string> as a push option. As the push option\n \tmust not contain LF or NUL characters, the string is not encoded.\n \n-- \n2.44.0.463.g71abcb3a9f\n"},{"id":"490211","messageId":"xmqqo7bplr62.fsf@gitster.g","threadId":"61067","inReplyTo":"20240307084313.GA2072022@coredump.intra.peff.net","subject":"Re: [PATCH] doc/gitremote-helpers: fix missing single-quote","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2024-03-07T20:31:49Z","receivedAt":"2024-03-07T20:32:00Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Jeff King <peff@peff.net> writes:\n\n> The formatting around \"option push-option\" was missing its closing\n> quote, leading to the output having a stray opening quote, rather than\n> rendering the item in italics (as we do for all of the other options in\n> the list).\n>\n> Signed-off-by: Jeff King <peff@peff.net>\n> ---\n> Just happened to notice this while looking at the rendered manpage for a\n> different option.\n\nThanks. This looks like an ancient typo.  Applied.\n\n\n>\n>  Documentation/gitremote-helpers.txt | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/Documentation/gitremote-helpers.txt b/Documentation/gitremote-helpers.txt\n> index ed8da428c9..07c8439a6f 100644\n> --- a/Documentation/gitremote-helpers.txt\n> +++ b/Documentation/gitremote-helpers.txt\n> @@ -526,7 +526,7 @@ set by Git if the remote helper has the 'option' capability.\n>  'option pushcert' {'true'|'false'}::\n>  \tGPG sign pushes.\n>  \n> -'option push-option <string>::\n> +'option push-option' <string>::\n>  \tTransmit <string> as a push option. As the push option\n>  \tmust not contain LF or NUL characters, the string is not encoded.\n"}]}