Re: [PATCH 1/2] GitHub Actions: update to checkout@v4
I am adding non-html e-mail reply to keep track in git@vger.kernel.org:
The switch to checkout@v4 for GitHub Actions looks good to me. I wonder if we should be updating other actions to v4 so they start using Node 20:
In coverity.yml (https://github.com/git/git/blob/8838dd21e8a4ec1324377ffcfa90413844ca3674/.github/workflows/coverity.yml#L101C15-L101C39)
actions/cache/restore@v3 -> v4 (reference: https://github.com/actions/cache/releases/tag/v4.0.0) actions/cache/save@v3 -> v4 (reference: https://github.com/actions/cache/releases/tag/v4.0.0)
In main.yml
actions/upload-artifact@v3 -> v4 (reference: https://github.com/actions/upload-artifact/commit/aa5cae10db2b39d79f5244f6bc5084278993a3ae#diff-1243c5424efaaa19bd8e813c5e6f6da46316e63761421b3e5f5c8ced9a36e6b6R33) actions/download-artifact@v3 -> v4 (reference: https://github.com/actions/download-artifact/commit/88dadfbcfcdd10293192ac8ee1e3ffe61f7055ee#diff-1243c5424efaaa19bd8e813c5e6f6da46316e63761421b3e5f5c8ced9a36e6b6R28)
On Sat, 3 Feb 2024 at 12:31, Óscar Domínguez Celada <dominguez.celada@gmail.com> wrote:
Show 147 quoted lines
>
> The switch to checkout@v4 for GitHub Actions looks good to me. I wonder if we should be updating other actions to v4 so they start using Node 20:
>
> In coverity.yml
>
> actions/cache/restore@v3 -> v4 (reference: https://github.com/actions/cache/releases/tag/v4.0.0)
> actions/cache/save@v3 -> v4 (reference: https://github.com/actions/cache/releases/tag/v4.0.0)
>
> In main.yml
>
> actions/upload-artifact@v3 -> v4 (reference: https://github.com/actions/upload-artifact/commit/aa5cae10db2b39d79f5244f6bc5084278993a3ae#diff-1243c5424efaaa19bd8e813c5e6f6da46316e63761421b3e5f5c8ced9a36e6b6R33)
> actions/download-artifact@v3 -> v4 (reference: https://github.com/actions/download-artifact/commit/88dadfbcfcdd10293192ac8ee1e3ffe61f7055ee#diff-1243c5424efaaa19bd8e813c5e6f6da46316e63761421b3e5f5c8ced9a36e6b6R28)
>
>
> On Fri, 2 Feb 2024 at 21:39, Junio C Hamano <gitster@pobox.com> wrote:
>>
>> We seem to be getting "Node.js 16 actions are deprecated." warnings
>> for jobs that use checkout@v3. Except for the i686 containers job
>> that is kept at checkout@v1 [*], update to checkout@v4, which is
>> said to use Node.js 20.
>>
>> [*] 6cf4d908 (ci(main): upgrade actions/checkout to v3, 2022-12-05)
>> refers to https://github.com/actions/runner/issues/2115 and
>> explains why container jobs are kept at checkout@v1. We may
>> want to check the current status of the issue and move it to the
>> same version as other jobs, but that is outside the scope of
>> this step.
>>
>> Signed-off-by: Junio C Hamano <gitster@pobox.com>
>> ---
>> .github/workflows/check-whitespace.yml | 2 +-
>> .github/workflows/coverity.yml | 2 +-
>> .github/workflows/main.yml | 18 +++++++++---------
>> 3 files changed, 11 insertions(+), 11 deletions(-)
>>
>> diff --git a/.github/workflows/check-whitespace.yml b/.github/workflows/check-whitespace.yml
>> index a58e2dc8ad..a241a63428 100644
>> --- a/.github/workflows/check-whitespace.yml
>> +++ b/.github/workflows/check-whitespace.yml
>> @@ -19,7 +19,7 @@ jobs:
>> check-whitespace:
>> runs-on: ubuntu-latest
>> steps:
>> - - uses: actions/checkout@v3
>> + - uses: actions/checkout@v4
>> with:
>> fetch-depth: 0
>>
>> diff --git a/.github/workflows/coverity.yml b/.github/workflows/coverity.yml
>> index e5532d381b..a81a7566d1 100644
>> --- a/.github/workflows/coverity.yml
>> +++ b/.github/workflows/coverity.yml
>> @@ -38,7 +38,7 @@ jobs:
>> COVERITY_LANGUAGE: cxx
>> COVERITY_PLATFORM: overridden-below
>> steps:
>> - - uses: actions/checkout@v3
>> + - uses: actions/checkout@v4
>> - name: install minimal Git for Windows SDK
>> if: contains(matrix.os, 'windows')
>> uses: git-for-windows/setup-git-for-windows-sdk@v1
>> diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
>> index 4d97da57ec..90973f9693 100644
>> --- a/.github/workflows/main.yml
>> +++ b/.github/workflows/main.yml
>> @@ -112,7 +112,7 @@ jobs:
>> group: windows-build-${{ github.ref }}
>> cancel-in-progress: ${{ needs.ci-config.outputs.skip_concurrent == 'yes' }}
>> steps:
>> - - uses: actions/checkout@v3
>> + - uses: actions/checkout@v4
>> - uses: git-for-windows/setup-git-for-windows-sdk@v1
>> - name: build
>> shell: bash
>> @@ -173,10 +173,10 @@ jobs:
>> group: vs-build-${{ github.ref }}
>> cancel-in-progress: ${{ needs.ci-config.outputs.skip_concurrent == 'yes' }}
>> steps:
>> - - uses: actions/checkout@v3
>> + - uses: actions/checkout@v4
>> - uses: git-for-windows/setup-git-for-windows-sdk@v1
>> - name: initialize vcpkg
>> - uses: actions/checkout@v3
>> + uses: actions/checkout@v4
>> with:
>> repository: 'microsoft/vcpkg'
>> path: 'compat/vcbuild/vcpkg'
>> @@ -297,7 +297,7 @@ jobs:
>> runs_on_pool: ${{matrix.vector.pool}}
>> runs-on: ${{matrix.vector.pool}}
>> steps:
>> - - uses: actions/checkout@v3
>> + - uses: actions/checkout@v4
>> - run: ci/install-dependencies.sh
>> - run: ci/run-build-and-tests.sh
>> - name: print test failures
>> @@ -317,7 +317,7 @@ jobs:
>> CC: clang
>> runs-on: ubuntu-latest
>> steps:
>> - - uses: actions/checkout@v3
>> + - uses: actions/checkout@v4
>> - run: ci/install-dependencies.sh
>> - run: ci/run-build-and-minimal-fuzzers.sh
>> dockerized:
>> @@ -342,7 +342,7 @@ jobs:
>> runs-on: ubuntu-latest
>> container: ${{matrix.vector.image}}
>> steps:
>> - - uses: actions/checkout@v3
>> + - uses: actions/checkout@v4
>> if: matrix.vector.jobname != 'linux32'
>> - uses: actions/checkout@v1
>> if: matrix.vector.jobname == 'linux32'
>> @@ -373,7 +373,7 @@ jobs:
>> group: static-analysis-${{ github.ref }}
>> cancel-in-progress: ${{ needs.ci-config.outputs.skip_concurrent == 'yes' }}
>> steps:
>> - - uses: actions/checkout@v3
>> + - uses: actions/checkout@v4
>> - run: ci/install-dependencies.sh
>> - run: ci/run-static-analysis.sh
>> - run: ci/check-directional-formatting.bash
>> @@ -396,7 +396,7 @@ jobs:
>> artifact: sparse-20.04
>> - name: Install the current `sparse` package
>> run: sudo dpkg -i sparse-20.04/sparse_*.deb
>> - - uses: actions/checkout@v3
>> + - uses: actions/checkout@v4
>> - name: Install other dependencies
>> run: ci/install-dependencies.sh
>> - run: make sparse
>> @@ -411,6 +411,6 @@ jobs:
>> jobname: Documentation
>> runs-on: ubuntu-latest
>> steps:
>> - - uses: actions/checkout@v3
>> + - uses: actions/checkout@v4
>> - run: ci/install-dependencies.sh
>> - run: ci/test-documentation.sh
>> --
>> 2.43.0-522-g2a540e432f
>>
>
>
> --
> Óscar Domínguez Celada--
Óscar Domínguez Celada