{"thread":{"id":"60837","subject":"[PATCH 0/2] GitHub Actions update","startedAt":"2024-02-02T20:39:41Z","lastAt":"2024-02-03T17:19:12Z","messageCount":5,"participants":["Junio C Hamano","Óscar Domínguez Celada"],"isPatch":true,"patchVersion":1,"patchTotal":2},"messages":[{"id":"487845","messageId":"20240202203935.1240458-1-gitster@pobox.com","threadId":"60837","inReplyTo":null,"subject":"[PATCH 0/2] GitHub Actions update","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2024-02-02T20:39:33Z","receivedAt":"2024-02-02T20:39:41Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"The CI jobs are getting \"Node.js 16 actions are deprecated.\"\nwarnings for jobs that use checkout@v3, github-script@v6, and\ndownload-artifact@v3.\n\nThese two patches update these jobs to use checkout@v4 and\ngithub-script@v7, both of which are said to use Node.js 20.\n\ndownload-artifact@v4 exists but it is labeled as \"major changes\"\nwith breaking changes, so I refrained from touching its use to defer\nit to folks who are more experienced with its use.\n\nJunio C Hamano (2):\n  GitHub Actions: update to checkout@v4\n  GitHub Actions: update to github-script@v7\n\n .github/workflows/check-whitespace.yml |  2 +-\n .github/workflows/coverity.yml         |  2 +-\n .github/workflows/main.yml             | 20 ++++++++++----------\n 3 files changed, 12 insertions(+), 12 deletions(-)\n\n-- \n2.43.0-522-g2a540e432f\n\n"},{"id":"487846","messageId":"20240202203935.1240458-2-gitster@pobox.com","threadId":"60837","inReplyTo":"20240202203935.1240458-1-gitster@pobox.com","subject":"[PATCH 1/2] GitHub Actions: update to checkout@v4","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2024-02-02T20:39:34Z","receivedAt":"2024-02-02T20:39:45Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"We seem to be getting \"Node.js 16 actions are deprecated.\" warnings\nfor jobs that use checkout@v3.  Except for the i686 containers job\nthat is kept at checkout@v1 [*], update to checkout@v4, which is\nsaid to use Node.js 20.\n\n[*] 6cf4d908 (ci(main): upgrade actions/checkout to v3, 2022-12-05)\n    refers to https://github.com/actions/runner/issues/2115 and\n    explains why container jobs are kept at checkout@v1.  We may\n    want to check the current status of the issue and move it to the\n    same version as other jobs, but that is outside the scope of\n    this step.\n\nSigned-off-by: Junio C Hamano <gitster@pobox.com>\n---\n .github/workflows/check-whitespace.yml |  2 +-\n .github/workflows/coverity.yml         |  2 +-\n .github/workflows/main.yml             | 18 +++++++++---------\n 3 files changed, 11 insertions(+), 11 deletions(-)\n\ndiff --git a/.github/workflows/check-whitespace.yml b/.github/workflows/check-whitespace.yml\nindex a58e2dc8ad..a241a63428 100644\n--- a/.github/workflows/check-whitespace.yml\n+++ b/.github/workflows/check-whitespace.yml\n@@ -19,7 +19,7 @@ jobs:\n   check-whitespace:\n     runs-on: ubuntu-latest\n     steps:\n-    - uses: actions/checkout@v3\n+    - uses: actions/checkout@v4\n       with:\n         fetch-depth: 0\n \ndiff --git a/.github/workflows/coverity.yml b/.github/workflows/coverity.yml\nindex e5532d381b..a81a7566d1 100644\n--- a/.github/workflows/coverity.yml\n+++ b/.github/workflows/coverity.yml\n@@ -38,7 +38,7 @@ jobs:\n       COVERITY_LANGUAGE: cxx\n       COVERITY_PLATFORM: overridden-below\n     steps:\n-      - uses: actions/checkout@v3\n+      - uses: actions/checkout@v4\n       - name: install minimal Git for Windows SDK\n         if: contains(matrix.os, 'windows')\n         uses: git-for-windows/setup-git-for-windows-sdk@v1\ndiff --git a/.github/workflows/main.yml b/.github/workflows/main.yml\nindex 4d97da57ec..90973f9693 100644\n--- a/.github/workflows/main.yml\n+++ b/.github/workflows/main.yml\n@@ -112,7 +112,7 @@ jobs:\n       group: windows-build-${{ github.ref }}\n       cancel-in-progress: ${{ needs.ci-config.outputs.skip_concurrent == 'yes' }}\n     steps:\n-    - uses: actions/checkout@v3\n+    - uses: actions/checkout@v4\n     - uses: git-for-windows/setup-git-for-windows-sdk@v1\n     - name: build\n       shell: bash\n@@ -173,10 +173,10 @@ jobs:\n       group: vs-build-${{ github.ref }}\n       cancel-in-progress: ${{ needs.ci-config.outputs.skip_concurrent == 'yes' }}\n     steps:\n-    - uses: actions/checkout@v3\n+    - uses: actions/checkout@v4\n     - uses: git-for-windows/setup-git-for-windows-sdk@v1\n     - name: initialize vcpkg\n-      uses: actions/checkout@v3\n+      uses: actions/checkout@v4\n       with:\n         repository: 'microsoft/vcpkg'\n         path: 'compat/vcbuild/vcpkg'\n@@ -297,7 +297,7 @@ jobs:\n       runs_on_pool: ${{matrix.vector.pool}}\n     runs-on: ${{matrix.vector.pool}}\n     steps:\n-    - uses: actions/checkout@v3\n+    - uses: actions/checkout@v4\n     - run: ci/install-dependencies.sh\n     - run: ci/run-build-and-tests.sh\n     - name: print test failures\n@@ -317,7 +317,7 @@ jobs:\n       CC: clang\n     runs-on: ubuntu-latest\n     steps:\n-    - uses: actions/checkout@v3\n+    - uses: actions/checkout@v4\n     - run: ci/install-dependencies.sh\n     - run: ci/run-build-and-minimal-fuzzers.sh\n   dockerized:\n@@ -342,7 +342,7 @@ jobs:\n     runs-on: ubuntu-latest\n     container: ${{matrix.vector.image}}\n     steps:\n-    - uses: actions/checkout@v3\n+    - uses: actions/checkout@v4\n       if: matrix.vector.jobname != 'linux32'\n     - uses: actions/checkout@v1\n       if: matrix.vector.jobname == 'linux32'\n@@ -373,7 +373,7 @@ jobs:\n       group: static-analysis-${{ github.ref }}\n       cancel-in-progress: ${{ needs.ci-config.outputs.skip_concurrent == 'yes' }}\n     steps:\n-    - uses: actions/checkout@v3\n+    - uses: actions/checkout@v4\n     - run: ci/install-dependencies.sh\n     - run: ci/run-static-analysis.sh\n     - run: ci/check-directional-formatting.bash\n@@ -396,7 +396,7 @@ jobs:\n         artifact: sparse-20.04\n     - name: Install the current `sparse` package\n       run: sudo dpkg -i sparse-20.04/sparse_*.deb\n-    - uses: actions/checkout@v3\n+    - uses: actions/checkout@v4\n     - name: Install other dependencies\n       run: ci/install-dependencies.sh\n     - run: make sparse\n@@ -411,6 +411,6 @@ jobs:\n       jobname: Documentation\n     runs-on: ubuntu-latest\n     steps:\n-    - uses: actions/checkout@v3\n+    - uses: actions/checkout@v4\n     - run: ci/install-dependencies.sh\n     - run: ci/test-documentation.sh\n-- \n2.43.0-522-g2a540e432f\n\n"},{"id":"487847","messageId":"20240202203935.1240458-3-gitster@pobox.com","threadId":"60837","inReplyTo":"20240202203935.1240458-1-gitster@pobox.com","subject":"[PATCH 2/2] GitHub Actions: update to github-script@v7","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2024-02-02T20:39:35Z","receivedAt":"2024-02-02T20:39:49Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"We seem to be getting \"Node.js 16 actions are deprecated.\" warnings\nfor jobs that use github-script@v6.  Update to github-script@v7,\nwhich is said to use Node.js 20.\n\nSigned-off-by: Junio C Hamano <gitster@pobox.com>\n---\n .github/workflows/main.yml | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/.github/workflows/main.yml b/.github/workflows/main.yml\nindex 90973f9693..bb857bdaf0 100644\n--- a/.github/workflows/main.yml\n+++ b/.github/workflows/main.yml\n@@ -63,7 +63,7 @@ jobs:\n           echo \"skip_concurrent=$skip_concurrent\" >>$GITHUB_OUTPUT\n       - name: skip if the commit or tree was already tested\n         id: skip-if-redundant\n-        uses: actions/github-script@v6\n+        uses: actions/github-script@v7\n         if: steps.check-ref.outputs.enabled == 'yes'\n         with:\n           github-token: ${{secrets.GITHUB_TOKEN}}\n-- \n2.43.0-522-g2a540e432f\n\n"},{"id":"487867","messageId":"CADCFv=4Gjh5B6RFF3P--FO9T7R+uGg2dyN8hT4VR0yJtJt-UsA@mail.gmail.com","threadId":"60837","inReplyTo":"CADCFv=5=uwp_NVpndTYFiRRK4hEwmMdA2At80cXuS91V5mKN2A@mail.gmail.com","subject":"Re: [PATCH 1/2] GitHub Actions: update to checkout@v4","fromName":"Óscar Domínguez Celada","fromEmail":"dominguez.celada@gmail.com","sentAt":"2024-02-03T11:39:00Z","receivedAt":"2024-02-03T11:39:38Z","isPatch":true,"sender":{"key":"dominguez.celada@gmail.com","avatar":null},"body":"I am adding non-html e-mail reply to keep track in git@vger.kernel.org:\n\nThe switch to checkout@v4 for GitHub Actions looks good to me. I\nwonder if we should be updating other actions to v4 so they start\nusing Node 20:\n\nIn coverity.yml\n(https://github.com/git/git/blob/8838dd21e8a4ec1324377ffcfa90413844ca3674/.github/workflows/coverity.yml#L101C15-L101C39)\n\nactions/cache/restore@v3 -> v4 (reference:\nhttps://github.com/actions/cache/releases/tag/v4.0.0)\nactions/cache/save@v3 -> v4 (reference:\nhttps://github.com/actions/cache/releases/tag/v4.0.0)\n\nIn main.yml\n\nactions/upload-artifact@v3 -> v4 (reference:\nhttps://github.com/actions/upload-artifact/commit/aa5cae10db2b39d79f5244f6bc5084278993a3ae#diff-1243c5424efaaa19bd8e813c5e6f6da46316e63761421b3e5f5c8ced9a36e6b6R33)\nactions/download-artifact@v3 -> v4 (reference:\nhttps://github.com/actions/download-artifact/commit/88dadfbcfcdd10293192ac8ee1e3ffe61f7055ee#diff-1243c5424efaaa19bd8e813c5e6f6da46316e63761421b3e5f5c8ced9a36e6b6R28)\n\n\nOn Sat, 3 Feb 2024 at 12:31, Óscar Domínguez Celada\n<dominguez.celada@gmail.com> wrote:\n>\n> The switch to checkout@v4 for GitHub Actions looks good to me. I wonder if we should be updating other actions to v4 so they start using Node 20:\n>\n> In coverity.yml\n>\n> actions/cache/restore@v3 -> v4 (reference: https://github.com/actions/cache/releases/tag/v4.0.0)\n> actions/cache/save@v3 -> v4 (reference: https://github.com/actions/cache/releases/tag/v4.0.0)\n>\n> In main.yml\n>\n> actions/upload-artifact@v3 -> v4 (reference: https://github.com/actions/upload-artifact/commit/aa5cae10db2b39d79f5244f6bc5084278993a3ae#diff-1243c5424efaaa19bd8e813c5e6f6da46316e63761421b3e5f5c8ced9a36e6b6R33)\n> actions/download-artifact@v3 -> v4 (reference: https://github.com/actions/download-artifact/commit/88dadfbcfcdd10293192ac8ee1e3ffe61f7055ee#diff-1243c5424efaaa19bd8e813c5e6f6da46316e63761421b3e5f5c8ced9a36e6b6R28)\n>\n>\n> On Fri, 2 Feb 2024 at 21:39, Junio C Hamano <gitster@pobox.com> wrote:\n>>\n>> We seem to be getting \"Node.js 16 actions are deprecated.\" warnings\n>> for jobs that use checkout@v3.  Except for the i686 containers job\n>> that is kept at checkout@v1 [*], update to checkout@v4, which is\n>> said to use Node.js 20.\n>>\n>> [*] 6cf4d908 (ci(main): upgrade actions/checkout to v3, 2022-12-05)\n>>     refers to https://github.com/actions/runner/issues/2115 and\n>>     explains why container jobs are kept at checkout@v1.  We may\n>>     want to check the current status of the issue and move it to the\n>>     same version as other jobs, but that is outside the scope of\n>>     this step.\n>>\n>> Signed-off-by: Junio C Hamano <gitster@pobox.com>\n>> ---\n>>  .github/workflows/check-whitespace.yml |  2 +-\n>>  .github/workflows/coverity.yml         |  2 +-\n>>  .github/workflows/main.yml             | 18 +++++++++---------\n>>  3 files changed, 11 insertions(+), 11 deletions(-)\n>>\n>> diff --git a/.github/workflows/check-whitespace.yml b/.github/workflows/check-whitespace.yml\n>> index a58e2dc8ad..a241a63428 100644\n>> --- a/.github/workflows/check-whitespace.yml\n>> +++ b/.github/workflows/check-whitespace.yml\n>> @@ -19,7 +19,7 @@ jobs:\n>>    check-whitespace:\n>>      runs-on: ubuntu-latest\n>>      steps:\n>> -    - uses: actions/checkout@v3\n>> +    - uses: actions/checkout@v4\n>>        with:\n>>          fetch-depth: 0\n>>\n>> diff --git a/.github/workflows/coverity.yml b/.github/workflows/coverity.yml\n>> index e5532d381b..a81a7566d1 100644\n>> --- a/.github/workflows/coverity.yml\n>> +++ b/.github/workflows/coverity.yml\n>> @@ -38,7 +38,7 @@ jobs:\n>>        COVERITY_LANGUAGE: cxx\n>>        COVERITY_PLATFORM: overridden-below\n>>      steps:\n>> -      - uses: actions/checkout@v3\n>> +      - uses: actions/checkout@v4\n>>        - name: install minimal Git for Windows SDK\n>>          if: contains(matrix.os, 'windows')\n>>          uses: git-for-windows/setup-git-for-windows-sdk@v1\n>> diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml\n>> index 4d97da57ec..90973f9693 100644\n>> --- a/.github/workflows/main.yml\n>> +++ b/.github/workflows/main.yml\n>> @@ -112,7 +112,7 @@ jobs:\n>>        group: windows-build-${{ github.ref }}\n>>        cancel-in-progress: ${{ needs.ci-config.outputs.skip_concurrent == 'yes' }}\n>>      steps:\n>> -    - uses: actions/checkout@v3\n>> +    - uses: actions/checkout@v4\n>>      - uses: git-for-windows/setup-git-for-windows-sdk@v1\n>>      - name: build\n>>        shell: bash\n>> @@ -173,10 +173,10 @@ jobs:\n>>        group: vs-build-${{ github.ref }}\n>>        cancel-in-progress: ${{ needs.ci-config.outputs.skip_concurrent == 'yes' }}\n>>      steps:\n>> -    - uses: actions/checkout@v3\n>> +    - uses: actions/checkout@v4\n>>      - uses: git-for-windows/setup-git-for-windows-sdk@v1\n>>      - name: initialize vcpkg\n>> -      uses: actions/checkout@v3\n>> +      uses: actions/checkout@v4\n>>        with:\n>>          repository: 'microsoft/vcpkg'\n>>          path: 'compat/vcbuild/vcpkg'\n>> @@ -297,7 +297,7 @@ jobs:\n>>        runs_on_pool: ${{matrix.vector.pool}}\n>>      runs-on: ${{matrix.vector.pool}}\n>>      steps:\n>> -    - uses: actions/checkout@v3\n>> +    - uses: actions/checkout@v4\n>>      - run: ci/install-dependencies.sh\n>>      - run: ci/run-build-and-tests.sh\n>>      - name: print test failures\n>> @@ -317,7 +317,7 @@ jobs:\n>>        CC: clang\n>>      runs-on: ubuntu-latest\n>>      steps:\n>> -    - uses: actions/checkout@v3\n>> +    - uses: actions/checkout@v4\n>>      - run: ci/install-dependencies.sh\n>>      - run: ci/run-build-and-minimal-fuzzers.sh\n>>    dockerized:\n>> @@ -342,7 +342,7 @@ jobs:\n>>      runs-on: ubuntu-latest\n>>      container: ${{matrix.vector.image}}\n>>      steps:\n>> -    - uses: actions/checkout@v3\n>> +    - uses: actions/checkout@v4\n>>        if: matrix.vector.jobname != 'linux32'\n>>      - uses: actions/checkout@v1\n>>        if: matrix.vector.jobname == 'linux32'\n>> @@ -373,7 +373,7 @@ jobs:\n>>        group: static-analysis-${{ github.ref }}\n>>        cancel-in-progress: ${{ needs.ci-config.outputs.skip_concurrent == 'yes' }}\n>>      steps:\n>> -    - uses: actions/checkout@v3\n>> +    - uses: actions/checkout@v4\n>>      - run: ci/install-dependencies.sh\n>>      - run: ci/run-static-analysis.sh\n>>      - run: ci/check-directional-formatting.bash\n>> @@ -396,7 +396,7 @@ jobs:\n>>          artifact: sparse-20.04\n>>      - name: Install the current `sparse` package\n>>        run: sudo dpkg -i sparse-20.04/sparse_*.deb\n>> -    - uses: actions/checkout@v3\n>> +    - uses: actions/checkout@v4\n>>      - name: Install other dependencies\n>>        run: ci/install-dependencies.sh\n>>      - run: make sparse\n>> @@ -411,6 +411,6 @@ jobs:\n>>        jobname: Documentation\n>>      runs-on: ubuntu-latest\n>>      steps:\n>> -    - uses: actions/checkout@v3\n>> +    - uses: actions/checkout@v4\n>>      - run: ci/install-dependencies.sh\n>>      - run: ci/test-documentation.sh\n>> --\n>> 2.43.0-522-g2a540e432f\n>>\n>\n>\n> --\n> Óscar Domínguez Celada\n\n\n\n-- \nÓscar Domínguez Celada\n"},{"id":"487876","messageId":"xmqqh6ipsby4.fsf@gitster.g","threadId":"60837","inReplyTo":"CADCFv=4Gjh5B6RFF3P--FO9T7R+uGg2dyN8hT4VR0yJtJt-UsA@mail.gmail.com","subject":"Re: [PATCH 1/2] GitHub Actions: update to checkout@v4","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2024-02-03T17:18:59Z","receivedAt":"2024-02-03T17:19:12Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Óscar Domínguez Celada <dominguez.celada@gmail.com> writes:\n\n> I am adding non-html e-mail reply to keep track in git@vger.kernel.org:\n>\n> The switch to checkout@v4 for GitHub Actions looks good to me. I\n> wonder if we should be updating other actions to v4 so they start\n> using Node 20:\n\nNo need to wonder.  I only noticed the ones involved in the main CI\njob that triggered the warnings, and dealt only with the \"easy\" ones\n;-)  The primary reason why I CC'ed you was because I hoped you knew\nbetter about the \"container jobs are pinned at checkout@v1\", which I\nleft as-is.\n\nHelp in updating other actions to newer versions, if needed, is greatly\nappreciated.\n"}]}