threads / patch / 59481

patcht3701: we don't need no Perl for `add -i` anymore

Subject: [PATCH] t3701: we don't need no Perl for `add -i` anymore

## tl;dr

2 messages between Mar 27, 2023 and Mar 27, 2023. Diffs are folded; open one to read it.

replies: 1people: 2as markdown or json

Johannes Schindelin via GitGitGadget· Mar 27, 2023, 06:36 UTC · lore
From: Johannes Schindelin <johannes.schindelin@gmx.de>
This should have been removed in `ab/retire-scripted-add-p` but wasn't.
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
---
    t3701: remove PERL prereq
    
    I just noticed that this is still left-over.
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1504%2Fdscho%2Ft3701-needs-no-perl-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1504/dscho/t3701-needs-no-perl-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/1504
 t/t3701-add-interactive.sh | 6 ------
 1 file changed, 6 deletions(-)
Show changes to t/t3701-add-interactive.sh +0 −6
diff --git a/t/t3701-add-interactive.sh b/t/t3701-add-interactive.sh
index 3a99837d9b1..ac43333619d 100755
--- a/t/t3701-add-interactive.sh
+++ b/t/t3701-add-interactive.sh
@@ -7,12 +7,6 @@ export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME
 . ./test-lib.sh
 . "$TEST_DIRECTORY"/lib-terminal.sh
 
-if test_have_prereq !PERL
-then
-	skip_all='skipping add -i (scripted) tests, perl not available'
-	test_done
-fi
-
 diff_cmp () {
 	for x
 	do

base-commit: 73876f4861cd3d187a4682290ab75c9dccadbc56

-- 
gitgitgadget
Junio C Hamano· Mar 27, 2023, 17:40 UTC · re: Johannes Schindelin via GitGitGadget · lore

Re: [PATCH] t3701: we don't need no Perl for `add -i` anymore

"Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com> writes:

Show 6 quoted lines
> -if test_have_prereq !PERL
> -then
> -	skip_all='skipping add -i (scripted) tests, perl not available'
> -	test_done
> -fi
> -

The version before ab/retire-scripted-add-p partially touched this line used to use !ADD_I_USE_BUILTIN,!PERL as the prerequisites, i.e. "When we are not testing the built-in version, skip this script if we do not have a working Perl". Now we no longer have the scripted one, the former half of the prerequisite is never satisified (i.e. we are always testing the built-in version, and there is no reason to see if Perl is available).

With this the topic becomes complete.  Very nice.

I read the changes other test scripts touched by the topic just to double check, and it seems this was the only misconversion. t2016 and t6132 had the same logic but spelled in different ways, and there were converted correctly back then.

Will queue.  Thanks.

← back to recent threads