{"thread":{"id":"59481","subject":"[PATCH] t3701: we don't need no Perl for `add -i` anymore","startedAt":"2023-03-27T06:36:53Z","lastAt":"2023-03-27T17:40:11Z","messageCount":2,"participants":["Johannes Schindelin via GitGitGadget","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"474212","messageId":"pull.1504.git.1679898996492.gitgitgadget@gmail.com","threadId":"59481","inReplyTo":null,"subject":"[PATCH] t3701: we don't need no Perl for `add -i` anymore","fromName":"Johannes Schindelin via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2023-03-27T06:36:36Z","receivedAt":"2023-03-27T06:36:53Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"From: Johannes Schindelin <johannes.schindelin@gmx.de>\n\nThis should have been removed in `ab/retire-scripted-add-p` but wasn't.\n\nSigned-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>\n---\n    t3701: remove PERL prereq\n    \n    I just noticed that this is still left-over.\n\nPublished-As: https://github.com/gitgitgadget/git/releases/tag/pr-1504%2Fdscho%2Ft3701-needs-no-perl-v1\nFetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1504/dscho/t3701-needs-no-perl-v1\nPull-Request: https://github.com/gitgitgadget/git/pull/1504\n\n t/t3701-add-interactive.sh | 6 ------\n 1 file changed, 6 deletions(-)\n\ndiff --git a/t/t3701-add-interactive.sh b/t/t3701-add-interactive.sh\nindex 3a99837d9b1..ac43333619d 100755\n--- a/t/t3701-add-interactive.sh\n+++ b/t/t3701-add-interactive.sh\n@@ -7,12 +7,6 @@ export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME\n . ./test-lib.sh\n . \"$TEST_DIRECTORY\"/lib-terminal.sh\n \n-if test_have_prereq !PERL\n-then\n-\tskip_all='skipping add -i (scripted) tests, perl not available'\n-\ttest_done\n-fi\n-\n diff_cmp () {\n \tfor x\n \tdo\n\nbase-commit: 73876f4861cd3d187a4682290ab75c9dccadbc56\n-- \ngitgitgadget\n"},{"id":"474248","messageId":"xmqqzg7yaya4.fsf@gitster.g","threadId":"59481","inReplyTo":"pull.1504.git.1679898996492.gitgitgadget@gmail.com","subject":"Re: [PATCH] t3701: we don't need no Perl for `add -i` anymore","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2023-03-27T17:40:03Z","receivedAt":"2023-03-27T17:40:11Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"Johannes Schindelin via GitGitGadget\" <gitgitgadget@gmail.com>\nwrites:\n\n> -if test_have_prereq !PERL\n> -then\n> -\tskip_all='skipping add -i (scripted) tests, perl not available'\n> -\ttest_done\n> -fi\n> -\n\nThe version before ab/retire-scripted-add-p partially touched this\nline used to use !ADD_I_USE_BUILTIN,!PERL as the prerequisites, i.e.\n\"When we are not testing the built-in version, skip this script if\nwe do not have a working Perl\".  Now we no longer have the scripted\none, the former half of the prerequisite is never satisified (i.e.\nwe are always testing the built-in version, and there is no reason\nto see if Perl is available).\n\nWith this the topic becomes complete.  Very nice.\n\nI read the changes other test scripts touched by the topic just to\ndouble check, and it seems this was the only misconversion.  t2016\nand t6132 had the same logic but spelled in different ways, and\nthere were converted correctly back then.\n\nWill queue.  Thanks.\n"}]}