threads / patch / 5935

patchsvnimport: Fix broken tags being generated

Subject: [PATCH] svnimport: Fix broken tags being generated

## tl;dr

3 messages between Oct 16, 2006 and Oct 16, 2006. Diffs are folded; open one to read it.

replies: 2people: 2as markdown or json

Petr Baudis· Oct 16, 2006, 01:00 UTC · lore

Currently git-svnimport generates broken tags missing the timespec in the 'tagger' line. This is a random stab at a minimal fix.

Signed-off-by: Petr Baudis <pasky@suse.cz>
---

 git-svnimport.perl |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Show changes to git-svnimport.perl +1 −1

diff --git a/git-svnimport.perl b/git-svnimport.perl
index 988514e..aca0e4f 100755
--- a/git-svnimport.perl
+++ b/git-svnimport.perl
@@ -838,7 +838,7 @@ #	}
 		print $out ("object $cid\n".
 		    "type commit\n".
 		    "tag $dest\n".
-		    "tagger $committer_name <$committer_email>\n") and
+		    "tagger $committer_name <$committer_email> 0 +0000\n") and
 		close($out)
 		    or die "Cannot create tag object $dest: $!\n";

Junio C Hamano· Oct 16, 2006, 05:40 UTC · re: Petr Baudis · lore

Re: [PATCH] svnimport: Fix broken tags being generated

Petr Baudis <pasky@suse.cz> writes:

> Currently git-svnimport generates broken tags missing the timespec in the
> 'tagger' line. This is a random stab at a minimal fix.
>
> Signed-off-by: Petr Baudis <pasky@suse.cz>

Interesting.  Applied.

I remember that older "git tag" does not even add the tagger line (the kernel history starts using one from 2.6.13-rc4 on Jul 28, 2005). Does gitweb handle those tags correctly, I wonder?

Especially for 2.6.11-tree tag there is no info you can guess any "age" information from.

Petr Baudis· Oct 16, 2006, 11:26 UTC · re: Junio C Hamano · lore

Re: [PATCH] svnimport: Fix broken tags being generated

Dear diary, on Mon, Oct 16, 2006 at 07:40:00AM CEST, I got a letter where Junio C Hamano <junkio@cox.net> said that...

Show 12 quoted lines

> Petr Baudis <pasky@suse.cz> writes:
> 
> > Currently git-svnimport generates broken tags missing the timespec in the
> > 'tagger' line. This is a random stab at a minimal fix.
> >
> > Signed-off-by: Petr Baudis <pasky@suse.cz>
> 
> Interesting.  Applied.
> 
> I remember that older "git tag" does not even add the tagger
> line (the kernel history starts using one from 2.6.13-rc4 on Jul
> 28, 2005).  Does gitweb handle those tags correctly, I wonder?

It seems from git_tag() that the original author thought about that.

-- 
				Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
#!/bin/perl -sp0777i<X+d*lMLa^*lN%0]dsXx++lMlN/dsM0<j]dsj
$/=unpack('H*',$_);$_=`echo 16dio\U$k"SK$/SM$n\EsN0p[lN*1
lK[d2%Sa2/d0$^Ixp"|dc`;s/\W//g;$_=pack('H*',/((..)*)$/)