{"thread":{"id":"5935","subject":"[PATCH] svnimport: Fix broken tags being generated","startedAt":"2006-10-16T01:00:37Z","lastAt":"2006-10-16T11:26:59Z","messageCount":3,"participants":["Petr Baudis","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"28823","messageId":"20061016010037.27259.26157.stgit@machine.or.cz","threadId":"5935","inReplyTo":null,"subject":"[PATCH] svnimport: Fix broken tags being generated","fromName":"Petr Baudis","fromEmail":"pasky@suse.cz","sentAt":"2006-10-16T01:00:37Z","receivedAt":"2006-10-16T01:00:37Z","isPatch":true,"sender":{"key":"pasky@ucw.cz","avatar":"https://avatars.githubusercontent.com/u/18439?v=4"},"body":"Currently git-svnimport generates broken tags missing the timespec in the\n'tagger' line. This is a random stab at a minimal fix.\n\nSigned-off-by: Petr Baudis <pasky@suse.cz>\n---\n\n git-svnimport.perl |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/git-svnimport.perl b/git-svnimport.perl\nindex 988514e..aca0e4f 100755\n--- a/git-svnimport.perl\n+++ b/git-svnimport.perl\n@@ -838,7 +838,7 @@ #\t}\n \t\tprint $out (\"object $cid\\n\".\n \t\t    \"type commit\\n\".\n \t\t    \"tag $dest\\n\".\n-\t\t    \"tagger $committer_name <$committer_email>\\n\") and\n+\t\t    \"tagger $committer_name <$committer_email> 0 +0000\\n\") and\n \t\tclose($out)\n \t\t    or die \"Cannot create tag object $dest: $!\\n\";\n \n"},{"id":"28836","messageId":"7vpscsx1hr.fsf@assigned-by-dhcp.cox.net","threadId":"5935","inReplyTo":"20061016010037.27259.26157.stgit@machine.or.cz","subject":"Re: [PATCH] svnimport: Fix broken tags being generated","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2006-10-16T05:40:00Z","receivedAt":"2006-10-16T05:40:00Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Petr Baudis <pasky@suse.cz> writes:\n\n> Currently git-svnimport generates broken tags missing the timespec in the\n> 'tagger' line. This is a random stab at a minimal fix.\n>\n> Signed-off-by: Petr Baudis <pasky@suse.cz>\n\nInteresting.  Applied.\n\nI remember that older \"git tag\" does not even add the tagger\nline (the kernel history starts using one from 2.6.13-rc4 on Jul\n28, 2005).  Does gitweb handle those tags correctly, I wonder?\n\nEspecially for 2.6.11-tree tag there is no info you can guess\nany \"age\" information from.\n"},{"id":"28841","messageId":"20061016112659.GB20017@pasky.or.cz","threadId":"5935","inReplyTo":"7vpscsx1hr.fsf@assigned-by-dhcp.cox.net","subject":"Re: [PATCH] svnimport: Fix broken tags being generated","fromName":"Petr Baudis","fromEmail":"pasky@suse.cz","sentAt":"2006-10-16T11:26:59Z","receivedAt":"2006-10-16T11:26:59Z","isPatch":true,"sender":{"key":"pasky@ucw.cz","avatar":"https://avatars.githubusercontent.com/u/18439?v=4"},"body":"Dear diary, on Mon, Oct 16, 2006 at 07:40:00AM CEST, I got a letter\nwhere Junio C Hamano <junkio@cox.net> said that...\n> Petr Baudis <pasky@suse.cz> writes:\n> \n> > Currently git-svnimport generates broken tags missing the timespec in the\n> > 'tagger' line. This is a random stab at a minimal fix.\n> >\n> > Signed-off-by: Petr Baudis <pasky@suse.cz>\n> \n> Interesting.  Applied.\n> \n> I remember that older \"git tag\" does not even add the tagger\n> line (the kernel history starts using one from 2.6.13-rc4 on Jul\n> 28, 2005).  Does gitweb handle those tags correctly, I wonder?\n\nIt seems from git_tag() that the original author thought about that.\n\n-- \n\t\t\t\tPetr \"Pasky\" Baudis\nStuff: http://pasky.or.cz/\n#!/bin/perl -sp0777i<X+d*lMLa^*lN%0]dsXx++lMlN/dsM0<j]dsj\n$/=unpack('H*',$_);$_=`echo 16dio\\U$k\"SK$/SM$n\\EsN0p[lN*1\nlK[d2%Sa2/d0$^Ixp\"|dc`;s/\\W//g;$_=pack('H*',/((..)*)$/)\n"}]}