threads / patch / 59248

patchRe:[PATCH 1/1] [gsoc][patch] trace.c, git.c: removed unnecessary parameter to trace_repo_setup

Subject: Re:[PATCH 1/1] [gsoc][patch] trace.c, git.c: removed unnecessary parameter to trace_repo_setup

## tl;dr

One message between Feb 15, 2023 and Feb 15, 2023. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Shuqi Liang· Feb 15, 2023, 17:17 UTC · lore
Hello  Idriss,
I have some suggestions:

Seen like you didn't describe the existing problem and how you fix it in the commit message. You can start with a description of the existing problem in the present tense in your commit message. Also, you should use the imperative mood to describe the change you make.

Maybe you can write something like the below in your commit message after you use git commit -s. ---------------------------------------------------------------------------------------- trace.c, git.c: removed unnecessary parameter to trace_repo_setup

your description of the existing problem.............
Fix them.
Signed-off-by: ...
-------------------------------------------------------------------------------------------

Regards, Shuqi

← back to recent threads