# Re:[PATCH 1/1] [gsoc][patch] trace.c, git.c: removed unnecessary parameter to trace_repo_setup

1 messages from 2023-02-15 to 2023-02-15. Participants: Shuqi Liang.
Thread: https://gitlist.dev/t/59248

## Shuqi Liang, 2023-02-15 17:17

Subject: Re:[PATCH 1/1] [gsoc][patch] trace.c, git.c: removed unnecessary parameter to trace_repo_setup
Message-ID: <CAMO4yUECbDFD3OxGU2u5QQzXYbej-N+=-=ODjskO12MXmFdYUA@mail.gmail.com>
URL: https://gitlist.dev/e/CAMO4yUECbDFD3OxGU2u5QQzXYbej-N%2B%3D-%3DODjskO12MXmFdYUA%40mail.gmail.com

```
Hello  Idriss,

I have some suggestions：

Seen like you didn't describe the existing problem and how you fix it
in the commit message. You can start with a description of the
existing problem in the present tense in your commit message. Also,
you should use the imperative mood to describe the change you make.

Maybe you can write something like the below in your commit message
after you use git commit -s.
----------------------------------------------------------------------------------------
trace.c, git.c: removed unnecessary parameter to trace_repo_setup

your description of the existing problem.............

Fix them.

Signed-off-by: ...
-------------------------------------------------------------------------------------------





Regards,
Shuqi

```