threads / patch / 587

patchcg-init should only process files

Subject: [PATCH] cg-init should only process files

## tl;dr

3 messages between May 12, 2005 and May 12, 2005. Diffs are folded; open one to read it.

replies: 2people: 2as markdown or json

David Greaves· May 12, 2005, 16:03 UTC · lore

cg-init tries to add directories

Signed-off-by: David Greaves <david@dgreaves.com>

--- commit c6ecba40932efa0b28cd15d00fdab3b2607ec069 tree 39f7bebbadf6ebae67367b629d8cec298f7dcc90 parent f7d4b2adfc6a29036e2a8abe5b742e57b64e50d7 author David Greaves <david@dgreaves.com> Thu, 12 May 2005 13:05:03 +0100 committer David Greaves <david@ash.(none)> Thu, 12 May 2005 13:05:03 +0100

 cg-init |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)

Show changes to diff +1 −1

Index: cg-init
===================================================================
--- 85d8d081e2012da8dd1af35b62ae82f79f89ebd0/cg-init  (mode:100755)
+++ 39f7bebbadf6ebae67367b629d8cec298f7dcc90/cg-init  (mode:100755)
@@ -31,7 +31,7 @@
 	echo "Cloned (origin $uri available as branch \"origin\")"
 else
 	git-read-tree # Seed the dircache
-	find * | xargs cg-add
+	find * -type f | xargs cg-add
 	cg-commit -C -m"Initial commit" -e
 fi
 exit 0

Morten Welinder· May 12, 2005, 16:37 UTC · re: David Greaves · lore

Re: [PATCH] cg-init should only process files

> -       find * | xargs cg-add
> +       find * -type f | xargs cg-add

I think we went through that a day or two ago:  Problems:

1. You forgot symlinks.
2. It does not work if nothing matches "*".  (Nor does the original.)
3. Either it should not match dotfiles in subdirectories, or else it
should match
   them in the top directory too.
4. With needs some -print0 and "--" protection.

Morten

David Greaves· May 12, 2005, 16:45 UTC · re: Morten Welinder · lore

Re: [PATCH] cg-init should only process files

Morten Welinder wrote:

Show 7 quoted lines

>>-       find * | xargs cg-add
>>+       find * -type f | xargs cg-add
>>    
>>
>
>I think we went through that a day or two ago:
>

Doh! I even commented.

Sorry for the noise.

David