{"thread":{"id":"587","subject":"[PATCH] cg-init should only process files","startedAt":"2005-05-12T16:03:15Z","lastAt":"2005-05-12T16:45:22Z","messageCount":3,"participants":["David Greaves","Morten Welinder"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"3161","messageId":"E1DWG9b-0001VV-V0@ash.dgreaves.com","threadId":"587","inReplyTo":null,"subject":"[PATCH] cg-init should only process files","fromName":"David Greaves","fromEmail":"david@dgreaves.com","sentAt":"2005-05-12T16:03:15Z","receivedAt":"2005-05-12T16:03:15Z","isPatch":true,"sender":{"key":"david@dgreaves.com","avatar":"https://gravatar.com/avatar/ca67bad50999edcdd137c9a65da2381557d175bea99ae956afdabc5785e42b79?d=mp&s=160"},"body":"cg-init tries to add directories\n\nSigned-off-by: David Greaves <david@dgreaves.com>\n\n---\ncommit c6ecba40932efa0b28cd15d00fdab3b2607ec069\ntree 39f7bebbadf6ebae67367b629d8cec298f7dcc90\nparent f7d4b2adfc6a29036e2a8abe5b742e57b64e50d7\nauthor David Greaves <david@dgreaves.com> Thu, 12 May 2005 13:05:03 +0100\ncommitter David Greaves <david@ash.(none)> Thu, 12 May 2005 13:05:03 +0100\n\n cg-init |    2 +-\n 1 files changed, 1 insertion(+), 1 deletion(-)\n\nIndex: cg-init\n===================================================================\n--- 85d8d081e2012da8dd1af35b62ae82f79f89ebd0/cg-init  (mode:100755)\n+++ 39f7bebbadf6ebae67367b629d8cec298f7dcc90/cg-init  (mode:100755)\n@@ -31,7 +31,7 @@\n \techo \"Cloned (origin $uri available as branch \\\"origin\\\")\"\n else\n \tgit-read-tree # Seed the dircache\n-\tfind * | xargs cg-add\n+\tfind * -type f | xargs cg-add\n \tcg-commit -C -m\"Initial commit\" -e\n fi\n exit 0\n"},{"id":"3163","messageId":"118833cc050512093750db7d55@mail.gmail.com","threadId":"587","inReplyTo":"E1DWG9b-0001VV-V0@ash.dgreaves.com","subject":"Re: [PATCH] cg-init should only process files","fromName":"Morten Welinder","fromEmail":"mwelinder@gmail.com","sentAt":"2005-05-12T16:37:19Z","receivedAt":"2005-05-12T16:37:19Z","isPatch":true,"sender":{"key":"mwelinder@gmail.com","avatar":null},"body":"> -       find * | xargs cg-add\n> +       find * -type f | xargs cg-add\n\nI think we went through that a day or two ago:  Problems:\n\n1. You forgot symlinks.\n2. It does not work if nothing matches \"*\".  (Nor does the original.)\n3. Either it should not match dotfiles in subdirectories, or else it\nshould match\n   them in the top directory too.\n4. With needs some -print0 and \"--\" protection.\n\nMorten\n"},{"id":"3164","messageId":"42838822.9000908@dgreaves.com","threadId":"587","inReplyTo":"118833cc050512093750db7d55@mail.gmail.com","subject":"Re: [PATCH] cg-init should only process files","fromName":"David Greaves","fromEmail":"david@dgreaves.com","sentAt":"2005-05-12T16:45:22Z","receivedAt":"2005-05-12T16:45:22Z","isPatch":true,"sender":{"key":"david@dgreaves.com","avatar":"https://gravatar.com/avatar/ca67bad50999edcdd137c9a65da2381557d175bea99ae956afdabc5785e42b79?d=mp&s=160"},"body":"Morten Welinder wrote:\n\n>>-       find * | xargs cg-add\n>>+       find * -type f | xargs cg-add\n>>    \n>>\n>\n>I think we went through that a day or two ago:\n>\nDoh!\nI even commented.\n\nSorry for the noise.\n\nDavid\n\n"}]}