threads / patch / 57683

patchsubmodule-helper: Fix a missing space

Subject: [PATCH] submodule-helper: Fix a missing space

## tl;dr

2 messages between Apr 6, 2022 and Apr 7, 2022. Diffs are folded; open one to read it.

replies: 1people: 2as markdown or json

Fangyi Zhou· Apr 6, 2022, 20:32 UTC · lore

The missing space at the end of the line makes the closing square bracket sticking to the dash in the next line

Found during localisation v2.36.0 round 1

Signed-off-by: Fangyi Zhou <me@fangyi.io>
---
 builtin/submodule--helper.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Show changes to builtin/submodule--helper.c +1 −1

diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c
index c3e0d4570f..0b8b226c8f 100644
--- a/builtin/submodule--helper.c
+++ b/builtin/submodule--helper.c
@@ -1902,7 +1902,7 @@ static int module_clone(int argc, const char **argv, const char *prefix)
 	const char *const git_submodule_helper_usage[] = {
 		N_("git submodule--helper clone [--prefix=<path>] [--quiet] "
 		   "[--reference <repository>] [--name <name>] [--depth <depth>] "
-		   "[--single-branch] [--filter <filter-spec>]"
+		   "[--single-branch] [--filter <filter-spec>] "
 		   "--url <url> --path <path>"),
 		NULL
 	};

-- 
2.35.1

Junio C Hamano· Apr 7, 2022, 14:46 UTC · re: Fangyi Zhou · lore

Re: [PATCH] submodule-helper: Fix a missing space

Fangyi Zhou <me@fangyi.io> writes:

Show 7 quoted lines

> The missing space at the end of the line makes the closing square
> bracket sticking to the dash in the next line
>
> Found during localisation v2.36.0 round 1
>
> Signed-off-by: Fangyi Zhou <me@fangyi.io>
> ---

As this is new in 2.36, let's queue it for -rc1.

Thanks.

Show 16 quoted lines

>  builtin/submodule--helper.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c
> index c3e0d4570f..0b8b226c8f 100644
> --- a/builtin/submodule--helper.c
> +++ b/builtin/submodule--helper.c
> @@ -1902,7 +1902,7 @@ static int module_clone(int argc, const char **argv, const char *prefix)
>  	const char *const git_submodule_helper_usage[] = {
>  		N_("git submodule--helper clone [--prefix=<path>] [--quiet] "
>  		   "[--reference <repository>] [--name <name>] [--depth <depth>] "
> -		   "[--single-branch] [--filter <filter-spec>]"
> +		   "[--single-branch] [--filter <filter-spec>] "
>  		   "--url <url> --path <path>"),
>  		NULL
>  	};