# [PATCH] submodule-helper: Fix a missing space

2 messages from 2022-04-06 to 2022-04-07. Participants: Fangyi Zhou, Junio C Hamano.
Thread: https://gitlist.dev/t/57683

## Fangyi Zhou, 2022-04-06 20:32

Subject: [PATCH] submodule-helper: Fix a missing space
Message-ID: <20220406203256.16100-1-me@fangyi.io>
URL: https://gitlist.dev/e/20220406203256.16100-1-me%40fangyi.io

```
The missing space at the end of the line makes the closing square
bracket sticking to the dash in the next line

Found during localisation v2.36.0 round 1

Signed-off-by: Fangyi Zhou <me@fangyi.io>
---
 builtin/submodule--helper.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c
index c3e0d4570f..0b8b226c8f 100644
--- a/builtin/submodule--helper.c
+++ b/builtin/submodule--helper.c
@@ -1902,7 +1902,7 @@ static int module_clone(int argc, const char **argv, const char *prefix)
 	const char *const git_submodule_helper_usage[] = {
 		N_("git submodule--helper clone [--prefix=<path>] [--quiet] "
 		   "[--reference <repository>] [--name <name>] [--depth <depth>] "
-		   "[--single-branch] [--filter <filter-spec>]"
+		   "[--single-branch] [--filter <filter-spec>] "
 		   "--url <url> --path <path>"),
 		NULL
 	};
-- 
2.35.1


```

## Junio C Hamano, 2022-04-07 14:46

Subject: Re: [PATCH] submodule-helper: Fix a missing space
Message-ID: <xmqqilrluf2p.fsf@gitster.g>
URL: https://gitlist.dev/e/xmqqilrluf2p.fsf%40gitster.g
In-Reply-To: <20220406203256.16100-1-me@fangyi.io>

```
Fangyi Zhou <me@fangyi.io> writes:

> The missing space at the end of the line makes the closing square
> bracket sticking to the dash in the next line
>
> Found during localisation v2.36.0 round 1
>
> Signed-off-by: Fangyi Zhou <me@fangyi.io>
> ---

As this is new in 2.36, let's queue it for -rc1.

Thanks.

>  builtin/submodule--helper.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c
> index c3e0d4570f..0b8b226c8f 100644
> --- a/builtin/submodule--helper.c
> +++ b/builtin/submodule--helper.c
> @@ -1902,7 +1902,7 @@ static int module_clone(int argc, const char **argv, const char *prefix)
>  	const char *const git_submodule_helper_usage[] = {
>  		N_("git submodule--helper clone [--prefix=<path>] [--quiet] "
>  		   "[--reference <repository>] [--name <name>] [--depth <depth>] "
> -		   "[--single-branch] [--filter <filter-spec>]"
> +		   "[--single-branch] [--filter <filter-spec>] "
>  		   "--url <url> --path <path>"),
>  		NULL
>  	};

```