[PATCH] gitweb: Add snapshot to log; remove redundant commit from log

Luben Tuikov· Sep 28, 2006, 23:50 UTC · lore

This removes redundant "commit" from log in favor of adding "snapshot". The commit can be had by clicking on the title of the entry. From commit | commitdiff | tree To commitdiff | tree | snapshot This makes it consistent with "shortlog".

Adding "snapshot" without removing redundant "commit" makes it too messy as the log gets out of visual alignment.

I'm ambivalent whether this goes in or not.

Signed-off-by: Luben Tuikov <ltuikov@yahoo.com>
---
 gitweb/gitweb.perl |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

Show changes to gitweb/gitweb.perl +2 −2

diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index 953a0ef..9052647 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -2887,11 +2887,11 @@ sub git_log {
 		               $commit);
 		print "<div class=\"title_text\">\n" .
 		      "<div class=\"log_link\">\n" .
-		      $cgi->a({-href => href(action=>"commit", hash=>$commit)}, "commit") .
-		      " | " .
 		      $cgi->a({-href => href(action=>"commitdiff", hash=>$commit)}, "commitdiff") .
 		      " | " .
 		      $cgi->a({-href => href(action=>"tree", hash=>$commit, hash_base=>$commit)}, "tree") .
+		      " | " .
+		      $cgi->a({-href => href(action=>"snapshot", hash=>$commit)}, "snapshot") .
 		      "<br/>\n" .
 		      "</div>\n" .
 		      "<i>" . esc_html($co{'author_name'}) .  " [$ad{'rfc2822'}]</i><br/>\n" .

-- 
1.4.2.1.g05f0f

Junio C Hamano· Sep 29, 2006, 02:29 UTC · re: Luben Tuikov · lore

Re: [PATCH] gitweb: Add snapshot to log; remove redundant commit from log

Luben Tuikov <ltuikov@yahoo.com> writes:

> Adding "snapshot" without removing redundant "commit" makes
> it too messy as the log gets out of visual alignment.
>
> I'm ambivalent whether this goes in or not.

I admit I was who suggested "we might want to", but I agree this is going a bit too far.

Jakub Narebski· Oct 3, 2006, 09:12 UTC · re: Luben Tuikov · lore

Re: [PATCH] gitweb: Add snapshot to log; remove redundant commit from log

Luben Tuikov wrote:

> This removes redundant "commit" from log in favor of adding
> "snapshot".

"Snapshot" link should be added gitweb_have_snapshot conditionally.

-- 
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git

patchgitweb: Add snapshot to log; remove redundant commit from log