{"thread":{"id":"5753","subject":"[PATCH] gitweb: Add snapshot to log; remove redundant commit from log","startedAt":"2006-09-28T23:50:50Z","lastAt":"2006-10-03T09:12:10Z","messageCount":3,"participants":["Luben Tuikov","Junio C Hamano","Jakub Narebski"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"27956","messageId":"20060928235050.63085.qmail@web31808.mail.mud.yahoo.com","threadId":"5753","inReplyTo":null,"subject":"[PATCH] gitweb: Add snapshot to log; remove redundant commit from log","fromName":"Luben Tuikov","fromEmail":"ltuikov@yahoo.com","sentAt":"2006-09-28T23:50:50Z","receivedAt":"2006-09-28T23:50:50Z","isPatch":true,"sender":{"key":"ltuikov@yahoo.com","avatar":null},"body":"This removes redundant \"commit\" from log in favor of adding\n\"snapshot\".  The commit can be had by clicking on the title of\nthe entry.\nFrom\tcommit | commitdiff | tree\nTo\tcommitdiff | tree | snapshot\nThis makes it consistent with \"shortlog\".\n\nAdding \"snapshot\" without removing redundant \"commit\" makes\nit too messy as the log gets out of visual alignment.\n\nI'm ambivalent whether this goes in or not.\n\nSigned-off-by: Luben Tuikov <ltuikov@yahoo.com>\n---\n gitweb/gitweb.perl |    4 ++--\n 1 files changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl\nindex 953a0ef..9052647 100755\n--- a/gitweb/gitweb.perl\n+++ b/gitweb/gitweb.perl\n@@ -2887,11 +2887,11 @@ sub git_log {\n \t\t               $commit);\n \t\tprint \"<div class=\\\"title_text\\\">\\n\" .\n \t\t      \"<div class=\\\"log_link\\\">\\n\" .\n-\t\t      $cgi->a({-href => href(action=>\"commit\", hash=>$commit)}, \"commit\") .\n-\t\t      \" | \" .\n \t\t      $cgi->a({-href => href(action=>\"commitdiff\", hash=>$commit)}, \"commitdiff\") .\n \t\t      \" | \" .\n \t\t      $cgi->a({-href => href(action=>\"tree\", hash=>$commit, hash_base=>$commit)}, \"tree\") .\n+\t\t      \" | \" .\n+\t\t      $cgi->a({-href => href(action=>\"snapshot\", hash=>$commit)}, \"snapshot\") .\n \t\t      \"<br/>\\n\" .\n \t\t      \"</div>\\n\" .\n \t\t      \"<i>\" . esc_html($co{'author_name'}) .  \" [$ad{'rfc2822'}]</i><br/>\\n\" .\n-- \n1.4.2.1.g05f0f\n\n"},{"id":"27970","messageId":"7vven7pfrm.fsf@assigned-by-dhcp.cox.net","threadId":"5753","inReplyTo":"20060928235050.63085.qmail@web31808.mail.mud.yahoo.com","subject":"Re: [PATCH] gitweb: Add snapshot to log; remove redundant commit from log","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2006-09-29T02:29:01Z","receivedAt":"2006-09-29T02:29:01Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Luben Tuikov <ltuikov@yahoo.com> writes:\n\n> Adding \"snapshot\" without removing redundant \"commit\" makes\n> it too messy as the log gets out of visual alignment.\n>\n> I'm ambivalent whether this goes in or not.\n\nI admit I was who suggested \"we might want to\", but I agree this\nis going a bit too far.\n"},{"id":"28142","messageId":"eft9ge$un0$5@sea.gmane.org","threadId":"5753","inReplyTo":"20060928235050.63085.qmail@web31808.mail.mud.yahoo.com","subject":"Re: [PATCH] gitweb: Add snapshot to log; remove redundant commit from log","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2006-10-03T09:12:10Z","receivedAt":"2006-10-03T09:12:10Z","isPatch":true,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"Luben Tuikov wrote:\n\n> This removes redundant \"commit\" from log in favor of adding\n> \"snapshot\".\n\n\"Snapshot\" link should be added gitweb_have_snapshot conditionally.\n-- \nJakub Narebski\nWarsaw, Poland\nShadeHawk on #git\n"}]}