threads / patch / 57184

patcht/README: fix typo

Subject: [PATCH] t/README: fix typo

## tl;dr

6 messages between Jan 4, 2022 and Jan 6, 2022. Diffs are folded; open one to read it.

replies: 5people: 3as markdown or json

Marc Strapetz via GitGitGadget· Jan 4, 2022, 23:17 UTC · lore
From: Marc Strapetz <marc.strapetz@syntevo.com>
Signed-off-by: Marc Strapetz <marc.strapetz@syntevo.com>
---
    t/README: fix typo
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1110%2Fmstrap%2Ffeature%2FREADME-typo-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1110/mstrap/feature/README-typo-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/1110
 t/README | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Show changes to t/README +1 −1
diff --git a/t/README b/t/README
index 2353a4c5e13..f48e0542cdc 100644
--- a/t/README
+++ b/t/README
@@ -466,7 +466,7 @@ explicitly providing repositories when accessing submodule objects is
 complete or needs to be abandoned for whatever reason (in which case the
 migrated codepaths still retain their performance benefits).
 
-GIT_TEST_REQUIRE_PREREQ=<list> allows specifying a space speparated list of
+GIT_TEST_REQUIRE_PREREQ=<list> allows specifying a space separated list of
 prereqs that are required to succeed. If a prereq in this list is triggered by
 a test and then fails then the whole test run will abort. This can help to make
 sure the expected tests are executed and not silently skipped when their

base-commit: dcc0cd074f0c639a0df20461a301af6d45bd582e
-- 
gitgitgadget
Johannes Schindelin· Jan 5, 2022, 16:22 UTC · re: Marc Strapetz via GitGitGadget · lore

Re: [PATCH] t/README: fix typo

Hi Marc,
On Tue, 4 Jan 2022, Marc Strapetz via GitGitGadget wrote:
Show 23 quoted lines
> From: Marc Strapetz <marc.strapetz@syntevo.com>
>
> Signed-off-by: Marc Strapetz <marc.strapetz@syntevo.com>
> ---
>     t/README: fix typo
>
> Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1110%2Fmstrap%2Ffeature%2FREADME-typo-v1
> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1110/mstrap/feature/README-typo-v1
> Pull-Request: https://github.com/gitgitgadget/git/pull/1110
>
>  t/README | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/t/README b/t/README
> index 2353a4c5e13..f48e0542cdc 100644
> --- a/t/README
> +++ b/t/README
> @@ -466,7 +466,7 @@ explicitly providing repositories when accessing submodule objects is
>  complete or needs to be abandoned for whatever reason (in which case the
>  migrated codepaths still retain their performance benefits).
>
> -GIT_TEST_REQUIRE_PREREQ=<list> allows specifying a space speparated list of
> +GIT_TEST_REQUIRE_PREREQ=<list> allows specifying a space separated list of
Good find!

I'm curious, how did you find it? If it was a spell checker, did it also find the "dotsh" typo in the same file (it should be "dots", I think)?

Ciao, Dscho

Show 8 quoted lines
>  prereqs that are required to succeed. If a prereq in this list is triggered by
>  a test and then fails then the whole test run will abort. This can help to make
>  sure the expected tests are executed and not silently skipped when their
>
> base-commit: dcc0cd074f0c639a0df20461a301af6d45bd582e
> --
> gitgitgadget
>
Marc Strapetz· Jan 5, 2022, 16:47 UTC · re: Johannes Schindelin · lore

Re: [PATCH] t/README: fix typo

Hi Dscho,
On 05/01/2022 17:22, Johannes Schindelin wrote:
Show 10 quoted lines
>> @@ -466,7 +466,7 @@ explicitly providing repositories when accessing submodule objects is
>>   complete or needs to be abandoned for whatever reason (in which case the
>>   migrated codepaths still retain their performance benefits).
>>
>> -GIT_TEST_REQUIRE_PREREQ=<list> allows specifying a space speparated list of
>> +GIT_TEST_REQUIRE_PREREQ=<list> allows specifying a space separated list of
> 
> Good find!
> 
> I'm curious, how did you find it? If it was a spell checker, did it also
I found it by plain reading :) as I had troubles to get a test working.
 > find the "dotsh" typo in the same file (it should be "dots", I think)?

I wouldn't have noticed that, but I agree that it should be "test_name_without_dots".

-Marc
Marc Strapetz· Jan 6, 2022, 06:17 UTC · re: Marc Strapetz · lore

Re: [PATCH] t/README: fix typo

On 05/01/2022 17:47, Marc Strapetz wrote:
Show 24 quoted lines
> Hi Dscho,
> 
> On 05/01/2022 17:22, Johannes Schindelin wrote:
>>> @@ -466,7 +466,7 @@ explicitly providing repositories when accessing 
>>> submodule objects is
>>>   complete or needs to be abandoned for whatever reason (in which 
>>> case the
>>>   migrated codepaths still retain their performance benefits).
>>>
>>> -GIT_TEST_REQUIRE_PREREQ=<list> allows specifying a space speparated 
>>> list of
>>> +GIT_TEST_REQUIRE_PREREQ=<list> allows specifying a space separated 
>>> list of
>>
>> Good find!
>>
>> I'm curious, how did you find it? If it was a spell checker, did it also
> 
> I found it by plain reading :) as I had troubles to get a test working.
> 
>  > find the "dotsh" typo in the same file (it should be "dots", I think)?
> 
> I wouldn't have noticed that, but I agree that it should be 
> "test_name_without_dots".

Please disregard my last statement. "test_name_without_dotsh" means "test name without .sh extension". For "t2109-update-index-index-version.sh", the directory will be "trash directory.t2109-update-index-index-version".

-Marc
Junio C Hamano· Jan 6, 2022, 17:48 UTC · re: Marc Strapetz · lore

Re: [PATCH] t/README: fix typo

Marc Strapetz <marc.strapetz@syntevo.com> writes:
Show 9 quoted lines
>>  > find the "dotsh" typo in the same file (it should be "dots", I
>> think)?
>> I wouldn't have noticed that, but I agree that it should be 
>> "test_name_without_dots".
>
> Please disregard my last statement. "test_name_without_dotsh" means
> "test name without .sh extension". For 
> "t2109-update-index-index-version.sh", the directory will be "trash
> directory.t2109-update-index-index-version".

Yup. "without_dot_sh" might have been a better way to spell it, but "without_dotsh" certainly is better than "without_dots".

Thanks for being extra careful. In any case, the original fix is good and has already been queued.

Junio C Hamano· Jan 5, 2022, 20:41 UTC · re: Marc Strapetz via GitGitGadget · lore

Re: [PATCH] t/README: fix typo

"Marc Strapetz via GitGitGadget" <gitgitgadget@gmail.com> writes:
> -GIT_TEST_REQUIRE_PREREQ=<list> allows specifying a space speparated list of
> +GIT_TEST_REQUIRE_PREREQ=<list> allows specifying a space separated list of
Thanks, queued.

← back to recent threads