{"thread":{"id":"57184","subject":"[PATCH] t/README: fix typo","startedAt":"2022-01-04T23:17:08Z","lastAt":"2022-01-06T17:48:16Z","messageCount":6,"participants":["Marc Strapetz via GitGitGadget","Johannes Schindelin","Marc Strapetz","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"445491","messageId":"pull.1110.git.1641338224631.gitgitgadget@gmail.com","threadId":"57184","inReplyTo":null,"subject":"[PATCH] t/README: fix typo","fromName":"Marc Strapetz via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2022-01-04T23:17:04Z","receivedAt":"2022-01-04T23:17:08Z","isPatch":true,"sender":{"key":"marc.strapetz@syntevo.com","avatar":"https://avatars.githubusercontent.com/u/3380730?v=4"},"body":"From: Marc Strapetz \n\nSigned-off-by: Marc Strapetz \n---\n t/README: fix typo\n\nPublished-As: https://github.com/gitgitgadget/git/releases/tag/pr-1110%2Fmstrap%2Ffeature%2FREADME-typo-v1\nFetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1110/mstrap/feature/README-typo-v1\nPull-Request: https://github.com/gitgitgadget/git/pull/1110\n\n t/README | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/t/README b/t/README\nindex 2353a4c5e13..f48e0542cdc 100644\n--- a/t/README\n+++ b/t/README\n@@ -466,7 +466,7 @@ explicitly providing repositories when accessing submodule objects is\n complete or needs to be abandoned for whatever reason (in which case the\n migrated codepaths still retain their performance benefits).\n \n-GIT_TEST_REQUIRE_PREREQ= allows specifying a space speparated list of\n+GIT_TEST_REQUIRE_PREREQ= allows specifying a space separated list of\n prereqs that are required to succeed. If a prereq in this list is triggered by\n a test and then fails then the whole test run will abort. This can help to make\n sure the expected tests are executed and not silently skipped when their\n\nbase-commit: dcc0cd074f0c639a0df20461a301af6d45bd582e\n-- \ngitgitgadget\n"},{"id":"445530","messageId":"nycvar.QRO.7.76.6.2201051701120.7076@tvgsbejvaqbjf.bet","threadId":"57184","inReplyTo":"pull.1110.git.1641338224631.gitgitgadget@gmail.com","subject":"Re: [PATCH] t/README: fix typo","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2022-01-05T16:22:52Z","receivedAt":"2022-01-05T16:23:05Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi Marc,\n\nOn Tue, 4 Jan 2022, Marc Strapetz via GitGitGadget wrote:\n\n> From: Marc Strapetz \n>\n> Signed-off-by: Marc Strapetz \n> ---\n> t/README: fix typo\n>\n> Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1110%2Fmstrap%2Ffeature%2FREADME-typo-v1\n> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1110/mstrap/feature/README-typo-v1\n> Pull-Request: https://github.com/gitgitgadget/git/pull/1110\n>\n> t/README | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/t/README b/t/README\n> index 2353a4c5e13..f48e0542cdc 100644\n> --- a/t/README\n> +++ b/t/README\n> @@ -466,7 +466,7 @@ explicitly providing repositories when accessing submodule objects is\n> complete or needs to be abandoned for whatever reason (in which case the\n> migrated codepaths still retain their performance benefits).\n>\n> -GIT_TEST_REQUIRE_PREREQ= allows specifying a space speparated list of\n> +GIT_TEST_REQUIRE_PREREQ= allows specifying a space separated list of\n\nGood find!\n\nI'm curious, how did you find it? If it was a spell checker, did it also\nfind the \"dotsh\" typo in the same file (it should be \"dots\", I think)?\n\nCiao,\nDscho\n\n> prereqs that are required to succeed. If a prereq in this list is triggered by\n> a test and then fails then the whole test run will abort. This can help to make\n> sure the expected tests are executed and not silently skipped when their\n>\n> base-commit: dcc0cd074f0c639a0df20461a301af6d45bd582e\n> --\n> gitgitgadget\n>\n"},{"id":"445552","messageId":"9f74fc04-ea68-6bdd-3341-ecf7a2aed6cd@syntevo.com","threadId":"57184","inReplyTo":"nycvar.QRO.7.76.6.2201051701120.7076@tvgsbejvaqbjf.bet","subject":"Re: [PATCH] t/README: fix typo","fromName":"Marc Strapetz","fromEmail":"marc.strapetz@syntevo.com","sentAt":"2022-01-05T16:47:31Z","receivedAt":"2022-01-05T18:50:59Z","isPatch":true,"sender":{"key":"marc.strapetz@syntevo.com","avatar":"https://avatars.githubusercontent.com/u/3380730?v=4"},"body":"Hi Dscho,\n\nOn 05/01/2022 17:22, Johannes Schindelin wrote:\n>> @@ -466,7 +466,7 @@ explicitly providing repositories when accessing submodule objects is\n>> complete or needs to be abandoned for whatever reason (in which case the\n>> migrated codepaths still retain their performance benefits).\n>>\n>> -GIT_TEST_REQUIRE_PREREQ= allows specifying a space speparated list of\n>> +GIT_TEST_REQUIRE_PREREQ= allows specifying a space separated list of\n> \n> Good find!\n> \n> I'm curious, how did you find it? If it was a spell checker, did it also\n\nI found it by plain reading :) as I had troubles to get a test working.\n\n > find the \"dotsh\" typo in the same file (it should be \"dots\", I think)?\n\nI wouldn't have noticed that, but I agree that it should be \n\"test_name_without_dots\".\n\n-Marc\n"},{"id":"445577","messageId":"xmqqo84phq3x.fsf@gitster.g","threadId":"57184","inReplyTo":"pull.1110.git.1641338224631.gitgitgadget@gmail.com","subject":"Re: [PATCH] t/README: fix typo","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2022-01-05T20:41:54Z","receivedAt":"2022-01-05T20:42:03Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"Marc Strapetz via GitGitGadget\" writes:\n\n> -GIT_TEST_REQUIRE_PREREQ= allows specifying a space speparated list of\n> +GIT_TEST_REQUIRE_PREREQ= allows specifying a space separated list of\n\nThanks, queued.\n"},{"id":"445617","messageId":"b265de46-9ccd-4f31-d51c-1df1b39606d5@syntevo.com","threadId":"57184","inReplyTo":"9f74fc04-ea68-6bdd-3341-ecf7a2aed6cd@syntevo.com","subject":"Re: [PATCH] t/README: fix typo","fromName":"Marc Strapetz","fromEmail":"marc.strapetz@syntevo.com","sentAt":"2022-01-06T06:17:42Z","receivedAt":"2022-01-06T06:17:45Z","isPatch":true,"sender":{"key":"marc.strapetz@syntevo.com","avatar":"https://avatars.githubusercontent.com/u/3380730?v=4"},"body":"On 05/01/2022 17:47, Marc Strapetz wrote:\n> Hi Dscho,\n> \n> On 05/01/2022 17:22, Johannes Schindelin wrote:\n>>> @@ -466,7 +466,7 @@ explicitly providing repositories when accessing \n>>> submodule objects is\n>>>   complete or needs to be abandoned for whatever reason (in which \n>>> case the\n>>>   migrated codepaths still retain their performance benefits).\n>>>\n>>> -GIT_TEST_REQUIRE_PREREQ= allows specifying a space speparated \n>>> list of\n>>> +GIT_TEST_REQUIRE_PREREQ= allows specifying a space separated \n>>> list of\n>>\n>> Good find!\n>>\n>> I'm curious, how did you find it? If it was a spell checker, did it also\n> \n> I found it by plain reading :) as I had troubles to get a test working.\n> \n> > find the \"dotsh\" typo in the same file (it should be \"dots\", I think)?\n> \n> I wouldn't have noticed that, but I agree that it should be \n> \"test_name_without_dots\".\n\nPlease disregard my last statement. \"test_name_without_dotsh\" means \n\"test name without .sh extension\". For \n\"t2109-update-index-index-version.sh\", the directory will be \"trash \ndirectory.t2109-update-index-index-version\".\n\n-Marc\n"},{"id":"445633","messageId":"xmqqwnjceox1.fsf@gitster.g","threadId":"57184","inReplyTo":"b265de46-9ccd-4f31-d51c-1df1b39606d5@syntevo.com","subject":"Re: [PATCH] t/README: fix typo","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2022-01-06T17:48:10Z","receivedAt":"2022-01-06T17:48:16Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Marc Strapetz writes:\n\n>> > find the \"dotsh\" typo in the same file (it should be \"dots\", I\n>> think)?\n>> I wouldn't have noticed that, but I agree that it should be \n>> \"test_name_without_dots\".\n>\n> Please disregard my last statement. \"test_name_without_dotsh\" means\n> \"test name without .sh extension\". For \n> \"t2109-update-index-index-version.sh\", the directory will be \"trash\n> directory.t2109-update-index-index-version\".\n\nYup. \"without_dot_sh\" might have been a better way to spell it, but\n\"without_dotsh\" certainly is better than \"without_dots\".\n\nThanks for being extra careful. In any case, the original fix is\ngood and has already been queued.\n\n"}]}