threads / discuss / 57131

t5327 log expiry

Subject: t5327 log expiry

## tl;dr

3 messages between Dec 21, 2021 and Dec 21, 2021.

replies: 2people: 3as markdown or json

Han-Wen Nienhuys· Dec 21, 2021, 17:27 UTC · lore

Hi Taylor,

Your recent work on cruft packs breaks with reftable. I suggest the following change

- rm -fr .git/logs &&
+ git reflog expire --all --expire=all &&

to make the test independent of ref storage format.

-- 
Han-Wen Nienhuys - Google Munich
I work 80%. Don't expect answers from me on Fridays.
--
Google Germany GmbH, Erika-Mann-Strasse 33, 80636 Munich
Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg
Geschäftsführer: Paul Manicle, Halimah DeLaine Prado

Junio C Hamano· Dec 21, 2021, 20:48 UTC · re: Han-Wen Nienhuys · lore

Re: t5327 log expiry

Han-Wen Nienhuys <hanwen@google.com> writes:

Show 9 quoted lines

> Hi Taylor,
>
> Your recent work on cruft packs breaks with reftable. I suggest the
> following change
>
> - rm -fr .git/logs &&
> + git reflog expire --all --expire=all &&
>
> to make the test independent of ref storage format.

Thanks.  I should have caught it when I read the patch.

Taylor Blau· Dec 21, 2021, 21:39 UTC · re: Junio C Hamano · lore

Re: t5327 log expiry

On Tue, Dec 21, 2021 at 12:48:17PM -0800, Junio C Hamano wrote:

Show 13 quoted lines

> Han-Wen Nienhuys <hanwen@google.com> writes:
>
> > Hi Taylor,
> >
> > Your recent work on cruft packs breaks with reftable. I suggest the
> > following change
> >
> > - rm -fr .git/logs &&
> > + git reflog expire --all --expire=all &&
> >
> > to make the test independent of ref storage format.
>
> Thanks.  I should have caught it when I read the patch.

And I should have never written it in the first place ;). I did a find-and-replace throughout the series to replace one with the other.

I have some review from Stolee that I want to read through before sending an updated version. I'm planning on looking at that when I get back in the new year.

Thanks, Taylor