{"thread":{"id":"57131","subject":"t5327 log expiry","startedAt":"2021-12-21T17:27:50Z","lastAt":"2021-12-21T21:39:46Z","messageCount":3,"participants":["Han-Wen Nienhuys","Junio C Hamano","Taylor Blau"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"444630","messageId":"CAFQ2z_MckMjRG9bOHeaKfFDkqG5L0AAz2V-uUSwMKTdh3MicGA@mail.gmail.com","threadId":"57131","inReplyTo":null,"subject":"t5327 log expiry","fromName":"Han-Wen Nienhuys","fromEmail":"hanwen@google.com","sentAt":"2021-12-21T17:27:36Z","receivedAt":"2021-12-21T17:27:50Z","isPatch":false,"sender":{"key":"hanwen@google.com","avatar":"https://avatars.githubusercontent.com/u/31547?v=4"},"body":"Hi Taylor,\n\nYour recent work on cruft packs breaks with reftable. I suggest the\nfollowing change\n\n- rm -fr .git/logs &&\n+ git reflog expire --all --expire=all &&\n\nto make the test independent of ref storage format.\n-- \nHan-Wen Nienhuys - Google Munich\nI work 80%. Don't expect answers from me on Fridays.\n--\nGoogle Germany GmbH, Erika-Mann-Strasse 33, 80636 Munich\nRegistergericht und -nummer: Hamburg, HRB 86891\nSitz der Gesellschaft: Hamburg\nGeschäftsführer: Paul Manicle, Halimah DeLaine Prado\n"},{"id":"444659","messageId":"xmqqa6gtptv2.fsf@gitster.g","threadId":"57131","inReplyTo":"CAFQ2z_MckMjRG9bOHeaKfFDkqG5L0AAz2V-uUSwMKTdh3MicGA@mail.gmail.com","subject":"Re: t5327 log expiry","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2021-12-21T20:48:17Z","receivedAt":"2021-12-21T20:48:20Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Han-Wen Nienhuys <hanwen@google.com> writes:\n\n> Hi Taylor,\n>\n> Your recent work on cruft packs breaks with reftable. I suggest the\n> following change\n>\n> - rm -fr .git/logs &&\n> + git reflog expire --all --expire=all &&\n>\n> to make the test independent of ref storage format.\n\nThanks.  I should have caught it when I read the patch.\n"},{"id":"444665","messageId":"YcJJntHTRkPWEEpD@nand.local","threadId":"57131","inReplyTo":"xmqqa6gtptv2.fsf@gitster.g","subject":"Re: t5327 log expiry","fromName":"Taylor Blau","fromEmail":"me@ttaylorr.com","sentAt":"2021-12-21T21:39:42Z","receivedAt":"2021-12-21T21:39:46Z","isPatch":false,"sender":{"key":"me@ttaylorr.com","avatar":"https://avatars.githubusercontent.com/u/301000140?v=4"},"body":"On Tue, Dec 21, 2021 at 12:48:17PM -0800, Junio C Hamano wrote:\n> Han-Wen Nienhuys <hanwen@google.com> writes:\n>\n> > Hi Taylor,\n> >\n> > Your recent work on cruft packs breaks with reftable. I suggest the\n> > following change\n> >\n> > - rm -fr .git/logs &&\n> > + git reflog expire --all --expire=all &&\n> >\n> > to make the test independent of ref storage format.\n>\n> Thanks.  I should have caught it when I read the patch.\n\nAnd I should have never written it in the first place ;). I did a\nfind-and-replace throughout the series to replace one with the other.\n\nI have some review from Stolee that I want to read through before\nsending an updated version. I'm planning on looking at that when I get\nback in the new year.\n\nThanks,\nTaylor\n"}]}